TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
1,868 Commits 2 Branches 0 Tags 294 MiB
da7ba91d86
Commit Graph

1868 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Heinemeier Hansson
da7ba91d86 Fixed that TextHelper#auto_link_urls would include punctuation in the links #2166, #1671 [eigentone] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 05:53:52 +00:00
David Heinemeier Hansson
04594cfadb Fixed "connection lost" issue with the bundled Ruby/MySQL driver (would kill the app after 8 hours of inactivity) #2163, #428 [kajism@yahoo.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2182 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 05:43:46 +00:00
David Heinemeier Hansson
8aa63a78b8 Added test to ensure that silence_warnings also returned its value 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2181 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 05:01:01 +00:00
David Heinemeier Hansson
42093fff94 Added test to ensure that silence_warnings also returned its value 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2180 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 05:00:51 +00:00
David Heinemeier Hansson
3cf7a0a460 Added Kernel#silence_warnings and puts it into use throughout the framework 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2179 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 04:58:27 +00:00
David Heinemeier Hansson
4b53e26ef6 Fix fixture problem for pgsql 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2178 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 04:18:07 +00:00
David Heinemeier Hansson
4836c4081d Fix problem with mime type defaults #2165 [Michael Shuerig] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2177 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 04:17:14 +00:00
David Heinemeier Hansson
7a4a12aeaa Forgot to add core_ext/string/starts_ends_with.rb 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2176 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 09:09:07 +00:00
David Heinemeier Hansson
17ef7067c8 Added -m/--mime-types option to the WEBrick server, so you can specify a Apache-style mime.types file to load #2059 [ask@develooper.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2175 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 09:07:43 +00:00
David Heinemeier Hansson
b33557b622 Added -c/--svn option to the generator that'll add new files and remove destroyed files using svn add/revert/remove as appropriate #2064 [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2174 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 09:02:55 +00:00
David Heinemeier Hansson
0cd7e6c1e0 Added -c/--charset option to WEBrick controller, so you can specify a default charset (which without changes is UTF-8) #2084 [wejn@box.cz] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2173 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:59:07 +00:00
David Heinemeier Hansson
0faca07056 Fixed comparison of Active Record objects so two new objects are not equal #2099 [deberg] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2172 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:54:02 +00:00
David Heinemeier Hansson
74896c0252 Added String#starts_with? and String#ends_with? #2118 [thijs@vandervossen.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2171 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:49:27 +00:00
David Heinemeier Hansson
afbfde9357 Fixed that number_to_currency(1000, {:precision => 0})) should return "$1,000", instead of "$1,000." #2122 [sd@notso.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:43:02 +00:00
David Heinemeier Hansson
3004217855 Fixed that the SQL Server adapter would sometimes return DBI::Timestamp objects instead of Time #2127 [Tom Ward] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2169 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:37:05 +00:00
David Heinemeier Hansson
e5cc729b18 Make the test_find_all_by_one_attribute and test_find_all_by_one_attribute_with_options tests not fail in SQL Server #2128 [Tom Ward] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2168 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:34:51 +00:00
David Heinemeier Hansson
0439769324 Refactored away all the legacy validate_options calls and replaced them with Hash#assert_valid_keys 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:32:47 +00:00
David Heinemeier Hansson
558331596f Make assert_valid_keys slightly more lenient 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2166 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:20:14 +00:00
David Heinemeier Hansson
7dbf051e54 Fix docs #2136 [coffee2code] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:11:53 +00:00
David Heinemeier Hansson
e54b4d3b54 Allow link_to_remote to use any DOM-element as the parent of the form elements to be submitted #2137 [erik@ruby-lang.nl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:10:20 +00:00
David Heinemeier Hansson
b063067321 Added the instance methods #root and #ancestors on acts_as_tree and fixed siblings to not include the current node #2142, #2140 [coffee2code] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2163 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:01:44 +00:00
David Heinemeier Hansson
c8e0e10e28 Added documentation for overwrite_params #2146 [Michael Shuerig] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 07:50:14 +00:00
David Heinemeier Hansson
e3c02d8c66 Fixed that render :partial would fail when :object was a Hash (due to backwards compatibility issues) #2148 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 07:27:44 +00:00
David Heinemeier Hansson
46110aa689 Fixed JavascriptHelper#auto_complete_for to only include unique items #2153 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 07:25:58 +00:00
David Heinemeier Hansson
079d8f4028 Fixed that onclick would be overridden even when special features werent used 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 17:54:16 +00:00
David Heinemeier Hansson
9053c4c83e Added documentation for #1904 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2157 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 17:49:31 +00:00
David Heinemeier Hansson
3c3d936f4d Fixed all AssetHelper methods to work with relative paths, such that javascript_include_tag('stdlib/standard') will look in /javascripts/stdlib/standard instead of '/stdlib/standard/' #1963 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 16:39:06 +00:00
David Heinemeier Hansson
e6428abd23 Fixed a broken test 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2155 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 16:30:13 +00:00
David Heinemeier Hansson
febc24dee7 An explicit include ClassInheritableAttributes is no longer needed #1948 [Caleb Tennis] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 16:28:10 +00:00
David Heinemeier Hansson
eec24a16c7 Fixed that Active Record would call SHOW FIELDS twice (or more) for the same model when the cached results were available #1947 [sd@notso.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2153 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 12:21:36 +00:00
Nicholas Seckar
bf92aacf40 Avoid extending view instance with helper modules each request. Closes #1979 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 12:08:24 +00:00
Nicholas Seckar
689cca132a Performance improvements to CGI methods. Closes #1980 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 11:28:54 +00:00
David Heinemeier Hansson
7b235f0213 Use this.href, not unexisting url 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-07 13:04:09 +00:00
David Heinemeier Hansson
7e3dc807df Added :post option to UrlHelper#link_to that makes it possible to do POST requests through normal ahref links using Javascript 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-07 12:56:33 +00:00
Nicholas Seckar
2f66e873b0 Symbolize the keys of overwritten parameters. Really closes #1909. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-07 08:59:33 +00:00
Nicholas Seckar
3108764367 Fix overwrite params. Closes #1909 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 22:06:11 +00:00
David Heinemeier Hansson
f2a89d7862 Give AR the new benchmark method too 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2143 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 17:47:31 +00:00
David Heinemeier Hansson
f86276b305 Fix fragment benchmark calls and limit timings to 5 decimals 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 17:33:11 +00:00
David Heinemeier Hansson
291c667d66 Only do benchmarking if log level matches and log caching 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 17:07:08 +00:00
David Heinemeier Hansson
5e8e8d6564 Added use_silence parameter to ActiveRecord::Base.benchmark that can be passed false to include all logging statements during the benchmark block. Added ActionController::Base.benchmark and ActionController::Base.silence to allow for easy benchmarking and turning off the log 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 16:48:18 +00:00
David Heinemeier Hansson
50debfa96c Dont encode the default subject for the test cases since they are within the ascii range 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2139 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 11:01:23 +00:00
Jamis Buck
b70e2db64a Make the default stats task extendable by modifying the STATS_DIRECTORIES constant 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2135 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-05 15:39:20 +00:00
Jamis Buck
9eef247339 Allow the selected environment to define RAILS_DEFAULT_LOGGER, and have Rails::Initializer use it if it exists. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2134 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-05 12:36:40 +00:00
Jamis Buck
bfdb437508 Updated vendor copy of html-scanner to support better xml parsing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-05 09:44:22 +00:00
Jamis Buck
873be1258e Fix vendor require paths to prevent files being required twice 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2130 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-05 09:06:55 +00:00
David Heinemeier Hansson
258bacbf82 Added :popup option to UrlHelper#link_to #1996 [gabriel.gironda@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-04 00:33:45 +00:00
David Heinemeier Hansson
9e803e081a Get rid of that silly lock 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2128 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-04 00:28:28 +00:00
David Heinemeier Hansson
558707f61a Silence logger initialization 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2127 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-03 23:05:58 +00:00
David Heinemeier Hansson
3f14b1e94e Updated the options_for_select to deal with the fact that Strings now implement :first 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-03 21:30:54 +00:00
David Heinemeier Hansson
9fdd453257 Fix mocks dir 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2125 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-03 20:21:38 +00:00