TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
39,574 Commits 2 Branches 0 Tags 294 MiB
db2c4abca6
Commit Graph

39574 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Steve Klabnik
db2c4abca6 Merge pull request #12184 from waynn/patch-4 
"previous version of Rails" is gramatically incorrect
 2013-09-10 18:55:29 -07:00
Waynn Lue
e2c17ff3ec [ci skip] 'previous version of Rails' is gramatically incorrect 2013-09-10 16:15:41 -07:00
Steve Klabnik
ba0407337e Add meta tag with charset information to application layout. 
Previously, our default HTML would validate properly, but would generate
a warning: it doesn't declare a character encoding.

According to [the spec][encoding-spec], if you don't specify an
encoding, a 7 step algorithm happens, with a toooon of sub-steps. Or, we
could just actually specify it.

Since everything else in Rails assumes UTF-8, we should make sure pages
are served with that encoding too. This meta tag is the simplest way to
accomplish this.

More resources:

* http://blog.whatwg.org/the-road-to-html-5-character-encoding
* http://www.w3.org/International/tutorials/tutorial-char-enc/
* http://validator.w3.org/

[encoding-spec]: http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#determining-the-character-encoding
 2013-09-10 14:37:39 -07:00
Aaron Patterson
e7facb35eb add a comment for sanity of other people to come 2013-09-10 14:03:19 -07:00
Aaron Patterson
e64b5da550 ask the association for records rather than calling send 2013-09-10 11:54:48 -07:00
Rafael Mendonça França
d68419a88e Merge pull request #12193 from arunagw/revert-revert 
Revert fixes
 2013-09-10 11:07:41 -07:00
Akira Matsuda
5374960a04 Use Ruby 2.0 caller_locations instead of caller if available 
* we no more have to manipulate the each caller strings by ourselves using caller_locations

* caller_locations runs slightly faster, and creates less objects than good old caller
Benchmark (loading an Engine 1000 times):
  caller: 262.89 ms
  caller_locations: 186.068 ms
 2013-09-10 19:57:52 +02:00
Tomas Varaneckas
ad6adcb601 Update Rails 3.2.x guide link [ci skip] 2013-09-10 19:55:23 +02:00
Akira Matsuda
e837e5a96b Be sure to restore the default I18n.locale after changed its value in a test 2013-09-10 19:54:49 +02:00
Jay Hayes
3b7d8351f6 Fixes typo in Object#try! 2013-09-10 19:54:29 +02:00
Akira Matsuda
baaf8cf83f More unused associations in AR test models 2013-09-10 19:50:00 +02:00
Carlos Antonio da Silva
e6a52098d2 ✂️ [ci skip] 2013-09-10 19:49:42 +02:00
Rajarshi Das
48ee1e793e change function def self.table_name to self.table_name 
change def self.primary_key to self.primary_key

change def self.primary_key to self.primary_key
 2013-09-10 19:49:32 +02:00
Akira Matsuda
132190f632 Clean up unused associations in AR test model 2013-09-10 19:49:01 +02:00
Akira Matsuda
b1116bdcc3 Reset ActionView::Base.logger instead of AC::Base.logger 
see: 9b0ac0bc74569db460f87ea6888b3847be0ff5be
 2013-09-10 19:47:04 +02:00
Max Shytikov
6018b83c17 Refactor handling of action normalization 
Reference:
Bloody mess internals
http://gusiev.com/slides/rails_contribution/static/#40
 2013-09-10 18:13:39 +02:00
Akira Matsuda
0c93a48904 Don't mutate the Base settings by merge!ing the given value 2013-09-10 18:10:48 +02:00
Santiago Pastorino
05f88b7b04 Merge pull request #12189 from rajcybage/test_assert 
use assert_empty in activemodel conditional validation test cases
 2013-09-10 07:24:45 -07:00
Guillermo Iguaran
005b33222d Merge pull request #12173 from arunagw/fixes_reverted_by_revert_commit 
Revert fixes
 2013-09-10 07:05:17 -07:00
Santiago Pastorino
a46fa8df06 Make AC standalone rendering work 2013-09-10 11:01:12 -03:00
Rajarshi Das
782d794c20 use assert_empty in activemodel conditional validation test cases 2013-09-10 17:26:39 +05:30
Carlos Antonio da Silva
a1de8a8855 Merge pull request #12187 from anupamc/master 
Removed unnecessary require
 2013-09-10 04:28:44 -07:00
Anupam Choudhury
44f203b0e3 Removed unused modules and classes 2013-09-10 16:44:44 +05:30
Anupam Choudhury
f3e4069ede Removed unnecessary require 2013-09-10 13:22:30 +05:30
Carlos Antonio da Silva
f20f90f89a Merge pull request #12181 from claudiob/remove-unused-helper-fixtures 
Remove helper fixtures not used in any test
 2013-09-09 15:20:10 -07:00
Aaron Patterson
0c5d0beac1 let the class cache object clean up user input 2013-09-09 15:16:41 -07:00
Aaron Patterson
7a30bb112f make @bitsweat happy. ❤️ 2013-09-09 14:52:21 -07:00
Aaron Patterson
e1cbd42546 stop using deprecated api in the tests 2013-09-09 14:47:12 -07:00
claudiob
61d2391352 Remove helper fixtures not used in any test 
The fixture for module AbcHelper defines three functions bare_a,
bare_b and bare_c, but only bare_a is used in the code that tests
helper functions.
 2013-09-09 14:19:09 -07:00
José Valim
1385ae138d Remove BasicRendering tests 2013-09-09 16:10:41 -03:00
José Valim
67336ce199 Remove remaining coupling with AV in MimeResponds 2013-09-09 12:33:53 -03:00
José Valim
a41669563b Remove BasicRendering and remove template functionality from AbsC::Rendering 2013-09-09 12:33:53 -03:00
Steve Klabnik
ff8fac614f Merge pull request #12167 from hannesfostie/grammar-improvement 
[ci skip] Improves a sentence in guides/security
 2013-09-09 08:22:21 -07:00
Arun Agrawal
3dffe65d91 Back AV description in gemspec 2013-09-09 17:12:45 +02:00
Arun Agrawal
6f0b1ae04e Fix order dependent test 
see c48cbb02d7e6f585e31b404c0c363f0d6b586811
 2013-09-09 17:11:16 +02:00
Arun Agrawal
17e860c14e grab executable from rubygems 2013-09-09 17:06:02 +02:00
Arun Agrawal
047b187d0e Fixed API task file 
1. As we have vendor in AV only
2. No more vendor in AC
3. No vendor folder in AR
 2013-09-09 17:04:04 +02:00
Yves Senn
ad6e8a2fec Merge pull request #12157 from robin850/patch-9 
Use MiniTest::Unit::TestCase instead of Minitest::Test  [ci skip]
 2013-09-09 00:45:01 -07:00
Hannes Fostie
84cea5a6d1 Improves a sentence in guides/security 
Changed "... books make this wrong" to "... books get this wrong"
 2013-09-09 09:43:58 +02:00
Yves Senn
73c9365c91 Merge pull request #12166 from JuanitoFatas/doc-patch-1 
[ci skip] Change link name of Rails i18n wiki.
 2013-09-09 00:43:03 -07:00
Juanito Fatas
0096b1535d [ci skip] Change link name of Rails i18n wiki. 
Actually it's Ruby i18n link.
 2013-09-09 14:12:02 +08:00
Steve Klabnik
638adfc447 Merge pull request #12164 from rywall/patch-1 
Typo in Changelog. [ci skip]
 2013-09-08 21:29:38 -07:00
Ryan Wallace
af89118ca3 Typo in Changelog. 2013-09-08 15:55:35 -07:00
Jeremy Kemper
bac28d3bbd Fix fixtures regression that required table names to map to classes only, not class names 2013-09-08 03:03:02 -07:00
Robin Dupret
5c7762b171 Use MiniTest::Unit::TestCase instead of Minitest::Test 
Since Rails 4.0.x is depending on Minitest 4.x, the constant won't be
available so the gist won't run.

[ci skip]
 2013-09-07 12:08:15 +02:00
Xavier Noria
c989a18a74 Merge pull request #12155 from jetthoughts/reformat_guides_code_examples 
Use Ruby on Rails Coding Conventions for code examples in the guides
 2013-09-07 01:33:19 -07:00
Aaron Patterson
6a91a3307f hm:t join tables may not have a primary key 2013-09-06 17:14:07 -07:00
Aaron Patterson
a9da99ee5f use polymorphic proxies to remove duplicate code 2013-09-06 11:47:02 -07:00
Paul Nikitochkin
2c8bc2cdcd Use Ruby on Rails Coding Conventions for code examples in the guides 
* Indent after private/protected
* Ruby >= 1.9 syntax for hashes
* Prefer method { do_stuff } instead of method{do_stuff} for single-line blocks.

[ci skip]
 2013-09-06 21:42:29 +03:00
Aaron Patterson
ea55d86eb1 reduce duplication somewhat 2013-09-06 11:38:28 -07:00