Commit Graph

18160 Commits

Author SHA1 Message Date
Thiago Pradi
df7f441c6e Removing RJS hack
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-02 11:51:07 +02:00
Thiago Pradi
7698596adb Removing unnecessary code from render_test
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-02 11:51:01 +02:00
Thiago Pradi
08187efa5b Removing unnecessary code
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-02 11:50:51 +02:00
Greg Hazel
3f49456f5b remove use of echo [#4410 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-02 11:50:38 +02:00
Akira Matsuda
4d9b2da5f3 "rails console t" must not load "production" but "test"
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-02 11:50:31 +02:00
Santiago Pastorino
920765c4c2 Add ruby-debug19 for mri 1.9 2010-09-01 21:24:33 -03:00
David Heinemeier Hansson
af03462b24 Dont need to spell out the dependency 2010-09-01 19:09:35 -05:00
David Heinemeier Hansson
278bc76ba6 Have sections for both Ruby 1.8.7 and 1.9.2 for the debugger since they use different gems 2010-09-01 17:39:06 -05:00
Andrew White
4e67bf26aa Reset default scope in Thread.current when class is unloaded [#5497 state:resolved]
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-09-01 22:32:41 +02:00
Andrew White
f1966337fa Add before_remove_const callback to ActiveSupport::Dependencies.remove_unloadable_constants!
Signed-off-by: Xavier Noria <fxn@hashref.com>
2010-09-01 22:32:41 +02:00
Emilio Tagua
2ce57fd0d9 Fix test: this should return 0 not 7, since Arel was ignoring select clause and now it's fixed.
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 15:09:38 +02:00
Subba Rao Pasupuleti
0ae81a2124 Refactoring conditional logic
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 14:00:26 +02:00
Subba Rao Pasupuleti
2d74ed49f4 reader method eliminates defined? checks
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 13:59:53 +02:00
Andrew White
02480a897b Move implicit nested call before options handling so that nested constraints work [#5513 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 10:09:14 +02:00
Alex Chrome
dbf82557e4 Added :format option for form_for helper and spec for this [#5226 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 09:59:54 +02:00
Jack Dempsey
a79e985923 split out active_record migration logic so others can easily reuse [#5389 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 09:57:57 +02:00
Neeraj Singh
cacb44874f delegate method should treat :prefix => false same as :prefix => nil
[#5375 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 09:57:13 +02:00
yury
9a6e3ae763 Remove unnecessary code from UrlHelper#link_to.
convert_options_to_data_attributes always returns not nil stringified html_options [#5445 state:resolved]

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 09:57:04 +02:00
Krekoten' Marjan
57693d1362 Make ActiveSupport::Duration#method_missing delegate blocks to value [#5498 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 09:56:54 +02:00
Subba Rao Pasupuleti
dba4efbd0e nested attributes tests should rely on associated objects to verify results not on assert_difference [#5206 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 09:56:48 +02:00
Thiago Pradi
46c14a6b03 Use join instead of looping and calling to_s [#5492 state:resolved]
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-09-01 09:46:30 +02:00
Andrew White
6c3f5eb76c Bump rack-mount to 0.6.13 and add test case for named character classes [#5509 state:resolved]
Signed-off-by: Santiago Pastorino <santiago@wyeworks.com>
2010-08-31 21:16:21 -03:00
Xavier Noria
8b2e4fddbf Merge remote branch 'docrails/master' 2010-09-01 00:01:26 +02:00
Pratik Naik
db6190a022 Make all the Relation finder methods consistent 2010-08-31 22:25:28 +01:00
Pratik Naik
dce0cfae8b Merge remote branch 'miloops/rails_master_fixes' 2010-08-31 22:05:42 +01:00
Pratik Naik
7694b97ddf Remove default values for Relation#limit/offset/from/create_with 2010-08-31 21:56:21 +01:00
Emilio Tagua
c11eec8482 Avoid calling build_where is no argument is given. 2010-08-31 15:47:59 -03:00
Pratik Naik
c07f0ae52e Change relation merging to always append select, group and order values 2010-08-31 19:17:18 +01:00
Emilio Tagua
87e50f104a Improved conditionals usage to prevent calling methods. 2010-08-31 15:06:02 -03:00
Emilio Tagua
2431af1b7f Don't test conditional in iteration if it is not present just clone it. 2010-08-31 13:19:06 -03:00
Neeraj Singh
67a2b5ec1b If certain sections of skip_callback method are commented out then
no test was failing. Tests have been added to ensure that commenting
out the code within if loop would cause test failure.

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-31 17:45:06 +02:00
Neeraj Singh
d8db5714aa replacing superclass_delegating_accessor with class_attribute
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-31 17:45:06 +02:00
Neeraj Singh
a64cc69d61 Replacing superclass_delegating_accessoror with class_attribute.
:store_full_sti_class will have value true or false so there is no
danger of mutability here.

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-31 17:45:06 +02:00
Neeraj Singh
1620f572bf Replacing superclass_delegating_accessoror with class_attribute.
:partial_attributes will have value true or false so there is no
danger of mutability here.

Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-31 17:45:06 +02:00
Neeraj Singh
8402488568 adding new test for ActiveModel::Serialization
Signed-off-by: José Valim <jose.valim@gmail.com>
2010-08-31 17:45:03 +02:00
Santiago Pastorino
94b850c661 Bring back build to the initialization guide 2010-08-31 11:54:07 -03:00
Damien Mathieu
28474a7571 Fix benchmarking for rails3
* Fix the generated file examples
* Fix the generators commands
2010-08-31 13:39:08 +02:00
wycats
58d3b90423 Speed up form_for by specializing extract_options! (at asakusa.rb) 2010-08-31 20:33:28 +09:00
wycats
c05f24c824 Speed up content_tag_for by simplifying needed logic 2010-08-31 19:52:26 +09:00
Jaime Iniesta
c2ed4a9f88 Fix API docs for button_to options 2010-08-31 09:19:43 +02:00
Michael MacDonald
362371690f Corrected typo in example on rendering collections in partials changing @posts to @products to match the example 2010-08-31 11:01:05 +10:00
Pratik Naik
5076af5aa1 Fix an english fail 2010-08-31 00:16:31 +01:00
Pratik Naik
6d8fc26ce8 Fix the readonly section 2010-08-31 00:14:49 +01:00
Pratik Naik
5a310f8335 Update the section about joins 2010-08-31 00:01:41 +01:00
Pratik Naik
0bb32588b7 Fix pessimistic locking examples 2010-08-30 23:52:27 +01:00
Pratik Naik
9cd708b2cf Reword calculations section 2010-08-30 23:45:03 +01:00
Pratik Naik
d0720ad5f8 Reword the section about exists? 2010-08-30 23:45:03 +01:00
Pratik Naik
ceca3a0564 Improve example for having() 2010-08-30 23:45:03 +01:00
Pratik Naik
767eca4913 Remove {} from hash conditions. And more occurrences of [] in array conditions 2010-08-30 23:45:03 +01:00
Pratik Naik
1e554a1175 Array conditions dont need [] 2010-08-30 23:45:03 +01:00