Commit Graph

56867 Commits

Author SHA1 Message Date
Prathamesh Sonpatki
e700f8ebfb Fix formatting in Action Cable guide [ci skip] 2016-02-28 20:49:16 +05:30
David Heinemeier Hansson
922b5f0795 Merge pull request #23945 from prathamesh-sonpatki/rm-merge-conflict
Fix merge conflict in Action Cable guide [ci skip]
2016-02-28 15:50:43 +01:00
Prathamesh Sonpatki
4213825a9a Fix merge conflict in Action Cable guide [ci skip] 2016-02-28 20:16:56 +05:30
David Heinemeier Hansson
2b5d784583 Further cleanup of the cable guide 2016-02-28 15:40:27 +01:00
प्रथमेश Sonpatki
4c43a10acc Merge pull request #23943 from y-yagi/remove_rake_word
remove "rake" word [ci skip]
2016-02-28 19:45:35 +05:30
प्रथमेश Sonpatki
a362c83222 Merge pull request #23944 from prathamesh-sonpatki/ac-guide-fixes
Fix typos in Action Cable guide [ci skip]
2016-02-28 19:44:21 +05:30
Prathamesh Sonpatki
2ff63580fe Fix typos in Action Cable guide [ci skip] 2016-02-28 19:42:39 +05:30
David Heinemeier Hansson
4eaaced784 Merge pull request #23176 from davidkuhta/patch-1
Guide for Action Cable
2016-02-28 15:05:36 +01:00
David Heinemeier Hansson
dabf47938f Merge pull request #23811 from iamvery/string-channel
Ensure actioncable behaves as expected with non-string queues
2016-02-28 14:58:28 +01:00
yuuji.yaginuma
21da4cba13 remove "rake" word [ci skip] 2016-02-28 21:04:42 +09:00
Arun Agrawal
2280c84ffe Merge pull request #23937 from y-yagi/use_app_update
use `app:update` instead of deprecated `rails:update` [ci skip]
2016-02-28 12:38:53 +05:30
yuuji.yaginuma
aaf13f8231 use app:update instead of deprecated rails:update [ci skip]
`rails:update` was deprecated in 6fb31638c8b61731103d4963272755b217a2df87
2016-02-28 15:52:56 +09:00
Jon Moss
65b2cfaddd Merge pull request #23933 from HayleyCAnderson/ha-action-cable-docs-fixes
[ci skip] Add small Action Cable documentation fixes
2016-02-27 15:17:11 -05:00
Hayley Anderson
b425a86591 Add small Action Cable documentation fixes
* Fix typos/grammar errors
* Make capitalization/naming consistent
2016-02-27 13:53:31 -05:00
Arthur Neves
3174b5f92a Update docs to point to new update task.
This guides were pointing to this command `rails app:update`, which I
tried to run, but it didnt worked. I think the right command is `rails
rails:update` instead. Also thats the name of the rake task.

Also I removed the `Rake` word from the title, as we run it using
`rails` bin now.

cc @kaspth
[skip ci]
2016-02-27 12:32:03 -05:00
Arthur Nogueira Neves
64e4f201a9 Merge pull request #23921 from y-yagi/remove_rack_cors_initializer_when_updating
remove rack cors initializer when updating
2016-02-27 12:29:16 -05:00
eileencodes
ecf6dc3dfb Fix test name typo prescence -> presence 2016-02-27 11:20:03 -05:00
Kasper Timm Hansen
6fb31638c8 Merge pull request #23439 from ryohashimoto/160203_rake_rails
Use app namespace for framework tasks
2016-02-27 15:14:56 +01:00
प्रथमेश Sonpatki
5cb307d859 Merge pull request #23926 from kuldeepaggarwal/fix-docs
[ci skip]Add info for specifying logger in different envrionments.
2016-02-27 14:56:58 +05:30
Kuldeep Aggarwal
3edab2a56b [ci skip]Add info for specifying logger in different envrionments.
refer 2dc3e81aea8dbc, 56ca2061df83a3
2016-02-27 14:52:36 +05:30
yuuji.yaginuma
5a9cc012a0 remove rack cors initializer when updating
Rack cors initializer is only necessary to API-only applications, for when the update is unnecessary.
2016-02-27 11:48:52 +09:00
Rafael Mendonça França
0d37f122fc ✂️ 2016-02-26 20:27:32 -03:00
Rafael Mendonça França
2142064fe1 Merge pull request #23917 from chashmeetsingh/patch-1
Create tmp folder if not present
2016-02-26 20:24:44 -03:00
Chashmeet Singh
7ce3ad1206 Create tmp folder if not present
All Apps may not have a tmp folder

Update dev.rake

Update dev.rake

Update dev.rake

Update dev.rake

Update dev.rake

Update dev.rake

Update dev.rake
2016-02-27 04:51:49 +05:30
Rafael França
84252a4f3c Merge pull request #23920 from ianks/master
Specify plaform: :mri for byebug
2016-02-26 20:08:22 -03:00
Ian Ker-Seymer
25a8ba935f
Specify plaform: :mri for byebug 2016-02-26 18:01:12 -05:00
Rafael França
bf1ac69636 Merge pull request #23915 from sikachu/pr-23710-update
Revise #23717 (Add "Rendering ..." message) using proper ActiveSupport::LogSubscriber#start
2016-02-26 16:08:12 -03:00
Jeremy Daer
e0a225a3d5 Merge pull request #23916 from lifo/same-redis-connection-for-subscription-and-broadcast
Always use redis_connector to create redis connections
2016-02-26 11:45:17 -07:00
Prem Sichanugrist
82aa20adc0 Add CHANGELOG entry for "Rendering ..." logging 2016-02-26 13:31:56 -05:00
Pratik Naik
4056a9e815 Use redis_connector to create redis connections for both subscriptions and broadcasts 2016-02-26 12:31:14 -06:00
Prem Sichanugrist
b84ca28a21 Update to use Subscriber#start instead
We don't need to instrument another event as
`ActiveSupport::LogSubscriber` already tracks when the instrumentation
starts.

Close #23717
2016-02-26 13:23:59 -05:00
Vipul A M
c8915ec335 Added log "Rendering ...", when starting to render a template, to log that we have started to render something, at the very beginning.
This helps to easily identify queries from controller vs views

Fixes #23710
2016-02-26 12:08:51 -05:00
Richard Schneeman
364e155f97 Merge pull request #23906 from schneems/schneems/puma-3-0
[close #23681] Use puma 3.0.0+
2016-02-26 08:54:05 -06:00
schneems
8374b2fc85 [close #23681] Use puma 3.0.0+
Puma 3.0 and up introduced compatibility to read from `config/puma.rb` when booting from the command `$ rails server`https://github.com/puma/puma/pull/856.
2016-02-26 08:22:24 -06:00
Ryo Hashimoto
eaec958630 The tasks in the rails task namespace is deprecated in favor of app namespace.
(e.g. `rails:update` and `rails:template` tasks is renamed to `app:update` and `app:template`.)
2016-02-26 19:35:23 +09:00
प्रथमेश Sonpatki
56ca2061df Merge pull request #23902 from prajakta-tambe/update-debuggings-rails-app-doc
Changed debugging rails app doc.
2016-02-26 15:36:49 +05:30
prajakta
2dc3e81aea - Changed Debugging Rails Applications doc's logger introduction section. Changed location for specifying logger.
[Prajakta, thiagoaugusto]
2016-02-26 15:22:39 +05:30
प्रथमेश Sonpatki
6fe37ee632 Merge pull request #23899 from y-yagi/fix_typo_in_pull_request_template
fix typo in pull_request_template [ci skip]
2016-02-26 13:25:33 +05:30
yuuji.yaginuma
71686f09df fix typo in pull_request_template [ci skip] 2016-02-26 16:40:42 +09:00
Arthur Nogueira Neves
434c8dc967 💅
[skip ci]
2016-02-25 22:32:57 -05:00
Matthew Draper
f1a76bd429 The async.callback call should live with the hijack
If we're deferring one, we should defer the other too.
2016-02-26 13:58:54 +10:30
Rafael França
feae5f4cfe Merge pull request #23738 from maclover7/issue-template
Add `issue_template.md`
2016-02-25 23:58:59 -03:00
Rafael Mendonça França
f78d0eded3 💅 2016-02-25 22:00:46 -03:00
Rafael França
0e24fcc5eb Merge pull request #23852 from prathamesh-sonpatki/hsts-subdomains
Enable HSTS with IncludeSubdomains header by default for new apps
2016-02-25 21:59:36 -03:00
Rafael França
1cc96c2e5f Merge pull request #23846 from y-yagi/correctly_check_ApplicationRecord_in_mountable_engine
correctly check `ApplicationRecord` is exist in moutable engine
2016-02-25 21:02:00 -03:00
Matthew Draper
fcec068bf9 Merge pull request #23887 from jrafanie/fix_uniqueness_validation_on_after_create
Fix uniqueness validation with an after_create hook.
2016-02-26 05:09:42 +10:30
Matthew Draper
ee5b621e2f Revert "Merge pull request #20851 from tomprats/indifferent-sessions"
This reverts commit 22db455dbe9c26fe6d723cac0758705d9943ea4b, reversing
changes made to 40be61dfda1e04c3f306022a40370862e3a2ce39.

This finishes off what I meant to do in 6216a092ccfe6422f113db906a52fe8ffdafdbe6.
2016-02-26 04:47:30 +10:30
Matthew Draper
6216a092cc Revert "Update Session to utilize indiffernt access"
This reverts commit 45a75a3fcc96b22954caf69be2df4e302b134d7a.

HWIAs are better than silently deeply-stringified hashes... but that's a
reaction to a shortcoming of one particular session store: we should not
break the basic behaviour of other, more featureful, session stores in
the process.

Fixes #23884
2016-02-26 03:06:38 +10:30
Claudio B
1f8ce32edc Merge pull request #23889 from claudiob/fix-getting-started
Doc: update guides for Rails 5
2016-02-25 08:30:53 -08:00
claudiob
569dc54a15 Doc: update AC::Parameters guides for Rails 5
[ci skip]
2016-02-25 08:22:30 -08:00