TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
1,629 Commits 2 Branches 0 Tags 294 MiB
f29ce1f356
Commit Graph

1629 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
David Heinemeier Hansson
aaa5637249 Fixed Base#write_attribute to work with both symbols and strings #1190 [Paul Legato] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 09:51:24 +00:00
Jeremy Kemper
e24e2c41c2 Mark ticket # in changelog. Snip some trailing whitespace. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1642 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 09:04:52 +00:00
David Heinemeier Hansson
df95128e94 Fixed that has_and_belongs_to_many didn't respect single table inheritance types #1081 [Florian Weber] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1641 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:52:59 +00:00
Jeremy Kemper
38e0862c81 r1645@asus: jeremy | 2005-07-03 08:51:59 -0700 
mark merge point


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1640 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:35:21 +00:00
Jeremy Kemper
7e56684c87 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1639 5ecf4fe2-1ee6-0310-87b1-e25e094e27de 2005-07-03 08:35:08 +00:00
Jeremy Kemper
82c0138f98 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1638 5ecf4fe2-1ee6-0310-87b1-e25e094e27de 2005-07-03 08:34:24 +00:00
Jeremy Kemper
83ea43cec6 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1637 5ecf4fe2-1ee6-0310-87b1-e25e094e27de 2005-07-03 08:33:07 +00:00
Jeremy Kemper
b210edce38 r1618@asus: jeremy | 2005-07-03 08:24:19 -0700 
base attribute_present? on blank?, accounting for zero


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1636 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:33:03 +00:00
Jeremy Kemper
67adc0b5b3 r1617@asus: jeremy | 2005-07-03 08:23:31 -0700 
settle on the 'slow' MysqlAdapter#select since it means fewer comparisons later.  strip trailing whitespace.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1635 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:57 +00:00
Jeremy Kemper
94cd3fd135 r1616@asus: jeremy | 2005-07-03 08:07:13 -0700 
remove duplicate conditional


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1634 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:52 +00:00
Jeremy Kemper
9a10b31fe8 r1615@asus: jeremy | 2005-07-03 08:06:00 -0700 
oops, back out DELETE typo


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1633 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:47 +00:00
Jeremy Kemper
6e39c9e561 r1614@asus: jeremy | 2005-07-03 08:01:08 -0700 
minor perf tweaks + excise trailing whitespace


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1632 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:43 +00:00
Jeremy Kemper
81737fc0dd r1613@asus: jeremy | 2005-07-03 07:04:53 -0700 
optimize method_missing for common case (read_attribute).  minor perf tweaks


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1631 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:39 +00:00
Jeremy Kemper
5bc1e39b35 r1612@asus: jeremy | 2005-07-03 04:35:59 -0700 
don't include Benchmark into AbstractAdapter directly.  call Benchmark.realtime instead of bm = Benchmark.measure, bm.real


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:34 +00:00
Jeremy Kemper
45c4b07f5a r1611@asus: jeremy | 2005-07-03 04:21:52 -0700 
No longer pass superfluous connection to AbstractAdapter#log.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1629 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:27 +00:00
Jeremy Kemper
f51f12d819 r1610@asus: jeremy | 2005-07-03 00:19:06 -0700 
remove Column#primary for now


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1628 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:22 +00:00
Jeremy Kemper
af9d03824a r1609@asus: jeremy | 2005-07-03 00:18:43 -0700 
more minor perf tweaks


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1627 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:17 +00:00
Jeremy Kemper
397c8ee2a9 r1608@asus: jeremy | 2005-07-03 00:13:57 -0700 
quoter required for column quoting


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1626 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:12 +00:00
Jeremy Kemper
b02776c232 r1607@asus: jeremy | 2005-07-02 23:36:52 -0700 
Rollback MysqlAdapter#select speedup; fix add_limit_offset


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1625 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:07 +00:00
Jeremy Kemper
018e12da31 r1605@asus: jeremy | 2005-07-02 14:50:23 -0700 
And take it out again.. passing around the quoter doesn't make sense any more because we're calling quote_column_name, not the generic quote method.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:32:02 +00:00
Jeremy Kemper
121b15bfc9 r1604@asus: jeremy | 2005-07-02 14:40:20 -0700 
Bring the column_quoter arg back to locking.rb.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1623 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:31:57 +00:00
Jeremy Kemper
96c60b0ec6 r1603@asus: jeremy | 2005-07-02 14:38:52 -0700 
Faster MysqlAdapter#select.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:31:14 +00:00
Jeremy Kemper
a250a98a52 r1602@asus: jeremy | 2005-07-02 14:34:00 -0700 
Don't pass connection to quoted_comma_pair_list


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1621 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:31:09 +00:00
Jeremy Kemper
9ebe33f14b r1601@asus: jeremy | 2005-07-02 14:33:08 -0700 
Only notify observers of after_find and after_initialize if these methods are defined on the model.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1620 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:27:18 +00:00
David Heinemeier Hansson
d9d22c7596 Fixed that single-table inheritance sub-classes couldn't be used to limit the result set with eager loading #1215 [Chris McGrath] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1619 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:21:22 +00:00
David Heinemeier Hansson
703d18ea52 Added note about render_partial_collection #1557 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1618 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:05:05 +00:00
David Heinemeier Hansson
481cac9658 AJAX error handling fix, Prototype event handling #1589 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1617 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-03 08:00:38 +00:00
David Heinemeier Hansson
da4b15fe18 More inflectoring #1490 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1616 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 19:05:47 +00:00
David Heinemeier Hansson
c196db9527 Fixed photo/photos #1583 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1615 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:59:01 +00:00
David Heinemeier Hansson
b7f37d3ef9 Fixed a bug with alternate layout #1468 [sam] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1614 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:49:17 +00:00
David Heinemeier Hansson
c6ab8f5706 Added :field_name option to DateHelper#select_(year|month|day) to deviate from the year/month/day defaults #1266 [Marcel Molina] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1613 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:38:22 +00:00
David Heinemeier Hansson
dad9c4b2ee Fixed that model generator would make fixtures plural, even if ActiveRecord::Base.pluralize_table_names was false #1185 [Marcel Molina] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1612 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:29:52 +00:00
David Heinemeier Hansson
b94e8af9a4 Update for JavaScript helper tests #1584 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:20:13 +00:00
David Heinemeier Hansson
668a0817f7 Auto completer should hide update element by when initializing #1579 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1610 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:18:55 +00:00
David Heinemeier Hansson
177ed3e681 Added more tests on assert_redirected_to #1581 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1609 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 18:16:38 +00:00
David Heinemeier Hansson
eb2b86d795 Added ActionController::Base.enable_upload_progress for people who want to play with the experimental upload progress 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1607 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 11:29:41 +00:00
David Heinemeier Hansson
50f0a73624 Added JavascriptHelper#draggable_element and JavascriptHelper#drop_receiving_element to facilitate easy dragging and dropping through the script.aculo.us libraries #1578 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1606 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 11:25:21 +00:00
David Heinemeier Hansson
c2060719d3 Added a DOCTYPE of HTML transitional to the HTML files generated by Rails #1124 [Michael Koziarski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1605 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 11:21:25 +00:00
David Heinemeier Hansson
20d27f6b74 Fixed validates_numericality_of to work with overrided getter-method when :allow_nil is on #1316 [raidel@onemail.at] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1603 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 07:52:29 +00:00
David Heinemeier Hansson
9ac02777e7 Clarified intentions of validates_associated #870 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1602 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 06:59:08 +00:00
David Heinemeier Hansson
a53372c273 Added that UrlHelper#mail_to will now also encode the default link title #749 [f.svehla@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1601 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 06:46:41 +00:00
David Heinemeier Hansson
3553b59d3c Removed the default option of wrap=virtual on FormHelper#text_area to ensure XHTML compatibility #1300 [thomas@columbus.rr.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1600 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 06:39:43 +00:00
David Heinemeier Hansson
12ff2f76da Rake task to update spin off libraries #1514 [Tobias Luetke] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1599 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 06:23:35 +00:00
David Heinemeier Hansson
bf9b90a908 Adds the ability to include XML CDATA tags using Builder #1563 [Josh Knowles] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1598 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 06:21:13 +00:00
David Heinemeier Hansson
2f61c431fa Added evaluation of <SCRIPT> blocks in content returned to Ajax calls #1577 [Thomas Fuchs/court3nay] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 06:20:05 +00:00
Jeremy Kemper
6d64bbcc56 git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1593 5ecf4fe2-1ee6-0310-87b1-e25e094e27de 2005-07-02 04:52:24 +00:00
Jeremy Kemper
5650bc9094 r1588@asus: jeremy | 2005-07-02 03:14:45 -0700 
Optional periodic garbage collection for dispatch.fcgi.  Graceful exit on TERM also (a la Apache1).  Ignore signals the platform does not support, such as USR1 on Windows.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1592 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 04:52:14 +00:00
Jeremy Kemper
b829493220 r1587@asus: jeremy | 2005-07-01 20:36:08 -0700 
Merge skaes railties.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1591 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-02 04:52:03 +00:00
Jamis Buck
5c981528f2 Better multipart support with implicit multipart/alternative and sorting of subparts [John Long] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1586 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-01 20:43:40 +00:00
David Heinemeier Hansson
ebd7bf7945 Added roots, root, and siblings to the batch of methods added by acts_as_tree #1541 [michael@schuerig.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1585 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-01 18:33:38 +00:00