Commit Graph

1629 Commits

Author SHA1 Message Date
Jeremy Kemper
f29ce1f356 r3023@asus: jeremy | 2005-07-12 23:43:39 -0700
Remove superfluous inherited override in Dependencies.
 r3024@asus:  jeremy | 2005-07-12 23:54:28 -0700
 Make test the default railties rake target.
 r3025@asus:  jeremy | 2005-07-12 23:55:27 -0700
 Encapsulate dispatch call in dispatcher test.
 r3026@asus:  jeremy | 2005-07-12 23:56:14 -0700
 Expand dispatcher mock to match full method signature for process.
 r3027@asus:  jeremy | 2005-07-12 23:57:24 -0700
 Look for app-specific generators in RAILS_ROOT/generators instead of RAILS_ROOT/script/generators.
 r3028@asus:  jeremy | 2005-07-13 00:00:47 -0700
 Update changelog.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1819 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-13 02:12:00 +00:00
David Heinemeier Hansson
cb0f8fda96 Worked around a Safari bug where it wouldn't pass headers through if the response was zero length by having render :nothing return ' ' instead of ''
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1818 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-12 19:31:48 +00:00
Jamis Buck
847f738cfd Make Request#subdomains handle "foo.foo.com" correctly
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1817 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-12 16:16:13 +00:00
David Heinemeier Hansson
fae7311b9c Fixed that auto_complete_for didn't force the input string to lower case even as the db comparison was
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1815 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 07:49:56 +00:00
David Heinemeier Hansson
4259199c2c Made ready for release of 0.13.1
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1814 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 07:36:18 +00:00
David Heinemeier Hansson
fede0f573e Fixed documentation for :action/:template confusion #1643
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1813 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 07:10:32 +00:00
David Heinemeier Hansson
216b0e0fba Improved documentation for :success/:failure callbacks #1699 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1812 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 06:44:10 +00:00
David Heinemeier Hansson
5b9b904f14 Added support for limit and offset with eager loading of has_one and belongs_to associations. Using the options with has_many and has_and_belongs_to_many associations will now raise an ActiveRecord::ConfigurationError #1692 [Rick Olsen]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1811 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 06:09:08 +00:00
David Heinemeier Hansson
1666977490 Script.aculo.us: latest rev, new autocompleter features, memory leaks fixed #1695 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1810 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 05:17:22 +00:00
Sam Stephenson
1911f8eee9 Update Railties to Prototype 1.3.1
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 03:46:22 +00:00
Sam Stephenson
325c5efdb3 Update to Prototype 1.3.1
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1804 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-11 02:57:59 +00:00
David Heinemeier Hansson
1c5d1ededb Fixed that Action View should always use the included Builder, never attempt to require the gem, to ensure compatibility
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 19:38:33 +00:00
David Heinemeier Hansson
c0f84b117c Fixed that assume_bottom_position (in acts_as_list) could be called on items already last in the list and they would move one position away from the list #1648 [tyler@kianta.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1796 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:31:29 +00:00
David Heinemeier Hansson
14e7c7c21d Better documentation for Calling multiple redirects or renders #1687 [courtenay]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1795 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:26:55 +00:00
David Heinemeier Hansson
383b6afd1c Made JavaScriptHelper tests pass regardless of hash order #1656 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1794 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:11:23 +00:00
Jeremy Kemper
c697be5b69 r2992@asus: jeremy | 2005-07-10 02:43:49 -0700
Skip ActiveRecordStore tests if neither SQLite 2 nor 3 is available.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 05:05:06 +00:00
David Heinemeier Hansson
60499774c2 Fixed that each request with the WEBrick adapter would open a new database connection #1685 [Sam Stephenson]. Added ActiveRecord::Base.threaded_connections flag to turn off 1-connection per thread (required for thread safety). By default it's on, but WEBrick in Rails need it off #1685 [Sam Stephenson]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1792 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 04:54:34 +00:00
Jeremy Kemper
e008bfd2d8 r2985@asus: jeremy | 2005-07-10 02:04:41 -0700
Updated changelog for #1688.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1791 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 04:25:39 +00:00
Jeremy Kemper
5495b14a09 r2979@asus: jeremy | 2005-07-10 01:51:00 -0700
Split association reflection test into has_many and has_one tests.  TODO: extend to belongs_to and habtm as well.  Kill trailing whitespace.
 r2980@asus:  jeremy | 2005-07-10 01:53:41 -0700
 Test that eager load of firm.account (a has_one) returns the correct account.  This doesn't cover the regression in Ticket #1688, however.  Need a case where class name is not provided and the singular name is over-singularized by active_record.class_name.  Kill trailing whitespace.
 r2981@asus:  jeremy | 2005-07-10 01:56:44 -0700
 Fix class name resolution in AssociationReflection#name_to_class_name.  Use the equivalent of the idiomatic ||= (read or write if nil) for the class_inheritable_attribute reflection arrays.  Kill trailing whitespace.
 r2982@asus:  jeremy | 2005-07-10 01:59:08 -0700
 Remove superfluous assignment in compute_type.  In an inject, the return value is used for the next injection, so assigning to the injected value is unnecessary.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1790 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-10 04:22:08 +00:00
David Heinemeier Hansson
2abe3d2cd9 Added that nil options are not included in tags, so tag("p", :ignore => nil) now returns <p /> not <p ignore="" /> but that tag("p", :ignore => "") still includes it #1465 [michael@schuerig.de]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1789 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:28:35 +00:00
David Heinemeier Hansson
0fe8e3d6c2 Added a config example in README #1626 [courtenay]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1788 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:18:01 +00:00
David Heinemeier Hansson
14762fd229 better error message for missing associations #1631 [courtenay]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1787 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:14:14 +00:00
David Heinemeier Hansson
1d7aa9fe81 Fixed that UrlHelper#link_to_unless/link_to_if used html_escape on the name if no link was to be applied. This is unnecessary and breaks its use with images #1649 [joergd@pobox.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:08:23 +00:00
David Heinemeier Hansson
34cbf15e72 Added support for SQL Server in the database rake tasks #1652 [ken.barker@gmail.com]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1785 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:05:01 +00:00
David Heinemeier Hansson
c20713834a Fixed optimistic locking with SQL Server #1660 [tom@popdog.net]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1784 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:02:32 +00:00
David Heinemeier Hansson
165f82d180 Added even more goodies to script.aculo.us #1677 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1783 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 17:01:12 +00:00
David Heinemeier Hansson
14f06c2cc1 Fixed SQL Server test #1678 [Tom Ward]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 16:59:35 +00:00
David Heinemeier Hansson
32a800761e Made target migrations actually work
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1781 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 16:28:15 +00:00
David Heinemeier Hansson
47a3bafe26 Added a VERSION parameter to the migrate task that allows you to do "rake migrate VERSION=34" to migrate to the 34th version traveling up or down depending on the current version. Added ActiveRecord::Migrator.migrate that can figure out whether to go up or down based on the target version and the current
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1780 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 15:46:29 +00:00
Jamis Buck
8266867881 Improved error message for DoubleRenderError
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1779 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 15:31:06 +00:00
Jeremy Kemper
4bed0ab99d r2960@asus: jeremy | 2005-07-09 02:12:35 -0700
Ticket 1674 - Ruby version check
 r2961@asus:  jeremy | 2005-07-09 02:50:54 -0700
 Require RAILS_VERSION >= 1.8.2 and RAILS_RELEASE_DATE >= 2004-12-25.
 r2962@asus:  jeremy | 2005-07-09 02:54:49 -0700
 minimum_release -> min_release typo
 r2963@asus:  jeremy | 2005-07-09 02:56:14 -0700
 updated changelog


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1778 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-09 05:04:19 +00:00
Jeremy Kemper
17041729c2 r2951@asus: jeremy | 2005-07-08 18:09:30 -0700
Courtenay documentation and error message patches.
 r2952@asus:  jeremy | 2005-07-08 18:43:10 -0700
 Document environment config files.
 r2955@asus:  jeremy | 2005-07-08 19:00:26 -0700
 Updated changelog


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1775 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 21:13:29 +00:00
David Heinemeier Hansson
2c8ebe4684 Added better error message for "packets out of order" #1630 [courtenay]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1774 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 19:22:37 +00:00
Jeremy Kemper
34df31455a r2948@asus: jeremy | 2005-07-08 16:00:23 -0700
Use save instead of save! in ARStore test also.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 18:13:07 +00:00
Jeremy Kemper
78ecfc77a1 r2933@asus: jeremy | 2005-07-08 14:22:58 -0700
Don't call GC.start in Mysql::Result#free.  Performance killer.  This should go upstream..


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1772 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 16:36:35 +00:00
Jeremy Kemper
37f90e0f6b r2932@asus: jeremy | 2005-07-08 14:21:36 -0700
Silence find_by_session_id also.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1771 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 16:36:26 +00:00
Nicholas Seckar
c18961f185 Routes now raise an exception if a path component is misconfigured.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:56:24 +00:00
Nicholas Seckar
4a3ec21b62 Fix routes to generate proper URLs when given Fixnum defaults
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 08:45:51 +00:00
David Heinemeier Hansson
05230c13f6 Include Javascript tests in rake #1655 [courtney]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-08 05:34:13 +00:00
Nicholas Seckar
3c4295c4e0 Allow RouteSet#recognition_failed to be used to handle unknown URL forwarding
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 21:20:59 +00:00
Nicholas Seckar
f4bfacb24f Enable routes to recognize uppercase controller names. Closes #1635
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1765 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:51:20 +00:00
Nicholas Seckar
5727dc2f42 Properly unescape recognized path components. Fixes #1651.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1764 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:43:03 +00:00
Nicholas Seckar
e3af27c51b Improved testing of functional test setup.
Fixed functional test setup so that :controller and :action
are stored into path_parameters using string keys.

Added with_routing test helper which can be used to dynamically
replace the current set of routes inside a unit test.



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 19:23:35 +00:00
David Heinemeier Hansson
b9b6cb95d3 Fixed routing to allow for testing of *path components #1650 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1762 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 16:16:36 +00:00
David Heinemeier Hansson
703ac4c5ac Added more efficient implementation of the development mode reset of classes #1638 [Chris McGrath]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1761 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 14:48:16 +00:00
David Heinemeier Hansson
b640a64760 Added :handle as an option to sortable_element to restrict the drag handle to a given class #1642 [thejohnny]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1760 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 14:34:26 +00:00
David Heinemeier Hansson
94209e2fb7 Added a bunch of script.aculo.us features: Effect.ScrollTo, to smoothly scroll the page to an element, better Firefox flickering handling on SlideUp/SlideDown, Removed a possible memory leak in IE with draggables, Added support for cancelling dragging my hitting ESC #1644 [Thomas Fuchs]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 14:18:16 +00:00
David Heinemeier Hansson
75157bbf64 Fixed that named routes didn't use the default values for action and possible other parameters #1534 [Nicholas Seckar]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1758 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 14:16:05 +00:00
Jeremy Kemper
afbf54bc3d Add test for dynamic dispatch based on action_name accessor.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 13:45:31 +00:00
David Heinemeier Hansson
bd832a221b Fixed first run of "rake migrate" on PostgreSQL by not expecting a return value on the id #1640
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2005-07-07 08:48:59 +00:00