TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
36,671 Commits 2 Branches 0 Tags 294 MiB
f9d23b3848
Commit Graph

36671 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Santiago Pastorino
f9d23b3848 Merge pull request #9978 from trevorturk/cookie-store-auto-upgrade 
Cookie-base session store auto-upgrade
 2013-04-01 08:10:34 -07:00
Santiago Pastorino
40f9ca971a Merge pull request #10026 from ogawaso/typo 
typo recomend -> recommend
 2013-04-01 05:13:03 -07:00
ogawaso
d4d3d05d64 typo recomend -> recommend 2013-04-01 19:54:46 +09:00
Xavier Noria
3f35924b3c gist for Active Record issues [Neeraj Singh & Xavier Noria] 
This commit closes issue #9775.
 2013-04-01 09:43:57 +02:00
Carlos Antonio da Silva
0a16cf19c2 Merge pull request #9680 from bdmac/time-zone-options-revert-grep-to-select 
Revert grep to select since they are not the same
 2013-03-31 15:46:48 -07:00
Santiago Pastorino
31216ec84b Merge pull request #10013 from vipulnsward/fix_request_method_test 
fix request methods test
 2013-03-31 12:36:39 -07:00
Vipul A M
d0b8f4c309 fix request methods test 2013-03-31 22:11:23 +05:30
Steve Klabnik
d535249b48 Merge pull request #10017 from vipulnsward/railties_cleanups 
cleanup railties test; fix typos
 2013-03-31 09:18:24 -07:00
Steve Klabnik
2f53c27b81 Merge pull request #10015 from vipulnsward/remove_unused_variable_in_get 
remove unused variable and assignment
 2013-03-31 08:53:01 -07:00
Steve Klabnik
fb613cb5d1 Merge pull request #10014 from vipulnsward/remove_unused_match_var 
remove unused match variables in selector
 2013-03-31 08:42:43 -07:00
Steve Klabnik
fa2e45eedd Merge pull request #10012 from vipulnsward/fix_AP_error_message_error 
fix wrong argument error message [ci skip]
 2013-03-31 08:41:28 -07:00
Vipul A M
c0be6c9811 cleanup railties test; fix typos 2013-03-31 20:50:21 +05:30
Vipul A M
f23e7eba52 remove unused variable and assignment 2013-03-31 19:34:40 +05:30
Vipul A M
01ac925b78 remove unused match variables in selector 2013-03-31 19:08:40 +05:30
Vipul A M
1f84997621 fix wrong argument error message 2013-03-31 16:49:23 +05:30
Carlos Antonio da Silva
3b0b573ac3 Make comment about uglifier in generated Gemfile consistent between branches 
Introduced in 59d20af2238f7ab553f41b96282722889d8d4393.
 2013-03-30 16:01:04 -03:00
Carlos Antonio da Silva
9e4bbce9d7 Fix indent and change "or" usage to "||" in schema dumper tests 2013-03-30 15:53:52 -03:00
Carlos Antonio da Silva
6ee17918e1 Improve AP changelog entry about layout method with nil return 
Add a note about getting the "no layout" behavior by returning "false"
to make it easier for people that might need to change their code.

Related to #8458. [ci skip]
 2013-03-30 15:48:39 -03:00
Carlos Antonio da Silva
2d1eebfd88 Refactor index algorithm lookup so that it only builds the available options once 
This way the available options are only built for actually fetching the
algorithm in case the option is given.

The options are going to be necessary a second time only in case the option
is given but does not exist, which is supposed to be due to a typo or
something like that, so no problem.
 2013-03-30 15:26:46 -03:00
Carlos Antonio da Silva
07dfc0a05f Minor doc improvement about index algorithms [ci skip] 2013-03-30 15:22:08 -03:00
Carlos Antonio da Silva
0c5552a3dd Fix typos in AP: "overriden" => "overridden" 2013-03-30 15:17:08 -03:00
Carlos Antonio da Silva
09c55dcc5d Review some tests from AMo::Errors to remove "should" usage 
Also remove duplicated tests for Errors#as_json and minor improvements
in some tests.
 2013-03-30 15:04:09 -03:00
Carlos Antonio da Silva
3d0c0c6c95 Improve changelog entry for ActiveModel::Errors#full_messages_for [ci skip] 
Add a working example of how to use this new method.
 2013-03-30 14:38:13 -03:00
Carlos Antonio da Silva
7860bf11d8 Do not calculate values if they are not going to be used 
When building the indexes list in PostgreSQL, IndexDefinition objects
are only created if the query for the related attributes really returns
something matching the attributes.

In case it does not, the variables for building the definition objects were
being created but not used.
 2013-03-30 14:11:43 -03:00
Carlos Antonio da Silva
cbfa91a216 Make docs a little bit more consistent with colons [ci skip] 2013-03-30 14:04:06 -03:00
Carlos Antonio da Silva
5ad8660135 Fix code examples indent in new index options docs [ci skip] 2013-03-30 14:04:05 -03:00
Carlos Antonio da Silva
d9ac2afc8f Use new hash style in doc examples [ci skip] 2013-03-30 14:04:05 -03:00
Rafael Mendonça França
ec55f37027 Merge pull request #9991 from Passionate/patch-1 
improve readability
 2013-03-30 10:03:24 -07:00
Carlos Antonio da Silva
e0b2271026 Minor reviews in AR changelog [ci skip] 2013-03-30 13:54:34 -03:00
Guillermo Iguaran
d98ab530cb Use last released version of thor 2013-03-30 11:47:26 -05:00
Rafael Mendonça França
6e170e1b71 Merge pull request #10004 from choudhuryanupam/master 
Refactored to remove unnecessary setup
 2013-03-30 09:46:09 -07:00
Carlos Antonio da Silva
bacae8739b Merge pull request #10003 from tkhr/refactor-scoping-test-files 
Reorganize scoping test files
 2013-03-30 09:12:35 -07:00
Carlos Antonio da Silva
6a3794b404 Merge pull request #9997 from vipulnsward/hash_destructive_merge 
Change merge to merge! to avoid creating new objects
 2013-03-30 08:55:16 -07:00
Carlos Antonio da Silva
2432469e7f Merge pull request #10007 from vipulnsward/fix_AS_typos 
Fix some typos in AS
 2013-03-30 08:47:06 -07:00
Xavier Noria
92d6dacc34 configure API generation lazily 
Do the absolute bare minimum needed to define this task, no need to compute
gem paths everytime you call rake.
 2013-03-30 11:34:35 +01:00
Xavier Noria
2645f6844f be lazy configuring the RDoc files 
This code is executed every time you run a rake task, there is no need to, specially
adding a penalty to test suites.
 2013-03-30 11:34:35 +01:00
Xavier Noria
f01b7570c5 be lazy loading SDoc 2013-03-30 11:34:35 +01:00
Vijay Dev
5190871822 fix upgrading guide [ci skip] 
I see no need to list the Gemfile contents (twice!) to convey this
message.
 2013-03-30 15:58:39 +05:30
Vijay Dev
6d8c070821 Merge branch 'master' of github.com:lifo/docrails 
Conflicts:
	activerecord/lib/active_record/connection_adapters/abstract/schema_statements.rb
	activerecord/test/cases/adapter_test.rb
	guides/source/testing.md

[ci skip]
 2013-03-30 15:46:14 +05:30
Vipul A M
5a0e583f40 fix some typos in AS 2013-03-30 14:01:42 +05:30
Anupam Choudhury
2ff2f839ca Refactored to remove unnecessary setup 2013-03-30 13:16:31 +05:30
Takehiro Adachi
7be9e88682 split relation_scoping_test.rb's default scoping tests into another file 2013-03-30 13:23:01 +09:00
Takehiro Adachi
e4da432a3a rename named_scope_test.rb to a proper file name 
The file name should be name_scoping_test.rb and the class should be
`NamedScopingTest` according to ActiveRecord::Scoping::Name
 2013-03-30 13:15:37 +09:00
Takehiro Adachi
1fde758297 move tests for NamedScope and DefaultScope under test/cases/scoping/ 
The scoping/default.rb and scoping/named.rb got moved under scoping/ in
commit 2b22564c4efaa63d4bbc006762838c4025c1bdca,
but the tests never did.
 2013-03-30 13:13:18 +09:00
Xavier Noria
022ed6c763 adds the API home page to the gemspec, needed for doc:rails 2013-03-30 01:03:02 +01:00
Xavier Noria
4ecf1f8724 typo 2013-03-30 00:38:59 +01:00
Xavier Noria
2cc934a03d registers the new doc:rails behaviour in the changelog 2013-03-30 00:10:52 +01:00
Xavier Noria
2595611dc3 rdoc is no longer a gem dependency, sdoc becomes a runtime dependency 2013-03-30 00:10:52 +01:00
Xavier Noria
84c0ac3b56 unifies API generation 2013-03-30 00:10:52 +01:00
Xavier Noria
3235537030 moves RDOC_MAIN.rdoc to railties 
The goal of these refactors is to have the same code generating
edge and doc:rails APIs, and the rails gem is not available in
LOAD_PATHS because it has no lib directory.
 2013-03-30 00:10:52 +01:00