TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
4,475 Commits 2 Branches 0 Tags 294 MiB
f9f84d9f6d
Commit Graph

4475 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Jeremy Kemper
f9f84d9f6d Routing uses URI escaping for path components and CGI escaping for query parameters. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5803 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-28 21:04:44 +00:00
Rick Olson
5cf118b138 Ensure plugins are in the Dependencies.load_once_paths collection by default. [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5801 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 22:18:38 +00:00
Michael Koziarski
810d0ade2b Make error_message_on handle nil objects. [dan] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5799 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 20:46:12 +00:00
Michael Koziarski
3b4450bb80 Docs fix for columns_hash [bradediger] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5797 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 20:41:55 +00:00
Michael Koziarski
58edaaad0b Ensure dynamic finders are anchored to the beginning of the method name to prevent 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5795 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 20:35:19 +00:00
David Heinemeier Hansson
014fdde93a Attempt at fixing the preparation_callbacks, nzkoz will double check 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5794 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 00:43:27 +00:00
David Heinemeier Hansson
d88e83f211 False is a reasonable default 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5793 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-27 00:42:31 +00:00
Michael Koziarski
c6d47806bf Allow config.to_prepare to work, make the dispatcher safe to 're require'. [Koz, Nicholas Seckar] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5792 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-26 23:56:00 +00:00
Rick Olson
29ec023add Fix scaffold_resource generator so it respects the --pretend argument when creating the routes file. Closes #6852 [fearoffish] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5790 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-26 19:39:30 +00:00
Rick Olson
ef1232c478 forgot to save CHANGELOG 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5786 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-25 09:35:20 +00:00
Rick Olson
64799454a2 Fix assert_redirected_to bug where redirecting from a nested to to a top-level controller incorrectly added the current controller's nesting. Closes #6128. [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5785 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-25 09:34:01 +00:00
Rick Olson
c6b4c8d240 Fix Webrick Daemon dispatching bug regarding a bad current working directory. Closes #4899 [Rick Olson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5784 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-25 09:01:41 +00:00
Nicholas Seckar
e2acd16810 Update load once paths to prevent nested once constants from being detected and claimed by an external non-once load. References #6720 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5782 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-24 14:53:35 +00:00
Nicholas Seckar
1e170da30d Checkin failing test case related to load once paths 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5781 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-24 14:41:29 +00:00
Jeremy Kemper
c172154054 Base#==, eql?, and hash methods. == returns true if its argument is identical to self or if it's an instance of the same class, is not new?, and has the same id. eql? is an alias for ==. hash delegates to id. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-22 21:42:52 +00:00
Jeremy Kemper
68d2926ab0 Singleton resources: POST /singleton => create, GET /singleton/new => new 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5772 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-22 03:16:50 +00:00
Jeremy Kemper
a1ca37ec86 Use 400 Bad Request status for unrescued ActiveRecord::RecordInvalid exceptions. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5771 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-22 00:27:39 +00:00
Jeremy Kemper
bc3d150386 test that element name includes module nesting 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5770 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-21 23:34:52 +00:00
Jeremy Kemper
4cf8bf7312 Pushing a record on an association collection doesn't unnecessarily load all the associated records. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-21 23:28:12 +00:00
Jeremy Kemper
8cb6cb58a2 HttpMock InvalidRequestError inspects the mismatched request 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5768 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-21 22:18:58 +00:00
Jeremy Kemper
e6988ef2ce Subclasses share superclass site until explicitly set. This way you can set Superclass.site = ... after subclasses have been defined. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5767 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-21 22:12:21 +00:00
Jeremy Kemper
93c816f0c2 move http_mock to lib so others can use it in their Ares tests 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5766 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-21 20:26:30 +00:00
Jeremy Kemper
01452feff1 DeprecatedInstanceVariable#inspect doesn't warn since test/unit, error logs, and others use it for diagnostics. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5763 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-20 21:28:31 +00:00
Jeremy Kemper
a8b53f1dbb Oracle: fix connection reset failure. Closes #6846. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5761 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-20 21:14:41 +00:00
Jeremy Kemper
7f32a85464 Fix date helper :include_blank regression. Closes #3811. [mhw] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5759 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-20 18:39:41 +00:00
Jeremy Kemper
9a27b29755 Silence log_error deprecation warnings from inspecting deprecated instance variables. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5757 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 23:16:10 +00:00
Jeremy Kemper
e56bd3a121 Only cache GET requests with a 200 OK response. Closes #6514, #6743. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 20:25:52 +00:00
Jeremy Kemper
7277c51891 Partially revert [5660] - makes more trouble than it resolves. References #5704, closes #6766. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5753 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 19:47:21 +00:00
Jeremy Kemper
8732ce291b Subclass instantiation doesn't try to explicitly require the corresponding subclass. Closes #6840. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 19:23:56 +00:00
Jeremy Kemper
55d248ba72 use RAILS_DEFAULT_LOGGER in debug mode so we can log Dependencies activity 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5750 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 18:44:04 +00:00
Jeremy Kemper
5f18fd93de utf8 mysql topics table 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 18:04:42 +00:00
Jamis Buck
33e48d5f97 Add a 'referer' attribute to TestRequest 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5748 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 17:11:26 +00:00
Rick Olson
32bc10d7df fix Rakefile so that the rdoc can be generated 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 14:59:30 +00:00
Rick Olson
e7c2c7982f Ensure render :json => ... skips the layout. Closes #6808 [Josh Peek] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5746 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 04:41:57 +00:00
Rick Olson
41466a4c83 fix faulty inheritance tests and that eager loading grabs the wrong inheritance column when the class of your association is an STI subclass. Closes #6859 [protocool] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5744 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-19 03:10:39 +00:00
Jeremy Kemper
d68f559640 Don't require test/unit since it tries to turn everything into a test run. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5740 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-18 20:59:40 +00:00
Michael Koziarski
507445862e Reapply plugin load path changes from [5720] 
Closes #6842
Closes #6851


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5738 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-18 20:27:05 +00:00
Jeremy Kemper
7d49da95a9 Another test that the deprecation spout is plugged. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5730 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-17 08:29:21 +00:00
Jeremy Kemper
8a73d4fe6f Deprecation: silence warnings when reporting test errors. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5728 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-17 08:21:45 +00:00
Jeremy Kemper
2570f408f0 Work around a cross-platform number_to_precision inconsistency in unit tests. Closes #6315. [jesperron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5727 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-17 01:00:29 +00:00
Jeremy Kemper
86deb27095 Hash#slice(*keys) returns a new hash with only the given keys. #slice! replaces the hash with only the given keys. Works with HashWithIndifferentAccess also. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5726 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-17 00:49:41 +00:00
Jeremy Kemper
05a5209f82 HashWithIndifferentAccess#to_hash converts to a Hash with String keys and the same default value. Fix Hash#reverse_update to be an alias for reverse_merge./script/console More thoroughly test the reverse_* methods. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5725 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-16 23:48:24 +00:00
Jeremy Kemper
0fc8056975 Silence warnings; use more precise assertions. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5724 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-16 23:45:44 +00:00
Michael Koziarski
23c2768421 Revert [5720] 
Reopens #6581
Reopens #6842


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5722 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-16 02:22:23 +00:00
Michael Koziarski
39686e5370 Make config.plugins affect $LOAD_PATH and remove duplication from $LOAD_PATH [James Adam] 
Closes #6581
Closes #6842



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5720 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-15 23:41:58 +00:00
Rick Olson
d833645cd8 Fix HTML::Node to output double quotes instead of single quotes. Closes #6845 [mitreandy] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5718 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-14 20:56:03 +00:00
Rick Olson
011f4e7413 Allow subclassed resources to share the site info [Rick] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5717 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-13 02:15:27 +00:00
Jeremy Kemper
2f184c338b Correctly report which filter halted the chain. References #6699. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5715 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-12 22:26:37 +00:00
Rick Olson
55d4dbb8df Fix issues with ActiveResource collection handling. Closes #6291. [bmilekic] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5714 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-12 15:29:54 +00:00
Kent Sibilev
2f5ee5a812 Ensure that DispatcherError is being thrown correctly when a malformed request is received. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5713 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2006-12-11 21:09:47 +00:00