Commit Graph

11046 Commits

Author SHA1 Message Date
Jacob Lauemoeller
fc46c9b220 Added CDATA support to the XmlMini LibXML engine, adjusted whitespace handling to closer match that of the REXML engine, and added a LibXML engine test
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-10-15 10:54:30 +13:00
Jeremy Kemper
3fa7e2fc98 Revert "Missing requires"
These rely on constant autoloads.

This reverts commit d39f397dc6726b27cc2c60a6e24e15cb1944ec58.
2009-10-14 14:48:43 -07:00
Jeremy Kemper
3e62503903 Fix tests 2009-10-14 14:47:11 -07:00
Michael Koziarski
d39f397dc6 Missing requires 2009-10-15 10:42:18 +13:00
pivotal
945d999aad Digest auth option for ActiveResource.
Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-10-15 10:37:04 +13:00
Michael Koziarski
1d01bad3ce Make sure non-escaped urls aren't considered safe 2009-10-15 09:58:35 +13:00
Michael Koziarski
5d5e34fa52 Use ERB::Util.h over CGI.escapeHTML as the former is safety aware and the latter isn't 2009-10-15 09:58:17 +13:00
Phil Darnowsky
1b3195b63c ActionView.url_for doesn't escape by default
ActionView::Helpers::UrlHelper#url_for used to escape the URLs it generated by
default.  This was most commonly seen when generating a path with multiple
query parameters, e.g.

  url_for(:controller => :foo, :action => :bar, :this => 123, :that => 456)

would return

  http://example.com/foo/bar?that=456&amp;this=123

escaping an ampersand that shouldn't be escaped.  This is both wrong and
inconsistent with the behavior of ActionController#url_for, and is changed.

Signed-off-by: Michael Koziarski <michael@koziarski.com>
2009-10-15 09:49:07 +13:00
Yehuda Katz
a41c6c35ca Start adding configuration to ActionView instead of using constants.
By using config rather than hardcoded constants, we can evolve the
  configuration system over time (we'd just need to update the config
  method with more robust capabilities and all consumers would get
  the capabilities with no code changes)
2009-10-14 13:36:41 -07:00
Jeffrey Hardy
a8dc9fd27b CookieJar#delete should return the key's value, consistent with a Hash
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-10-14 11:50:51 -07:00
Carl Lerche
ff8be66f24 Finish porting over the initializers to the app object and fix all the tests 2009-10-14 11:47:37 -07:00
Yehuda Katz + Carl Lerche
5ffb877d3a Add Gemfile to the rails application generator 2009-10-14 11:18:45 -07:00
Yehuda Katz + Carl Lerche
d56984c016 Make rails configuration's path object's root lazy 2009-10-14 11:18:45 -07:00
Joshua Peek
7ec947d59c Refactor AS concern to avoid hacking the "include" method.
Ruby Magic!
2009-10-13 23:32:32 -05:00
Joshua Peek
7b169ed1bb Extend Callbacks and Rescuable with AS concern 2009-10-13 23:30:06 -05:00
Yehuda Katz
9cd50e7752 Make logger work again (h/t Sam Ruby) 2009-10-13 10:43:28 -07:00
Joshua Peek
610e94c097 Rewrite AS::TestCase setup/teardown as a single callback chain 2009-10-12 23:23:02 -05:00
Joshua Peek
29b280666b Get AS TestCase off deprecated callbacks 2009-10-12 23:03:02 -05:00
Joshua Peek
4552dabba7 Add erubis gem to ci 2009-10-12 22:23:29 -05:00
Joshua Peek
eff61fcfa8 Insert a deprecation warn notice when using AS::DeprecatedCallbacks.
We are still using DeprecatedCallbacks in AS and AR. This is meant to annoy the
shit out of Rails core until we fix it.
2009-10-12 22:18:41 -05:00
Joshua Peek
21e7b84621 Callbacks, DeprecatedCallbacks = NewCallbacks, Callbacks 2009-10-12 22:15:43 -05:00
Joshua Peek
9bc8defe38 Use "run_callbacks :foo" since it is the public api for callbacks [#3329
state:resolved]
2009-10-12 21:58:49 -05:00
Joshua Peek
2a5c92c101 Kill unused SafelyMemoizable [#3323 state:resolved] 2009-10-12 21:44:30 -05:00
Jeremy Kemper
cbb70c896c Bundle with system gem sources rather than gems.rubyforge.org default 2009-10-11 12:35:01 -07:00
Jeremy Kemper
7b8f9d254a Fix generators load paths 2009-10-11 12:35:01 -07:00
José Valim
0cd7d4d8cf Fix rake dev.
Signed-off-by: Jeremy Kemper <jeremy@bitsweat.net>
2009-10-11 12:35:01 -07:00
Joshua Peek
8b46c50eac Kill mock routing assertion that tests router implementation 2009-10-10 21:30:51 -05:00
Joshua Peek
e61bc8e29f Fix failing safe buffer test. We don't patch CGI.escapeHTML, only ERB:Util. 2009-10-10 21:30:51 -05:00
Joshua Peek
1610cd0827 Move safe buffer into test/template 2009-10-10 21:30:51 -05:00
Joshua Peek
21be1dcffa Relative url generations are covered more thoroughly by url rewriter tests 2009-10-10 21:30:50 -05:00
Joshua Peek
673f73b538 Add define another "stuff" controller to support routing tests 2009-10-10 21:30:50 -05:00
Joshua Peek
5d071b4bc2 Drop implementation specific routing test assertions 2009-10-10 21:30:50 -05:00
Joshua Peek
7bc5e3bd02 Add define a "stuff" controller in fixtures to support routing tests 2009-10-10 21:30:50 -05:00
Yehuda Katz
b9ce8216fa Fix a bug where render :text could not handle yield :symbol. Fixes guides generation 2009-10-10 00:31:12 -10:00
Jeremy Kemper
6395c7bed2 Mark html safety 2009-10-09 18:36:58 -07:00
Jeremy Kemper
ed139730ff Uses fileutils 2009-10-09 18:31:30 -07:00
Jeremy Kemper
c23d28e2b3 To unmarshal MissingSourceFile from child 2009-10-09 18:31:30 -07:00
Pratik Naik
68d416a58f Add a :limit option to specify the maximum number of records that can be processed by accepts_nested_attributes_for 2009-10-09 16:08:11 +01:00
Pratik Naik
e94caf0788 Store entire options hash in the class var rather than just the reject_if proc for the nested attributes 2009-10-09 15:47:10 +01:00
Pratik Naik
987d501182 Mute log info coming from the local_cache strategy 2009-10-09 15:03:18 +01:00
Yehuda Katz
16a48a95e3 Fix issue with standalone ActionView 2009-10-09 00:55:00 -10:00
Yehuda Katz
2954cf1369 Avoid super in define_method for Rubinius 2009-10-09 00:54:12 -10:00
Yehuda Katz
ee37ff46e9 Get rid of constant name usage for stack trace help in favor of overriding #inspect and .name. 2009-10-09 00:53:48 -10:00
Pratik Naik
69aa5e8a86 Ensure MessageVerifier raises appropriate exception on tampered data 2009-10-09 02:26:18 +01:00
Carl Lerche
992c2db76c Finish porting over the initializers to the app object and fix all the tests 2009-10-08 18:12:28 -07:00
Carl Lerche
5c42157cd8 Even more initializers ported over 2009-10-08 15:30:17 -07:00
Carl Lerche
ed77e84c4b Ported over more initializers 2009-10-08 15:08:08 -07:00
Carl Lerche
7faa52a424 Add a test that ensures that Rails::Initializable can be used with modules 2009-10-08 12:31:09 -07:00
Carl Lerche
feb04bf897 Move the ensure_tmp_directories_exist initializer to the application object 2009-10-08 12:31:09 -07:00
Carl Lerche
e4d7e5090c Moving more initializers into the application object 2009-10-08 12:31:09 -07:00