Commit Graph

44218 Commits

Author SHA1 Message Date
Zachary Scott
fc63e8074a Use github url for homepage of log4r [ci skip] 2014-05-28 20:06:57 -07:00
Yves Senn
b8be14acdc Merge pull request #15384 from zuhao/refactor_actionpack_params_wrapper_test
Clear inflections after test.
2014-05-29 01:13:17 +02:00
Zachary Scott
c0d1823d54 Fix indentation from 1b4b26f [ci skip] 2014-05-28 15:56:38 -07:00
Zachary Scott
0a3f634e88 Merge pull request #15395 from JuanitoFatas/docs/form-helpers
[ci skip] Improve form_helpers.md guide.
2014-05-28 15:40:26 -07:00
Juanito Fatas
1b4b26f162 [ci skip] Improve form_helpers.md guide. 2014-05-29 06:31:25 +08:00
Aaron Patterson
5bbab5110b add tests for argument error cases 2014-05-28 15:14:49 -07:00
Rafael Mendonça França
d49e1c7552 Merge pull request #15393 from tonytonyjan/patch-2
Fix documentation
2014-05-28 17:15:18 -03:00
簡煒航 (Jian Weihang)
7575f4b9d6 Fix documentation
To prevent `ArgumentError`, `config.action_view.sanitized_allowed_attributes` should be assigned by an array instead of a list.

```
/Users/tonytonyjan/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/set.rb:98:in `do_with_enum': value must be enumerable (ArgumentError)
	from /Users/tonytonyjan/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/set.rb:355:in `merge'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/actionview-4.1.1/lib/action_view/helpers/sanitize_helper.rb:211:in `sanitized_allowed_attributes='
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/actionview-4.1.1/lib/action_view/railtie.rb:26:in `block (3 levels) in <class:Railtie>'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/actionview-4.1.1/lib/action_view/railtie.rb:25:in `each'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/actionview-4.1.1/lib/action_view/railtie.rb:25:in `block (2 levels) in <class:Railtie>'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.1/lib/active_support/lazy_load_hooks.rb:38:in `instance_eval'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.1/lib/active_support/lazy_load_hooks.rb:38:in `execute_hook'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.1/lib/active_support/lazy_load_hooks.rb:28:in `block in on_load'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.1/lib/active_support/lazy_load_hooks.rb:27:in `each'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/activesupport-4.1.1/lib/active_support/lazy_load_hooks.rb:27:in `on_load'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/actionview-4.1.1/lib/action_view/railtie.rb:24:in `block in <class:Railtie>'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/initializable.rb:30:in `instance_exec'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/initializable.rb:30:in `run'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/initializable.rb:55:in `block in run_initializers'
	from /Users/tonytonyjan/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:226:in `block in tsort_each'
	from /Users/tonytonyjan/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:348:in `block (2 levels) in each_strongly_connected_component'
	from /Users/tonytonyjan/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:427:in `each_strongly_connected_component_from'
	from /Users/tonytonyjan/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:347:in `block in each_strongly_connected_component'
	from /Users/tonytonyjan/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:345:in `each'
	from /Users/tonytonyjan/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:345:in `call'
	from /Users/tonytonyjan/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:345:in `each_strongly_connected_component'
	from /Users/tonytonyjan/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:224:in `tsort_each'
	from /Users/tonytonyjan/.rvm/rubies/ruby-2.1.2/lib/ruby/2.1.0/tsort.rb:205:in `tsort_each'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/initializable.rb:54:in `run_initializers'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/application.rb:288:in `initialize!'
	from /Users/tonytonyjan/Dropbox/home/codes/penta_ruby/config/environment.rb:5:in `<top (required)>'
	from /Users/tonytonyjan/Dropbox/home/codes/penta_ruby/config.ru:3:in `require'
	from /Users/tonytonyjan/Dropbox/home/codes/penta_ruby/config.ru:3:in `block in <main>'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/rack-1.5.2/lib/rack/builder.rb:55:in `instance_eval'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/rack-1.5.2/lib/rack/builder.rb:55:in `initialize'
	from /Users/tonytonyjan/Dropbox/home/codes/penta_ruby/config.ru:in `new'
	from /Users/tonytonyjan/Dropbox/home/codes/penta_ruby/config.ru:in `<main>'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/rack-1.5.2/lib/rack/builder.rb:49:in `eval'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/rack-1.5.2/lib/rack/builder.rb:49:in `new_from_string'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/rack-1.5.2/lib/rack/builder.rb:40:in `parse_file'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/rack-1.5.2/lib/rack/server.rb:277:in `build_app_and_options_from_config'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/rack-1.5.2/lib/rack/server.rb:199:in `app'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/commands/server.rb:50:in `app'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/rack-1.5.2/lib/rack/server.rb:314:in `wrapped_app'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/commands/server.rb:130:in `log_to_stdout'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/commands/server.rb:67:in `start'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/commands/commands_tasks.rb:81:in `block in server'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/commands/commands_tasks.rb:76:in `tap'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/commands/commands_tasks.rb:76:in `server'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/commands/commands_tasks.rb:40:in `run_command!'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/railties-4.1.1/lib/rails/commands.rb:17:in `<top (required)>'
	from /Users/tonytonyjan/Dropbox/home/codes/penta_ruby/bin/rails:8:in `require'
	from /Users/tonytonyjan/Dropbox/home/codes/penta_ruby/bin/rails:8:in `<top (required)>'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/spring-1.1.3/lib/spring/client/rails.rb:27:in `load'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/spring-1.1.3/lib/spring/client/rails.rb:27:in `call'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/spring-1.1.3/lib/spring/client/command.rb:7:in `call'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/spring-1.1.3/lib/spring/client.rb:26:in `run'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/spring-1.1.3/bin/spring:48:in `<top (required)>'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/spring-1.1.3/lib/spring/binstub.rb:11:in `load'
	from /Users/tonytonyjan/.rvm/gems/ruby-2.1.2/gems/spring-1.1.3/lib/spring/binstub.rb:11:in `<top (required)>'
	from /Users/tonytonyjan/Dropbox/home/codes/penta_ruby/bin/spring:16:in `require'
	from /Users/tonytonyjan/Dropbox/home/codes/penta_ruby/bin/spring:16:in `<top (required)>'
	from bin/rails:3:in `load'
	from bin/rails:3:in `<main>'
```
2014-05-29 04:03:23 +08:00
Rafael Mendonça França
37c7774504 Merge pull request #15392 from arthurnn/move_open_transactions
Keep  closer to other methods that touch @transaction
2014-05-28 16:23:56 -03:00
Arthur Neves
709ce3d6a0
Keep closer to other methods that touch @transaction 2014-05-28 15:21:19 -04:00
Rafael Mendonça França
83a437c21e Merge pull request #15390 from sgrif/sg-property-order
Maintain column order when overriding existing columns
2014-05-28 16:10:16 -03:00
Sean Griffin
622021cf18 Maintain column order when overriding existing columns
Working towards re-implementing serialized attributes to use the
properties API exposed the need for this, as serializing a column
shouldn't change the order of the columns.
2014-05-28 12:08:41 -07:00
Rafael Mendonça França
092b92f1bd Merge pull request #15389 from sgrif/sg-property-inheritance
Ensure custom properties work correctly with inheritance
2014-05-28 15:36:16 -03:00
Sean Griffin
c59e01a108 Ensure custom properties work correctly with inheritance 2014-05-28 11:34:20 -07:00
Rafael Mendonça França
fcf9b712b1 Merge pull request #15370 from sgrif/sg-type-namespace
Move types to the top level `ActiveRecord` namespace
2014-05-28 15:22:37 -03:00
Zachary Scott
4ff3fba237 Upgrading Ruby on Rails guide is no longer WIP [ci skip] 2014-05-28 10:44:35 -07:00
Zachary Scott
bfafd0dcec Formatting of content from b1db615 [ci skip] 2014-05-28 10:43:05 -07:00
Zachary Scott
f3e14587a6 Merge pull request #15380 from Gaurav2728/gaurav-transaction_isolation_error
Initial doc for TransactionIsolationError [ci skip]
2014-05-28 10:40:39 -07:00
Yves Senn
99873ca1ea Revert "Merge pull request #12778 from etehtsea/rake-default-fix"
This reverts commit ec0a2b57f67c9153cb5f7bbe2a3f66d13fe64bdd, reversing
changes made to a8bd7b16260c217290ef8fe3a166fcceac442c62.

This reverts commit 555ec36522011862c03b483c53be32410594a51e

This reverts commit 555ec36522011862c03b483c53be32410594a51e

By default, Rails uses the `default` Rake task to run all tests.
This commit changed the environment of the default task to `development`.
This clears the development database and has other negative consequences.
2014-05-28 17:43:45 +02:00
Zuhao Wan
781f8a8a33 Clear inflections after test. 2014-05-28 23:33:10 +08:00
Santiago Pastorino
abd6461e28 Merge pull request #15386 from zuhao/refactor_actionpack_request_forgery_protection_test
Avoid hardcoded `request_forgery_protection_token` value in teardown.
2014-05-28 12:03:50 -03:00
Santiago Pastorino
7fcbc3681e Merge pull request #15387 from sgrif/sg-remove-column-coder
Remove unused `Column#coder`
2014-05-28 12:01:39 -03:00
Santiago Pastorino
9ae3f5ff1c Merge pull request #15388 from zuhao/refactor_actionpack_send_file_test
Unregister Mime::Type in teardown.
2014-05-28 12:00:35 -03:00
Zuhao Wan
35cc73e79d Unregister Mime::Type in teardown. 2014-05-28 22:54:12 +08:00
Sean Griffin
748f070895 Remove unused Column#coder
It appears this property was added, but never actually used. It would be
broken if it were, as it only type casts one way.
2014-05-28 07:48:07 -07:00
Santiago Pastorino
c711c90bae Merge pull request #15385 from zuhao/refactor_actionpack_render_other_test
Add and remove renderer inside the test to prevent leak.
2014-05-28 11:39:11 -03:00
Zuhao Wan
e354b335ce Avoid hardcoded value in teardown. 2014-05-28 22:35:48 +08:00
Zuhao Wan
2ba945253b Add and remove renderer inside the test to prevent leak. 2014-05-28 22:24:22 +08:00
Yves Senn
b22b188223 Merge pull request #15383 from zuhao/refactor_actionpack_localized_templates_test
Move I18n.locale setting into setup and teardown.
2014-05-28 16:00:32 +02:00
Zuhao Wan
1407315423 Move I18n.locale setting into setup and teardown. 2014-05-28 21:50:30 +08:00
Yves Senn
0f80a52629 Merge pull request #15381 from zuhao/refactor_actionpack_content_type_test
Add with_default_charset helper.
2014-05-28 15:50:24 +02:00
Zuhao Wan
51dc7c2adb Add with_default_charset helper. 2014-05-28 21:17:16 +08:00
Gaurav Sharma
b1db6154b5 Initial doc for TransactionIsolationError [ci skip] 2014-05-28 18:33:07 +05:30
Yves Senn
bdbf00dc78 pg, keep hstore and json attributes as Hash in @attributes.
The solution presented in this patch is not efficient. We should replace it
in the near future. The following needs to be worked out:
  * Is `@attributes` storing the Ruby or SQL representation?
  * `cacheable_column?` is broken but `hstore` and `json` rely on that behavior

Refs #15369.

/cc @sgrif @rafaelfranca
2014-05-28 13:35:02 +02:00
Sean Griffin
728fa69839 Move types to the top level ActiveRecord namespace
`ActiveRecord::ConnectionAdapters::Type::Value` =>
`ActiveRecord::Type::Value`
2014-05-27 19:44:29 -07:00
Rafael Mendonça França
7f73b9152c Merge pull request #15374 from sgrif/sg-private-properties
Remove AR Properties from the public API
2014-05-27 19:38:54 -03:00
Sean Griffin
aff73e0946 Remove AR Properties from the public API
Making this part of the public API was premature, let's make it private
again while I continue to work on the surrounding code.
2014-05-27 15:34:23 -07:00
Rafael Mendonça França
c352e064bc Add CHANGELOG entry for #15269 [ci skip] 2014-05-27 19:29:10 -03:00
Rafael Mendonça França
be4b3df8bb Merge pull request #15269 from arunagw/aa-fixes-8930
rake railties:install:migrations respects the order of railties
2014-05-27 19:27:40 -03:00
Rafael Mendonça França
d0a99c8b26 Merge pull request #15373 from akshay-vishnoi/test-cases
Add test case for clear mappings
2014-05-27 19:13:58 -03:00
Rafael Mendonça França
6c5f43bab8 Deprecate all *_filter callbacks in favor of *_action callbacks
This is the continuation of the work started at
9d62e04838f01f5589fa50b0baa480d60c815e2c
2014-05-27 19:10:14 -03:00
Akshay Vishnoi
fccb752300 Add test case for clear mappings 2014-05-28 03:37:48 +05:30
Aaron Patterson
cd037783b0 rm dead code 2014-05-27 14:52:59 -07:00
Aaron Patterson
2ffa126f79 PARAMETERS_KEY is only used in the request, so move the constant there 2014-05-27 14:46:04 -07:00
Aaron Patterson
cfdab77d1f Merge branch 'constraints'
* constraints:
  rm reset_parameters because we automatically do it from 9ca4839a
  move path_parameter encoding check to the request object
  dispatcher doesn't need `call` anymore
  call `serve` with the request on dispatchers
  constraints class does not need the request class anymore
  give all endpoints a superclass
  skip the build business if the stack is empty
  stop hardcoding path_parameters and get it from the request
  we do not need to cache rack_app
  a redirect is not a dispatcher by definition, so eliminate test
  push is_a check up to where the Constraints object is allocated
  pass the request object to the application
  pass a request to `matches?` so we can avoid creating excess requests
  nothing is passed to `rack_app` anymore, so rm the params
  one fewer is_a check
  Constraints#app should never return another Constraints object, so switch to if statement
  eliminate dispatcher is_a checks
  push is_a?(Dispatcher) check in to one place
  Always construct route objects with Constraint objects

Conflicts:
	actionpack/lib/action_controller/metal.rb
2014-05-27 14:40:55 -07:00
Aaron Patterson
406b1b6464 rm reset_parameters because we automatically do it from 9ca4839a 2014-05-27 14:24:30 -07:00
Aaron Patterson
4797c4caca move path_parameter encoding check to the request object 2014-05-27 14:01:30 -07:00
Aaron Patterson
97a52283f8 dispatcher doesn't need call anymore 2014-05-27 13:54:59 -07:00
Aaron Patterson
9ad01d0ade call serve with the request on dispatchers 2014-05-27 13:51:58 -07:00
Aaron Patterson
7fe14432d8 constraints class does not need the request class anymore 2014-05-27 13:44:58 -07:00