Commit Graph

32484 Commits

Author SHA1 Message Date
Aditya Sanghi
fd6b9f3ce1 Added information about dynamic delivery options to action mailer guides 2012-09-07 02:02:33 +05:30
Aditya Sanghi
d016decb47 Dynamic Delivery Method Options 2012-09-07 01:47:27 +05:30
Semyon Perepelitsa
150c6dc30f Redirect block with arity of 1 is deprecated. 2012-09-06 23:23:05 +08:00
Aaron Renner
b883595e55 Fixed non-working around callback example 2012-09-06 08:25:58 -06:00
schneems
c9d1ba41fd Doc: sweepers only work on Active Record Models
In response to this rails issue: https://github.com/rails/rails/issues/3729
2012-09-05 15:52:24 -07:00
Andreas Loupasakis
2c96638c70 Fix a typo 2012-09-06 00:46:52 +03:00
Aldo "xoen" Giambelluca
75857d0f80 Fixed array wrongly translated in footnote in a guide [ci skip]
In the sentence "If <tt>@post.author_ids</tt> is [1], this would ..."
the array [1] is converted in a footnote, fixed this using <notextile>.
2012-09-05 18:37:19 +02:00
Ryan Bigg
baa73ac723 Add giant belongs_to 'please don't pluralize me' note
I've personally seen too many newbies get this wrong and pluralize the association
2012-09-05 15:42:43 +01:00
Konstantin Haase
1cb684c2ef update caching guide: stale? can also figure out last_modified on its own 2012-09-04 15:51:06 +02:00
Guillermo Iguaran
db354204b7 Update caching guide: memcache-client was replaced with dalli 2012-09-03 16:52:08 -05:00
Gaurish Sharma
cd59277110 Add section about tagged logging
Tagged logging for which Rails has support since [3.2](http://guides.rubyonrails.org/3_2_release_notes.html#tagged-logging).
It is trivial & useful but unless somebody explicitly searches API docs, he/she may not know about it. 

Hence, I added it in guides.
2012-09-03 19:33:59 +05:30
Anuj Dutta
198d63f984 Fix indenentation in comment to stop the end of comment from appearing in a <pre> block. 2012-09-03 14:44:14 +01:00
Aldo "xoen" Giambelluca
10520675d2 Fixed validation issue and titles in Migrations guide [ci skip]
Changed the title of the 3.5 chapter from "Using the change Method" to
"When to Use the change Method" since the chapter tells the migration
definitions supported by the change method. This fix the duplicate ID in the
document.

I've also changed some of the titles to respect the Guides guidelines.
2012-09-02 21:40:01 +02:00
Aldo "xoen" Giambelluca
7715b7b895 Fixed validation issue related to taken ID in Layout and Rendering guide [ci skip] 2012-09-02 20:55:05 +02:00
Aldo "xoen" Giambelluca
87cfb63dbc Fixed validation issues in the "Configuring Rails Applications" guide [ci skip]
erb tag wasn't closed well
2012-09-02 20:39:00 +02:00
Aldo "xoen" Giambelluca
1b5e6fc291 Fixed validation issues related to taken IDs in AR Querying guide [ci skip] 2012-09-02 19:37:34 +02:00
Aldo "xoen" Giambelluca
c38fe906c0 Underscore in _attr_readonly method name is back (Upgrading RoR guide) [ci skip] 2012-09-02 18:47:02 +02:00
Aldo "xoen" Giambelluca
70d2d2ced4 Fixed validation issue in Upgrading Ruby on Rails guide [ci skip]
In chapter 2.4 there was an underscore at the start of the attr_readonly method name,
this underscore was interpreted as the opening of the <em> tag but it wasn't closed.

Worst, the underscore in self.class.serialized_attributes (end of paragraph)
was interpreted as the closing of the <em> tag and not as the name of a method.
2012-09-02 13:59:45 +02:00
Vijay Dev
a667499103 Merge branch 'master' of github.com:lifo/docrails 2012-09-01 23:51:23 +05:30
Vijay Dev
831b814a87 copy edits [ci skip] 2012-09-01 23:49:55 +05:30
Xavier Noria
7f800b4d69 require bundle in the app generator
The app generator is not generally run under bundler, but the Bundler
constant is used here.

In particular you cannot create --dev apps without this.
2012-09-01 20:09:49 +02:00
Vijay Dev
eae2dbe557 Revert "added .DS_Store to .gitignore"
This reverts commit fc80ebb13328eb5f233f65408ba281bf0f8ce68e.

Such changes aren't allowed in docrails.
2012-09-01 23:31:29 +05:30
Piotr Sarnacki
b24352215d Remove unneeded require 2012-09-01 19:25:41 +02:00
Piotr Sarnacki
2a95a661cf Merge pull request #7494 from route/actionview_decoupling_issue
ActionView decoupling and sprockets-rails tests fail
2012-09-01 05:33:31 -07:00
Dmitry Vorotilin
3a6e8e464c Sprockets-rails tests fail
Method invalid_asset_host! was delegated to controller but sprockets
compile assets in their own scope without controller. And if we set asset_host
with second parameter it should raise error through invalid_asset_host!.
But since controller is nil it cannot be reached.
2012-09-01 16:22:40 +04:00
Sven Kraeuter | 5v3n
a1c7b0ecfc reverting changes from commit b0896c38 2012-09-01 01:37:47 +02:00
Piotr Sarnacki
5f99bdbec2 Require bundler 1.2 2012-08-31 20:59:15 +02:00
Piotr Sarnacki
62fa173bd9 Don't use Gemfile in test application in railties
Option to run `bundle install` after generating new appplication was
added recently to rails. Since introduction, it contained a subtle bug
that caused it to use `Gemfile` from current directory (if it exists)
rather than from generated directory. This also accidentaly caused
railties tests to work without any problems - after generating test app
it just used `Gemfile` from the repository, rather than the one in
generated app. After fixing the bug mentioned above, this of course
broke. The easiest way to bypass that is to not generate a `Gemfile` for
test application - with such setup Bundler will just use first available
`Gemfile` in one of the parent directories.
2012-08-31 20:52:29 +02:00
Piotr Sarnacki
7fc4b4681b Use Bundler.with_clean_env instead of custom code 2012-08-31 20:51:37 +02:00
Piotr Sarnacki
414158805f Revert "Revert changes related to bundle install fixes in rails new"
The cause of the previous revert was bug in bundler that made it hard to
make railties test work. Fix for bundler was recently pushed to github,
so now we can safely get back to the original commit.

This reverts commit 0f5cc34ab58cda99d1401ecc82e1ebb873838dd7.
2012-08-31 20:51:37 +02:00
Steve Klabnik
a91c7b4006 Fix comment about Session.
SessionHash isn't a thing, and tenses are wrong.
2012-08-31 11:20:04 -07:00
Pratik Naik
29fe1260d0 Fix my bio 2012-08-31 11:15:24 -07:00
Jon Leighton
85098e4b31 Avoid #fetch for non-nil values.
This is purely a performance optimisation.

See https://gist.github.com/3552829
2012-08-31 17:15:22 +01:00
Jon Leighton
86c3dfbd47 Key the attributes hash with symbols
This is a performance/GC optimisation.

In theory, this could be optimised by the implementation (last time I
checked, this would have no effect on JRuby). But in practise, this make
attribute access faster.
2012-08-31 16:55:08 +01:00
Jon Leighton
e96558f813 Cache the connection pool for a given class 2012-08-31 15:56:28 +01:00
Jon Leighton
ba1544d716 One hash is enough
We don't need separate @class_to_pool and @connection_pool hashes.
2012-08-31 15:56:27 +01:00
Jon Leighton
4a274ed1d2 Refactor connection handler 2012-08-31 15:56:27 +01:00
Jon Leighton
221571beb6 Make connection pool retrieval faster
* Loop rather than recurse in retrieve_connection_pool
* Key the hash by class rather than class name. This avoids creating
  unnecessary strings.
2012-08-31 15:56:27 +01:00
Jon Leighton
ae79c7a201 Revert "Merge pull request #7452 from arunagw/memcached_dalli"
This reverts commit 7256cb53e0c34e510a4d59a50d120c0358cf1d99, reversing
changes made to 6ebe22c3ae716d089af1e5090ddb0d12b31af8ac.

Reason: A test was failing.
2012-08-31 15:54:31 +01:00
Jon Leighton
cd150c96e3 Revert "Add missing require"
This reverts commit e4b33b08d6d2b88b627b1e52c4f349e57c5b89fc.

https://github.com/rails/rails/pull/7452#issuecomment-8094302
2012-08-31 15:54:31 +01:00
Sven Kräuter
b0896c3895 Merge pull request #111 from 5v3n/master
Fixed little mistake in the docs
2012-08-31 07:09:11 -07:00
Sven Kräuter
3012365399 there is no "delete" action in a controller 2012-08-31 17:08:07 +03:00
Xavier Noria
d659406e24 Merge pull request #7479 from eriko/master
the example for contraint( :ip => XXXX) has an invalid regex
2012-08-31 04:45:32 -07:00
Aldo "xoen" Giambelluca
030af5e924 In example about params naming conventions use params[:person] [ci skip]
The example is about a Person model, say that "params[:model] would usually be a
hash of all the attributes for the person to create" could be confusing.
I changed to params[:person] since the example is about a Person creation.
2012-08-31 08:53:20 +02:00
Jeff Shantz
b54e5775de Merge pull request #106 from neilstockbridge/master
Added a bullet for :enable_starttls_auto in the smtp_settings table
2012-08-30 22:10:17 -07:00
José Valim
c0b6963049 Instrumentation requires RackDelegation
Since it uses request and response methods
2012-08-30 18:40:30 -03:00
Kevin Musiorski
94301b9e0f in section 4.1 acts_as_yaffle_test was incorrectly failing due to assertion incorrectly using symbol instead of string 2012-08-30 16:35:17 -05:00
Kevin Musiorski
fc80ebb133 added .DS_Store to .gitignore 2012-08-30 16:31:20 -05:00
Kir Shatrov
e01091d196 Added example of using options_for_select() with select_tag() 2012-08-30 21:52:22 +03:00
Aldo "xoen" Giambelluca
f049d33477 Removed spaces between name and asterisks in example CHANGELOG entry [ci skip] 2012-08-30 18:19:27 +02:00