David Heinemeier Hansson
ff986f19af
Flash shouldnt depend on components either [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3581 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-12 06:11:17 +00:00
David Heinemeier Hansson
050c3964d8
Stopped the massive bleeding of concerns into ActionController::Base. Base no longer knows about flash, filters, or components. This may well have introduced some instability, please do test with apps, especially the ones using components. [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3580 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-12 05:51:02 +00:00
Sam Stephenson
838ec413eb
Add JavaScriptGenerator#replace_element for replacing an element's "outer HTML". Closes #3246 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3579 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-12 01:30:13 +00:00
David Heinemeier Hansson
e90bbbdd83
Add caution and restyle components
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3577 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-12 01:06:45 +00:00
David Heinemeier Hansson
137794310b
The components module should also contain the options that pertain to it, so collect it all with ClassMethods and InstanceMethods
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3576 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-12 00:46:01 +00:00
Nicholas Seckar
324e5eb571
Fix form_for brokenness due to a shortage of parenthesis
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3575 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-12 00:41:50 +00:00
David Heinemeier Hansson
a8a1d11d77
Expose object and object_name from the FormBuilder [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3574 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-12 00:28:45 +00:00
David Heinemeier Hansson
a04a849d15
Clean up style around form_for and friends a bit
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3573 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-12 00:22:24 +00:00
Nicholas Seckar
344ae8326a
Remove over-engineered form_for code for a leaner implementation.
...
Document form_for's :html option.
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-11 23:29:53 +00:00
Jeremy Kemper
7654082260
Major components cleanup and speedup. Closes #3527 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3563 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-09 20:05:11 +00:00
Michael Koziarski
d49a5fcb4c
* Fix pagination problems when using include
...
* Introduce Unit Tests for pagination
* Allow count to work with :include by using count distinct.
[Kevin Clark & Jeremy Hopple]
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3553 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-09 09:17:40 +00:00
Sam Stephenson
803b9a41af
Add :html option for specifying form tag options in form_for
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3552 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-08 20:46:15 +00:00
Marcel Molina
73ed47ddec
Replace dubious controller parent class in filter docs. Closes #3655 , #3722 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-08 05:24:53 +00:00
Marcel Molina
ba2619f539
Don't interpret the :value option on text_area as an html attribute. Set the text_area's value. Closes #3752 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3550 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-08 05:13:21 +00:00
Nicholas Seckar
7139e2a0e1
Fix remote_form_for creates a non-ajax form. Closes #3741 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3545 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-06 05:06:36 +00:00
David Heinemeier Hansson
0633bb865b
Update versions to match latest from stable
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3543 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-05 00:59:57 +00:00
Nicholas Seckar
5450538563
Don't let arbitrary classes match as controllers
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3542 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 23:59:37 +00:00
Nicholas Seckar
b381d8511d
Fix Routing tests. Fix routing where failing to match a controller would prevent the rest of routes from being attempted.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3539 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 23:09:26 +00:00
Tobias Lütke
28cee08fa4
fixed small bug in routing which caused the traverse_to_controller mechanism to drop out on
...
Multi::Nested::Controllers
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3538 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 22:04:19 +00:00
Nicholas Seckar
9474fe72dd
Add :builder => option to form_for and friends. Closes 3268.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3536 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 19:58:45 +00:00
David Heinemeier Hansson
5cbc062c8a
Just go with Subclasses instead of OnlySubclasses
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3534 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 16:26:55 +00:00
David Heinemeier Hansson
ed080863d5
Just go with Subclasses instead of OnlySubclasses
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3533 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 06:11:42 +00:00
Nicholas Seckar
38aae1b122
Remove unneeded logging
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3531 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 05:41:58 +00:00
Nicholas Seckar
dfa6e14af6
Fix controller resolution to avoid accidentally inheriting a controller from a parent module.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3530 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 05:20:25 +00:00
Nicholas Seckar
c77729fd23
Set sweeper's @controller to nil after a request so that the controller may be collected between requests.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3529 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-04 05:00:21 +00:00
Nicholas Seckar
ad9cabd77c
Remove LoadingModule
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3526 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-03 20:29:39 +00:00
Nicholas Seckar
1bce58b312
Add Reloadable::OnlySubclasses which handles the common case where a base class should not be reloaded, but its subclasses should be.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-02 05:41:00 +00:00
Nicholas Seckar
7a43a05a2b
Further improvements to reloading code
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3519 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-02 04:54:07 +00:00
Sam Stephenson
49401f880c
Subclasses of ActionController::Caching::Sweeper should be Reloadable
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3517 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 20:25:27 +00:00
David Heinemeier Hansson
26761d6d32
If included_modules doesnt take a parameter, we shouldnt either
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3509 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 03:58:37 +00:00
Michael Koziarski
e398045774
Fix Syntax problems which were preventing webrick from starting
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 03:54:37 +00:00
Marcel Molina
59d29811c5
Document the :xhr option for verifications. Closes #3666 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3507 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 03:22:18 +00:00
David Heinemeier Hansson
aee8db1584
ActiveRecordStore::Session shouldnt be reloadable
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3506 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 03:08:43 +00:00
David Heinemeier Hansson
15da1cf2ca
Dont mark Sweepers as reloadables
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3505 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-02-01 02:58:22 +00:00
David Heinemeier Hansson
2504982945
Added :only and :except controls to skip_before/after_filter just like for when you add filters [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3504 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-31 23:55:04 +00:00
Nicholas Seckar
d2adec438e
Ensure assigns are copied to the template when using render :update. Closes #3620 .
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3497 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-30 04:49:17 +00:00
David Heinemeier Hansson
01b1a87729
Added reusable reloading support through the inclusion of the Relodable module that all subclasses of ActiveRecord::Base, ActiveRecord::Observer, ActiveController::Base, and ActionMailer::Base automatically gets [DHH]. Added auto-loading support for classes in modules, so Conductor::Migration will look for conductor/migration.rb and Conductor::Database::Settings will look for conductor/database/settings.rb [Nicholas Seckar]. Refactored extensions to module, class, and object in active support [DHH]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3493 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-29 00:37:39 +00:00
Sam Stephenson
9c52a41241
Add the ability to call JavaScriptGenerator methods from helpers called in update blocks
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3476 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 17:09:15 +00:00
Sam Stephenson
7d0d0f0edd
Add render(:update) to ActionView::Base
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3473 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 16:36:40 +00:00
Sam Stephenson
4d49f2ca09
Fix render(:update) to not render layouts
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3472 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 16:29:37 +00:00
Sam Stephenson
5f44411d94
Backing out of [3470] until visual_effect, et al can work
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3471 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 07:27:24 +00:00
Sam Stephenson
8436147825
Add the ability to call JavaScriptGenerator methods from helpers called in update blocks
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3470 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 06:52:26 +00:00
David Heinemeier Hansson
010e999092
Fixed that SSL would not correctly be detected when running lighttpd/fcgi behind lighttpd w/mod_proxy ( closes #3548 ) [stephen_purcell@yahoo.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3467 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-23 05:32:59 +00:00
David Heinemeier Hansson
6236d518f2
Added the possibility to specify atomatic expiration for the memcachd session container ( closes #3571 ) [Stefan Kaes]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3465 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-22 22:21:26 +00:00
Marcel Molina
8d4d88a4f0
Change layout discovery to take into account the change in semantics with File.join and nil arguments.
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3462 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-22 07:41:27 +00:00
David Heinemeier Hansson
ea30f7353b
Raise a RedirectBackError if redirect_to :back is called when theres no HTTP_REFERER defined ( closes #3049 ) [kevin.clark@gmail.com]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3459 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-22 01:52:23 +00:00
David Heinemeier Hansson
5436ffa840
Treat timestamps like datetimes for scaffolding purposes ( closes #3388 ) [Maik Schmidt]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3457 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-21 23:46:56 +00:00
David Heinemeier Hansson
50e2df4268
Fix IE bug with link_to "something", :post => true ( closes #3443 ) [Justin Palmer]
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3453 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-21 23:36:38 +00:00
Sam Stephenson
a14b59b4b9
Extract Test::Unit::TestCase test process behavior into an ActionController::TestProcess module
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3443 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-20 22:18:39 +00:00
Sam Stephenson
f9937dd041
Pass along blocks from render_to_string to render
...
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@3442 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
2006-01-20 22:08:41 +00:00