TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
2,863 Commits 2 Branches 0 Tags 294 MiB
ff986f19af
Commit Graph

1001 Commits

Author SHA1 Message Date
Jeremy Kemper
85baf07be8 Controllers with acronyms in their names (e.g. PDFController) require the correct default helper (PDFHelper in file pdf_helper.rb). Closes #2262. Do not raise an exception when default helper is missing; log a debug message instead. It's nice to delete empty helpers. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2938 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-08 08:23:13 +00:00
David Heinemeier Hansson
cd2b9a9498 Made ready for 0.14.3 (RC4) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 19:40:27 +00:00
David Heinemeier Hansson
3c31062c3d Added request as instance method to views, so you can do <%= request.env["HTTP_REFERER"] %>, just like you can already access response, session, and the likes [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 13:51:56 +00:00
David Heinemeier Hansson
01cfd2b00a Fix docs (closes #2725) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 09:36:43 +00:00
David Heinemeier Hansson
8dda7c5449 Fix conflict with assert_tag and Glue gem (closes #2255) [david.felstead@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-07 09:31:49 +00:00
Jamis Buck
0073a759f1 Add documentation to assert_tag indicating that it only works with well-formed XHTML 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2894 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-06 13:59:07 +00:00
Sam Stephenson
313468a732 Added action_pack.rb stub so that ActionPack::Version loads properly 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2880 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-05 03:03:31 +00:00
Jeremy Kemper
ad4e611488 Update paginator docs. Closes #2744. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2878 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-05 02:10:29 +00:00
David Heinemeier Hansson
9d17e7cce4 Fix assert_no_tag 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2876 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-04 21:37:34 +00:00
David Heinemeier Hansson
a6106e4ec6 Added skip_before_filter/skip_after_filter for easier control of the filter chain in inheritance hierachies [DHH] Added short-hand to assert_tag so assert_tag :tag => "span" can be written as assert_tag "span" [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2873 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-04 19:42:22 +00:00
David Heinemeier Hansson
4f754985d0 Added redirect_to :back as a short-hand for redirect_to(request.env["HTTP_REFERER"]) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2848 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-02 14:47:03 +00:00
Jeremy Kemper
ddf6910941 ensure close_session in AC::Base#process 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2842 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-02 01:23:34 +00:00
Thomas Fuchs
d47f3bcbad Change javascript_include_tag :defaults to not use script.aculo.us loader, which facilitates the use of plugins for future script.aculo.us and third party javascript extensions, and provide register_javascript_include_default for plugins to specify additional JavaScript files to load. Removed scriptaculous.js, slider.js and builder.js 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2835 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-11-01 06:34:40 +00:00
Scott Barron
025949102e Fix problem where redirecting components can cause an 
infinite loop [Rick Olson]

Closes #2654


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2829 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-30 13:13:02 +00:00
Jeremy Kemper
54a4e50662 Removed erroneous arg-size check in AC::Base.fragment_cache_store=. Closes #2650. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2820 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-29 23:12:13 +00:00
Thomas Fuchs
56ae4ab547 Added support for the queue option on visual_effect 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2807 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-29 15:01:39 +00:00
Thomas Fuchs
d8f0a3f93c Update script.aculo.us to V1.5_rc4 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2802 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-29 11:48:53 +00:00
David Heinemeier Hansson
cb0e27cee9 Fix that render :text didn't interpolate instance variables (Closes #2629, #2626) [skaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2777 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-28 07:33:54 +00:00
Nicholas Seckar
f2c920ec24 Fix line number detection and escape RAILS_ROOT in backtrace Regexp 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2773 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-27 21:58:39 +00:00
Nicholas Seckar
a7aa26906c Recognize ./#{RAILS_ROOT} as RAILS_ROOT in error traces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2769 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-27 17:09:00 +00:00
Sam Stephenson
f15819e8f0 Bump to Prototype 1.4.0_rc2 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2755 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 22:07:27 +00:00
Nicholas Seckar
d6461bf9f5 Remove fingerprinting from AR session store; fix bug in store. Closes #2612 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2754 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 20:15:43 +00:00
David Heinemeier Hansson
17816a11ee Proper CSS color definition (closes #2334) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2751 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:26:51 +00:00
David Heinemeier Hansson
4e9bc0f02d Added TextHelper#strip_tags for removing HTML tags from a string (using HTMLTokenizer) (closes #2229) [marcin@junkheap.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2750 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:26:04 +00:00
David Heinemeier Hansson
82f1e19e4c Fixed docs (closes #2468) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2749 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:20:46 +00:00
David Heinemeier Hansson
07c494ae24 Added a reader for flash.now, so it's possible to do stuff like flash.now[:alert] ||= 'New if not set' (closes #2422) [Caio Chassot] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2747 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-26 13:14:10 +00:00
David Heinemeier Hansson
c7a6b9862d Prepared for release of 0.14.2 (RC3) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2737 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 22:11:48 +00:00
Nicholas Seckar
86a571090c Reset template variables after using render_to_string. Closes #2559 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2723 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 02:15:08 +00:00
Scott Barron
3a2943c54d Take a different approach to keeping flash around when using components. 
One that, you know, doesn't involve consuming every byte of free memory
on the system.

Closes #2589.

References #2291.



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2722 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-25 00:38:51 +00:00
Jeremy Kemper
22d9bad8a0 Expose the session model backing CGI::Session 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2696 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-20 21:59:48 +00:00
Jamis Buck
4da2d6c1ed Abbreviate RAILS_ROOT in traces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2688 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-19 15:56:21 +00:00
David Heinemeier Hansson
83dc37b910 Made ready to push RC2 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2684 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-19 06:24:12 +00:00
Nicholas Seckar
7d8ecad127 Update error trace templates 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2677 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-18 14:08:05 +00:00
Sam Stephenson
d82c51bb16 Upgrade to Prototype 1.4.0_rc1 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2672 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-18 02:48:33 +00:00
Jamis Buck
e515ba9ecd Fix the html-scanner to count children correctly, playing nicely with :only, fixes #2181 [patrick@lenz.sh] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2670 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-18 00:50:52 +00:00
Nicholas Seckar
139ba0aaf6 Fix spelling error 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2667 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-17 18:25:03 +00:00
Nicholas Seckar
cb8bb70aa7 Make string-keys locals assigns optional 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2665 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-17 15:51:07 +00:00
Marcel Molina
ff8fe662ef Use the more appropriate columns_hash to get the session data column size limit. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2663 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-17 03:13:04 +00:00
David Heinemeier Hansson
f4aaa26eb3 Getting ready for 0.14.0 (1.0.0 Release Candidate 1) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2660 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 22:15:03 +00:00
Nicholas Seckar
46f76ea549 Improve line number detection for template errors 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2655 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 18:37:11 +00:00
Jamis Buck
1c057b7237 Update/clean up AP documentation (rdoc) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2649 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 15:42:03 +00:00
Sam Stephenson
0453525f8d Merge remainder of util.js into effects.js 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2647 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 14:45:17 +00:00
Nicholas Seckar
876e6607c9 Add missing file 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2643 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 13:10:32 +00:00
Sam Stephenson
22b77daeee Upgrade to Prototype 1.4.0_rc0 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2638 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 03:25:40 +00:00
Tobias Lütke
0279949b05 added assert_valid to AP 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2635 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 02:20:53 +00:00
Nicholas Seckar
df9efebd94 Add line and file information to test process' get, post, etc methods 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2631 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 00:14:51 +00:00
Nicholas Seckar
e625d27633 Add temporary support for passing locals to render using string keys 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2630 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-16 00:04:33 +00:00
Jamis Buck
bfbf6bba1f Allow ARStore::Session to indicate that it should not be reloaded in dev mode 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2627 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 20:49:04 +00:00
Nicholas Seckar
3625dfaad5 Clean up error pages by providing better backtraces 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2624 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 19:05:15 +00:00
Michael Koziarski
3b8fce7b52 reasoning behind the seemingly duplicated method 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2622 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 18:39:19 +00:00
Michael Koziarski
518540a067 Add code and message to test response as per #2460 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2621 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 18:36:41 +00:00
Marcel Molina
48fd667bda Raise an exception if an attempt is made to insert more session data into the ActiveRecordStore data column than the column can hold. Closes #2234. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2612 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 14:39:29 +00:00
Tobias Lütke
6a8b9484a7 action pack asserts don't spam you with unnecissary backtraces anymore 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2611 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 13:58:22 +00:00
Thomas Fuchs
09aae0a275 Updated and clarified documentation for JavaScriptHelper to be more concise about the various options for including the JavaScript libs 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2608 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 05:08:59 +00:00
Scott Barron
f8f4eccd9a If a component redirects when called with render_component_as_string, render the 
redirected to action.

Fixes #2327


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2604 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 02:53:21 +00:00
David Heinemeier Hansson
04f4ae255f Take retry with breakpoint out until we fix it 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2597 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 01:09:34 +00:00
Nicholas Seckar
e0e8f0a302 Fix Request#host_with_port to use the standard port when Rails is behind a proxy. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2596 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-15 01:00:25 +00:00
Michael Koziarski
59709d9188 Ensure radio_button works as expected with values other than strings. 
Thanks to:
*  grant.mcinnes@utoronto.ca
*  rails@jeffcole.net



git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2573 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-14 02:07:51 +00:00
Jeremy Kemper
acb80e3d0e Escape query strings in the href attribute of URLs created by url_helper. #2333 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2572 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 22:44:45 +00:00
Nicholas Seckar
2cad95d851 Improved line number reporting for template errors 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2571 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 21:58:20 +00:00
David Heinemeier Hansson
43b6a74fb1 Added :locals support for render :inline #2463 [mdabney@cavoksolutions.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2567 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 20:26:39 +00:00
Sam Stephenson
4b72a4b12f Unset the X-Requested-With header when using the xhr wrapper in functional tests. Closes #2352. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2551 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-13 18:09:27 +00:00
Marcel Molina
d4576673c0 Unescape paths before writing cache to file system. Closes #1877. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2544 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 22:57:04 +00:00
Sam Stephenson
f49dc37e71 Wrap javascript_tag contents in a CDATA section and add a cdata_section method to TagHelper. Closes #1691. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2543 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 22:47:39 +00:00
Marcel Molina
7aa1ba7ff0 Misc doc fixes (typos/grammar/etc). Closes #2445. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2537 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 03:43:28 +00:00
Jamis Buck
8946804b8a Make xyz_tag(..., :id => "foo") work again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2535 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-12 01:05:29 +00:00
Jamis Buck
0efeeba780 Speed improvement for session_options. #2287. [skaes@web.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2527 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 01:53:31 +00:00
Marcel Molina
9025e5d47f Make cacheing binary files friendly with Windows. Closes #1975. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2524 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-11 01:06:05 +00:00
Marcel Molina
064842f516 Convert boolean form options form the tag_helper. Recloses #809. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2523 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-10 21:34:51 +00:00
Sam Stephenson
0886bb391d Fixed that an instance variable with the same name as a partial should be implicitly passed as the partial :object. Closes #2269. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2522 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-10 20:35:13 +00:00
Sam Stephenson
e3655ef733 Fix Element.toggle logic 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2521 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-10 19:09:40 +00:00
Jamis Buck
df000fca26 Move lib/version.rb to lib/action_pack/version.rb 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2514 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-10 14:33:44 +00:00
Marcel Molina
68a322005d Add versioning convention from SwitchTower to all Rails components. Add --version, -v option to the 'rails' command. Closes #1840. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2508 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 21:15:45 +00:00
Thomas Fuchs
7d101d5840 Update Prototype to V1.4.0_pre11, script.aculo.us to [2502] and fix the rails generator to include the new .js files [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2503 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 16:56:23 +00:00
Marcel Molina
a9de9c48c2 Make assert_tag :children count appropriately. Closes #2181. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2500 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-09 01:45:21 +00:00
David Heinemeier Hansson
f510b09c28 Made the documentation about render template/file sane 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2446 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-03 21:20:52 +00:00
David Heinemeier Hansson
f13534e65f Forced newer versions of RedCloth to use hard breaks [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2437 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-02 20:24:53 +00:00
David Heinemeier Hansson
810ebf7c6a Forced newer versions of RedCloth to use hard breaks [DHH] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2436 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-02 20:21:43 +00:00
David Heinemeier Hansson
c6d8a1f975 Use a nicer date format 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2433 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-01 19:00:28 +00:00
David Heinemeier Hansson
c69160a90d Better logging about partials when logger to to debug 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2432 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-01 19:00:06 +00:00
Thomas Fuchs
e7afaf62bd Added new scriptaculous options for auto_complete_field #2343 [m.stienstra@fngtps.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2431 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-10-01 05:43:53 +00:00
Jamis Buck
1e08d11579 Don't prepend the asset host if the string is already a fully-qualified URL 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2430 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 19:10:20 +00:00
David Heinemeier Hansson
562b69829d Not the avenue we want to go down 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2424 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-30 08:13:46 +00:00
David Heinemeier Hansson
438db964ad Testing should also use a default REQUEST_METHOD 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2408 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-29 08:43:17 +00:00
David Heinemeier Hansson
ba91f9feaf Dont log size of request, doesnt work well with procs, not that interesting 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2401 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 20:03:31 +00:00
Thomas Fuchs
4d6ad9c48b Updated rdoc for javascript_include_tag 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2395 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 10:55:57 +00:00
David Heinemeier Hansson
981763e53e My life for white space 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2393 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 09:06:34 +00:00
David Heinemeier Hansson
d87618d20d Log request method and response size / status code 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2391 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:43:17 +00:00
Thomas Fuchs
516dc2c0f1 Update script.aculo.us to 1.5_rc2, and Prototype to 1.4.0_pre7 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2386 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-28 08:20:47 +00:00
Nicholas Seckar
0b1abc3360 Undo condition change made in [2345] to prevent normal parameters arriving as StringIO. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2379 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 23:39:56 +00:00
Jeremy Kemper
17d2732b1c Ticket #2295 - Tolerate consecutive delimiters in query parameters 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2375 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 22:23:37 +00:00
Nicholas Seckar
564077373d Streamline render process, code cleaning. Closes #2294. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2368 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 16:45:39 +00:00
Scott Barron
a111e1a271 Keep flash after component is rendered. Closes #2291. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2363 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-27 11:02:11 +00:00
Marcel Molina
b54560600b Have text helpers use built in Regexp.escape rather than home grown alternative 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2350 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 20:49:52 +00:00
Jeremy Kemper
9852197f83 r3573@asus: jeremy | 2005-09-26 11:38:44 -0700 
Ticket 1507 - IE file uploads give the filename as a full Windows path, but Ruby on UNIX doesn't know how to File.basename('C:\\blah\blah.foo').
 r3574@asus:  jeremy | 2005-09-26 14:32:11 -0700
 Get rid of constant redefine warning.
 r3575@asus:  jeremy | 2005-09-26 14:33:07 -0700
 Override the file upload's original_filename singleton method in CGIMethods.get_typed_value.
 r3576@asus:  jeremy | 2005-09-26 14:33:49 -0700
 Unit test overridden original_filename against normal filenames and full Windows paths.
 r3577@asus:  jeremy | 2005-09-26 14:33:57 -0700
 Update change log.


git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2345 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-26 17:59:46 +00:00
Thomas Fuchs
2346f5716f Fix open/save dialog in IE not opening files send with send_file/send_data, #2279 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2325 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-25 06:53:42 +00:00
David Heinemeier Hansson
2a31691ee2 Fixed that auto_discovery_link_tag couldn't take a string as the URL 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2296 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-22 11:37:16 +00:00
David Heinemeier Hansson
d616b86025 Asserts now need html/document so it should require it 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2284 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-21 09:04:05 +00:00
David Heinemeier Hansson
8a35865b74 Added small note about how longtext might be needed for large session data 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2275 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 10:54:11 +00:00
David Heinemeier Hansson
3754822f43 Fixed problem with send_file and WEBrick using stdout #1812 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2274 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 10:53:33 +00:00
David Heinemeier Hansson
7f26415d3c Optimized tag_options to not sort keys, which is no longer necessary when assert_dom_equal and friend is available #1995 [skae]. Added assert_dom_equal and assert_dom_not_equal to compare tags generated by the helpers in an order-indifferent manner #1995 [skae] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2271 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 07:54:55 +00:00
David Heinemeier Hansson
47292cdef7 Fixed that Request#domain caused an exception if the domain header wasn't set in the original http request #1795 [Michael Koziarski] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2270 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-20 06:44:53 +00:00
Jamis Buck
390280b842 Make the truncate() helper multi-byte safe (assuming $KCODE has been set to something other than "NONE") #2103 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2265 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-19 21:36:36 +00:00
David Heinemeier Hansson
7a4c88157f Doc fix #2197 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2255 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-17 06:39:54 +00:00
David Heinemeier Hansson
620726f844 Add "#:nodoc:" for ActionController::Routing::PathComponent::Result #2209 [l.francke@gmx.de] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2254 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-17 06:37:50 +00:00
David Heinemeier Hansson
9acb1f95c9 Make upload progress not throw JavaScript errors when there is no progress bar #2208 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2252 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-16 08:44:38 +00:00
David Heinemeier Hansson
5dbf5ded5c Only attempt to require Active Support if it hasnt been already #1959 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2247 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-15 05:34:59 +00:00
David Heinemeier Hansson
e9504bb6f7 Cache relative_url_root for all webservers, not just Apache #2193 [skae] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2246 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-15 05:32:16 +00:00
David Heinemeier Hansson
b37d7a70f9 Speed up cookie use by decreasing string copying #2194 [skae] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2245 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-15 05:30:56 +00:00
David Heinemeier Hansson
7c042e09b4 Fixed access to "Host" header with requests made by crappy old HTTP/1.0 clients #2124 [Marcel Molina] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2242 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-14 18:35:31 +00:00
Jamis Buck
5e3364ef45 More auto-link fixes (to include query strings in autolinked text) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2241 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-14 12:07:05 +00:00
Jamis Buck
b97f4e4597 Fix autolinking to not include trailing tags as part of the URL 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2237 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-13 18:48:34 +00:00
David Heinemeier Hansson
ebb7bd7835 Added easy assignment of fragment cache store through use of symbols for included stores (old way still works too) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2230 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-13 08:31:32 +00:00
David Heinemeier Hansson
48018bf4b5 Moved session options to SessionManagement 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2229 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-13 07:48:12 +00:00
David Heinemeier Hansson
53ee2c9633 Added ActionController::Base.session_store=, session_store, and session_options to make it easier to tweak the session options (instead of going straight to ActionController::CgiRequest::DEFAULT_SESSION_OPTIONS) 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2228 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-13 07:46:57 +00:00
David Heinemeier Hansson
33e2ccfb26 Dont log creation of view class 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2225 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-12 18:14:16 +00:00
David Heinemeier Hansson
c259ed9e02 Use session_id instead of deprecated sessid 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2221 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-12 17:35:17 +00:00
David Heinemeier Hansson
de4cd789ae Make periodically_call_remote use type="text/javascript" on script tag #2171 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2217 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-12 05:40:27 +00:00
David Heinemeier Hansson
2fe8610673 Added TextHelper#cycle to cycle over an array of values on each hit (useful for alternating row colors etc) #2154 [dave-ml@dribin.org] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2213 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-12 05:26:25 +00:00
Nicholas Seckar
c0e84b811e Ensure that request.path never returns nil. Closes #1675 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2206 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 14:10:20 +00:00
Nicholas Seckar
27962ead03 Add ability to specify Route Regexps for controllers. Closes #1917. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2205 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 13:56:43 +00:00
Nicholas Seckar
9e5d64b3bb Provide Named Route's hash methods as helper methods. Closes #1744. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2204 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 13:45:55 +00:00
David Heinemeier Hansson
2fc5cf78be Use send instead of module_eval #1873 [shugo] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2197 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 09:14:22 +00:00
David Heinemeier Hansson
b5629c31be Fixed docs #1884 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2196 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 09:13:05 +00:00
David Heinemeier Hansson
a0ecced15b Fixed docs #1886 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2195 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 09:12:22 +00:00
David Heinemeier Hansson
2be3c00863 Split macros test into their own suite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2194 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 08:40:46 +00:00
David Heinemeier Hansson
a15068726f Added :multipart option to ActiveRecordHelper#form to make it possible to add file input fields #2034 [jstirk@oobleyboo.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2193 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 08:39:23 +00:00
David Heinemeier Hansson
c1007377ba Added in-place editing support in the spirit of auto complete with ActionController::Base.in_place_edit_for, JavascriptHelper#in_place_editor_field, and Javascript support from script.aculo.us #2038 [Jon Tirsen] Moved auto-completion and in-place editing into the Macros module and their helper counterparts into JavaScriptMacrosHelper 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2191 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 07:52:53 +00:00
David Heinemeier Hansson
dc2a3af133 Dont encourage custom url options to be called with symbol #2047 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2190 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 07:25:08 +00:00
David Heinemeier Hansson
b62243a5cc Added :disabled option to all data selects that'll make the elements inaccessible for change #2167, #253 [eigentone] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2184 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 05:58:00 +00:00
David Heinemeier Hansson
da7ba91d86 Fixed that TextHelper#auto_link_urls would include punctuation in the links #2166, #1671 [eigentone] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2183 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-11 05:53:52 +00:00
David Heinemeier Hansson
afbfde9357 Fixed that number_to_currency(1000, {:precision => 0})) should return "$1,000", instead of "$1,000." #2122 [sd@notso.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2170 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:43:02 +00:00
David Heinemeier Hansson
0439769324 Refactored away all the legacy validate_options calls and replaced them with Hash#assert_valid_keys 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2167 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:32:47 +00:00
David Heinemeier Hansson
7dbf051e54 Fix docs #2136 [coffee2code] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2165 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:11:53 +00:00
David Heinemeier Hansson
e54b4d3b54 Allow link_to_remote to use any DOM-element as the parent of the form elements to be submitted #2137 [erik@ruby-lang.nl] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2164 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 08:10:20 +00:00
David Heinemeier Hansson
c8e0e10e28 Added documentation for overwrite_params #2146 [Michael Shuerig] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2162 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 07:50:14 +00:00
David Heinemeier Hansson
e3c02d8c66 Fixed that render :partial would fail when :object was a Hash (due to backwards compatibility issues) #2148 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2160 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 07:27:44 +00:00
David Heinemeier Hansson
46110aa689 Fixed JavascriptHelper#auto_complete_for to only include unique items #2153 [Thomas Fuchs] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2159 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-09 07:25:58 +00:00
David Heinemeier Hansson
079d8f4028 Fixed that onclick would be overridden even when special features werent used 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2158 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 17:54:16 +00:00
David Heinemeier Hansson
3c3d936f4d Fixed all AssetHelper methods to work with relative paths, such that javascript_include_tag('stdlib/standard') will look in /javascripts/stdlib/standard instead of '/stdlib/standard/' #1963 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2156 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 16:39:06 +00:00
David Heinemeier Hansson
febc24dee7 An explicit include ClassInheritableAttributes is no longer needed #1948 [Caleb Tennis] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2154 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 16:28:10 +00:00
Nicholas Seckar
bf92aacf40 Avoid extending view instance with helper modules each request. Closes #1979 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2152 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 12:08:24 +00:00
Nicholas Seckar
689cca132a Performance improvements to CGI methods. Closes #1980 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2151 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-08 11:28:54 +00:00
David Heinemeier Hansson
7b235f0213 Use this.href, not unexisting url 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2150 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-07 13:04:09 +00:00
David Heinemeier Hansson
7e3dc807df Added :post option to UrlHelper#link_to that makes it possible to do POST requests through normal ahref links using Javascript 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2149 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-07 12:56:33 +00:00
Nicholas Seckar
2f66e873b0 Symbolize the keys of overwritten parameters. Really closes #1909. 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2147 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-07 08:59:33 +00:00
Nicholas Seckar
3108764367 Fix overwrite params. Closes #1909 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2144 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 22:06:11 +00:00
David Heinemeier Hansson
f86276b305 Fix fragment benchmark calls and limit timings to 5 decimals 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2142 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 17:33:11 +00:00
David Heinemeier Hansson
291c667d66 Only do benchmarking if log level matches and log caching 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2141 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 17:07:08 +00:00
David Heinemeier Hansson
5e8e8d6564 Added use_silence parameter to ActiveRecord::Base.benchmark that can be passed false to include all logging statements during the benchmark block. Added ActionController::Base.benchmark and ActionController::Base.silence to allow for easy benchmarking and turning off the log 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2140 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-06 16:48:18 +00:00
Jamis Buck
bfdb437508 Updated vendor copy of html-scanner to support better xml parsing 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2131 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-05 09:44:22 +00:00
David Heinemeier Hansson
258bacbf82 Added :popup option to UrlHelper#link_to #1996 [gabriel.gironda@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2129 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-04 00:33:45 +00:00
David Heinemeier Hansson
3f14b1e94e Updated the options_for_select to deal with the fact that Strings now implement :first 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2126 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-03 21:30:54 +00:00
David Heinemeier Hansson
51a1af96d4 Added note about how pre-packaged error functionality can be easier to recreate yourself than attempt to overly tailor #1489 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2112 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-03 07:43:15 +00:00
Jamis Buck
89550ee7e9 Use chop! instead of chop! for efficiency 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2109 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 18:01:26 +00:00
Jamis Buck
62ec1a5373 Drop trailing \000 if present on RAW_POST_DATA (works around bug in Safari Ajax implementation) #918 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2106 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 14:40:33 +00:00
Jamis Buck
fd9c15e420 Fix observe_field to fall back to event-based observation if frequency <= 0 #1916 [michael@schubert.cx] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2104 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 14:06:17 +00:00
Jamis Buck
97adfdaa65 * Allow use of the :with option for submit_to_remote #1936 [jon@instance-design.co.uk] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2103 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 13:56:38 +00:00
Jamis Buck
6c44d35268 AbstractRequest#domain returns nil when host is an ip address #2012 [kevin.clark@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2098 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-02 09:10:31 +00:00
Jamis Buck
46c4fd4177 ActionController documentation update #2051 [fbeausoleil@ftml.net] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2095 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-01 21:54:29 +00:00
Jamis Buck
e758c2e9db Yield @content_for_ variables to templates #2058 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2094 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-01 21:51:27 +00:00
Jamis Buck
01af965a3e Make rendering an empty partial collection behave like :nothing => true #2080 [Sam Stephenson] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2093 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-09-01 21:43:38 +00:00
Nicholas Seckar
87b6800282 Add option to specify the singular name used by pagination. Closes #1960 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2078 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-31 00:13:10 +00:00
Nicholas Seckar
34e795ff0e Use string key to set action_name for controllers. Closes #1968 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2077 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-30 23:52:53 +00:00
Nicholas Seckar
a8b9fc9f2a Add dummy ActionView::Base.cache_template_loading accessor -- will be made functional again in short time 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2066 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-29 15:12:48 +00:00
David Heinemeier Hansson
b80f0e2ff3 Made Upload Progress work with Prototype 1.4.0 and add some documentation for it #1847, #1876 [Thomas Fuchs/Sean Treadway] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2059 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-27 06:30:33 +00:00
Nicholas Seckar
68c90ab019 Render refactoring; render error reporting fixes 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2058 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-26 22:37:36 +00:00
Nicholas Seckar
1cbd1f9698 Fix routing to handle :some_param => nil better 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2054 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-26 10:57:43 +00:00
Jamis Buck
c5ff810572 Add support for :include with pagination (subject to existing constraints for :include with :limit and :offset) #1478 [michael@schubert.cx] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2041 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-23 14:24:15 +00:00
Jamis Buck
211617191e Prevent the benchmark module from blowing up if a non-HTTP/1.1 request is processed 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2039 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-23 09:43:36 +00:00
Jamis Buck
82f44f3144 Added :use_short_month option to select_month helper to show month names as abbreviations 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2033 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-22 14:47:16 +00:00
Jamis Buck
c031a01633 Add an :if option to session management, to allow programmatically enabling or disabling the session 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2031 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-17 21:05:31 +00:00
Jamis Buck
8910de6a54 Make link_to escape the javascript in the confirm option #1964 [nicolas.pouillard@gmail.com] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@2009 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-14 08:43:07 +00:00
Jamis Buck
50e2474433 Make assert_redirected_to properly check URL's passed as strings #1910 [Scott Barron] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1971 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-06 08:37:25 +00:00
Jamis Buck
a3469cadad Make sure :layout => false is always used when rendering inside a layout 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1970 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-05 20:51:03 +00:00
Jamis Buck
44c64a612d Use raise instead of assert_not_nil in Test::Unit::TestCase#process to ensure that the test variables (controller, request, response) have been set 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1963 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-08-01 21:28:17 +00:00
Jamis Buck
08ebab5d20 Make sure assigns are built for every request when testing #1866 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1961 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-31 12:16:21 +00:00
Jamis Buck
020ed6fa1f Allow remote_addr to be queried on TestRequest #1668 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1960 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-31 10:31:47 +00:00
David Heinemeier Hansson
0ea1375d75 Really fix the syntax error issue 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1952 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-28 17:41:19 +00:00
David Heinemeier Hansson
9fad3251d3 More fixes, but still broken 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1948 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 14:17:47 +00:00
David Heinemeier Hansson
c22ebd909d Fixing the fix, but not quite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1946 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 13:55:56 +00:00
David Heinemeier Hansson
5b52b716b7 Fixing the fix, but not quite 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1945 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 13:55:39 +00:00
David Heinemeier Hansson
3d2f0001ea Fixed bug when a partial render was passing a local with the same name as the partial 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1942 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 12:24:14 +00:00
David Heinemeier Hansson
eec7cc004b Fixed dynamic scaffolding [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1940 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 11:44:18 +00:00
David Heinemeier Hansson
d876daf51f Fixed #1774 again 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1936 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-27 08:02:26 +00:00
David Heinemeier Hansson
4b8d156ca5 Removed unused statement 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1934 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 18:39:05 +00:00
David Heinemeier Hansson
d440cf6483 Fixed snag in status reporting 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1933 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 18:35:38 +00:00
David Heinemeier Hansson
65e4e5e337 Only log status if there is one different from 200 set 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1930 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 12:38:50 +00:00
David Heinemeier Hansson
11a51648ad Document the design of the compiled templates approach and tweak the expiration check 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1929 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-26 12:37:21 +00:00
David Heinemeier Hansson
36fee9c02e Fixed broken error handling #1827 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1920 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-25 09:39:57 +00:00
David Heinemeier Hansson
e9cfe955cc Add a catch-all eraser 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1918 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-25 08:49:19 +00:00
David Heinemeier Hansson
4f40b2d8fb Improved performance of test app req/sec with ~10% refactoring the render method #1823 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1915 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 16:45:39 +00:00
David Heinemeier Hansson
3ccea931fa Simplify content_for implementation 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1914 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 15:27:47 +00:00
David Heinemeier Hansson
1ae0a53d86 Fixed regression for content_for #1820 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1911 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-24 13:20:29 +00:00
David Heinemeier Hansson
eddd7c453b Fix that env_qs might be nil 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1907 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:18:16 +00:00
David Heinemeier Hansson
d554227411 Fix that env_qs might be nil 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1906 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:16:35 +00:00
David Heinemeier Hansson
b366dbd952 Improved performance with 5-30% through a series of Action Pack optimizations #1811 [Stefan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1905 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 09:00:05 +00:00
David Heinemeier Hansson
d172592985 Added test for template to layout variable transfer 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1904 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 08:43:01 +00:00
David Heinemeier Hansson
023c4d68cc Caching template logging goes DEBUG 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1903 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 06:27:52 +00:00
David Heinemeier Hansson
7fe3fd23b3 Extended template caching to rxml and attempted to fix periodical caching issue [Stephan Kaes] 
git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@1902 5ecf4fe2-1ee6-0310-87b1-e25e094e27de
 2005-07-23 06:14:10 +00:00