rails/CHANGELOG.md at 70ff31d69f017d1bc674b913865d5a008de0c8a6

Tony Wooster a351149e80 Fix controller test not resetting @_url_options

Commit 4f2cd3e9 introduced a bug by reordering the call to
`@controller.recycle!` above the call to `build_request_uri`. The
impact of this was that the `@_url_options` cache ends up not being
reset between building a request URI (occurring within the test
controller) and the firing of the actual request.

We encountered this bug because we had the following setup:

  class MinimumReproducibleController < ActionController::Base
    before_filter { @param = 'param' }

    def index
      render text: url_for(params)
    end

    def default_url_options
      { custom_opt: @param }
    end
  end

  def test_index
    get :index # builds url, then fires actual request
  end

The first step in  `get :index` in the test suite would populate the
@_url_options cache. The subsequent call to `url_for` inside of the
controller action would then utilize the uncleared cache, thus never
calling the now-updated default_url_options.

This commit fixes this bug calling recycle! twice, and removes a call
to set response_body, which should no longer be needed since we're
recycling the request object explicitly.

2014-02-26 10:39:44 -08:00

242 B

Raw Blame History

Fix URL generation in controller tests with request-dependent default_url_options methods.

Tony Wooster

Please check 4-1-stable for previous changes.

242 B Raw Blame History

242 B

Raw Blame History