TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
bbfab0b33a
rails/railties/test
History
Edouard CHIN bbfab0b33a Don't run AJ after_enqueue / after_perform when chain is halted: 
- ### Problem

  ```ruby
    MyJob < ApplicationJob
      before_enqueue { throw(:abort) }
      after_enqueue { # enters here }
    end
  ```
  I find AJ behaviour on after_enqueue and after_perform callbacks
  weird as they get run even when the callback chain is halted.
  It's counter intuitive to run the after_enqueue callbacks even
  though the job wasn't event enqueued.

  ### Solution

  In Rails 6.2, I propose to make the new behaviour the default
  and stop running after callbacks when the chain is halted.
  For application that wants this behaviour now or in 6.1
  they can do so by adding the `config.active_job.skip_after_callbacks_if_terminated = true`
  in their configuration file.
2019-12-09 17:17:23 +01:00
..
application Don't run AJ after_enqueue / after_perform when chain is halted: 2019-12-09 17:17:23 +01:00
command Fix deeply nested namespace command printing 2019-01-24 12:28:43 -05:00
commands Use DiskController for both public and private files 2019-12-06 16:02:16 -05:00
configuration Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
engine Make Webpacker the default JavaScript compiler for Rails 6 (#33079) 2018-09-30 22:31:21 -07:00
fixtures/lib Remove unused fixtures 2017-09-26 07:45:42 +09:00
generators Merge pull request #37778 from jonathanhefner/prevent-tests-with-non-existent-routes 2019-11-25 08:56:29 -07:00
isolation Run yarn install in template dir 2019-11-14 16:47:08 -08:00
minitest rubocop single space after assignment 2018-02-19 11:23:47 +05:30
railties Auto-correct rubocop offences 2019-11-24 09:54:47 +09:00
test_unit Show rails instead of bin/rails on USAGE instructions 2018-07-06 22:46:54 +02:00
abstract_unit.rb Revert "You give jruby_skip & rubinius_skip a good name" 2019-08-02 00:24:11 -04:00
app_loader_test.rb Turn on performance based cops 2018-07-23 15:37:06 -07:00
backtrace_cleaner_test.rb Don't modify relative ./ paths in BacktraceCleaner 2019-10-03 14:06:58 -07:00
code_statistics_calculator_test.rb use "minitest" consistently 2018-09-11 23:57:25 +02:00
code_statistics_test.rb Adding frozen_string_literal pragma to Railties. 2017-08-14 19:08:09 +02:00
console_helpers.rb Enable Performance/UnfreezeString cop 2018-09-23 08:56:55 +09:00
engine_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
env_helpers.rb Enable Layout/EmptyLinesAroundAccessModifier cop 2019-06-13 12:00:45 +09:00
generators_test.rb Do not show suggestion message when not exist suggestion 2018-12-29 18:57:55 +09:00
initializable_test.rb Adding frozen_string_literal pragma to Railties. 2017-08-14 19:08:09 +02:00
json_params_parsing_test.rb Adding frozen_string_literal pragma to Railties. 2017-08-14 19:08:09 +02:00
path_generation_test.rb Remove deprecated config.secret_token 2019-01-17 16:08:34 -05:00
paths_test.rb Use assert_predicate and assert_not_predicate 2018-01-25 23:32:59 -05:00
rack_logger_test.rb Change the empty block style to have space inside of the block 2018-09-25 13:19:35 -04:00
rails_info_controller_test.rb Fix secret_key_base for Railties 2019-03-13 16:41:29 -04:00
rails_info_test.rb Revert "Merge pull request #34387 from yhirano55/rails_info_properties_json" 2019-01-08 22:21:20 +01:00
secrets_test.rb Enable Style/RedundantBegin cop to avoid newly adding redundant begin block 2018-12-21 06:12:42 +09:00
version_test.rb Adding frozen_string_literal pragma to Railties. 2017-08-14 19:08:09 +02:00