TEST_CODEOWNERS/rails
3
0
Fork 0
Code Issues Pull Requests 1 Actions Packages Projects Releases Wiki Activity
bbfab0b33a
rails/railties/test/application
History
Edouard CHIN bbfab0b33a Don't run AJ after_enqueue / after_perform when chain is halted: 
- ### Problem

  ```ruby
    MyJob < ApplicationJob
      before_enqueue { throw(:abort) }
      after_enqueue { # enters here }
    end
  ```
  I find AJ behaviour on after_enqueue and after_perform callbacks
  weird as they get run even when the callback chain is halted.
  It's counter intuitive to run the after_enqueue callbacks even
  though the job wasn't event enqueued.

  ### Solution

  In Rails 6.2, I propose to make the new behaviour the default
  and stop running after callbacks when the chain is halted.
  For application that wants this behaviour now or in 6.1
  they can do so by adding the `config.active_job.skip_after_callbacks_if_terminated = true`
  in their configuration file.
2019-12-09 17:17:23 +01:00
..
configuration Use respond_to test helpers 2018-01-25 23:32:58 -05:00
initializers Don't drop_table before schema cache tests 2019-06-13 13:43:26 +09:00
middleware Fix keyword arguments warnings 2019-09-09 22:49:09 +09:00
rack Log the remote IP addr of clients behind a proxy 2018-07-31 20:45:37 +05:30
rake Use DiskController for both public and private files 2019-12-06 16:02:16 -05:00
asset_debugging_test.rb Sprockets uses debug. not self. now 2019-10-10 14:43:03 -07:00
assets_test.rb Auto-correct rubocop offences 2019-11-24 09:54:47 +09:00
bin_setup_test.rb Avoid flunking tests on warning in output 2019-09-28 12:52:31 +02:00
configuration_test.rb Don't run AJ after_enqueue / after_perform when chain is halted: 2019-12-09 17:17:23 +01:00
console_test.rb Add config.disable_sandbox option to Rails console 2019-03-23 19:31:03 +09:00
content_security_policy_test.rb Add the ability to set the CSP nonce only to the specified directives 2019-06-22 12:44:37 +09:00
credentials_test.rb Restructure credentials after environment overrides. 2019-01-14 20:13:00 +01:00
current_attributes_integration_test.rb Use try only when we're unsure if the receiver would respond_to the method 2019-08-01 17:58:00 +09:00
dbconsole_test.rb Use correct variable 2018-09-11 07:06:30 +09:00
feature_policy_test.rb Adds support for configuring HTTP Feature Policy (#33439) 2019-07-10 15:33:15 -07:00
generators_test.rb Add skip-collision-check option to generator 2019-07-05 18:55:47 +09:00
help_test.rb Run in-app rails commands via fork+load where possible 2017-09-04 20:19:39 +09:30
integration_test_case_test.rb rails new runs rails active_storage:install 2017-11-06 21:29:14 +00:00
loading_test.rb Revert "Use app.config.file_watcher for watcher in RoutesReloader" 2019-12-06 14:58:07 +08:00
mailer_previews_test.rb Add title tag to mailer previews 2019-09-02 14:44:46 -07:00
middleware_test.rb Adds support for configuring HTTP Feature Policy (#33439) 2019-07-10 15:33:15 -07:00
multiple_applications_test.rb Zeitwerk integration 2019-02-12 02:28:04 -08:00
paths_test.rb Bring back feature that allows loading external route iles: 2019-12-06 14:20:12 +01:00
per_request_digest_cache_test.rb Include ActiveSupport::Testing::MethodCallAssertions in railties/test/isolation/abstract_unit.rb 2018-06-09 00:00:28 +03:00
rackup_test.rb Remove unnecessary migration deletion 2017-11-08 13:24:16 +09:00
rake_test.rb Removed webpacker:compile step from scaffold test as it is not required and assets are already precompiled in build_app step 2019-07-26 20:20:07 +05:30
rendering_test.rb Fix RenderingTest in railtie 2018-04-04 06:12:24 +09:00
routing_test.rb Bring back feature that allows loading external route iles: 2019-12-06 14:20:12 +01:00
runner_test.rb Avoid flunking tests on warning in output 2019-09-28 12:52:31 +02:00
server_test.rb Update test to avoid Puma output format change 2019-09-25 13:11:58 -04:00
system_test_case_test.rb Define the url_options needed for SytemTest inside the route proxy: 2019-07-24 01:18:00 +02:00
test_runner_test.rb Use symbols everywhere for database configurations 2019-09-13 08:53:22 -04:00
test_test.rb Sync test DB from schema using its SHA1 2019-08-06 12:44:22 -07:00
url_generation_test.rb Fix secret_key_base for Railties 2019-03-13 16:41:29 -04:00
version_test.rb Run in-app rails commands via fork+load where possible 2017-09-04 20:19:39 +09:30
watcher_test.rb Correctly classify the files and directories that pass to watcher 2019-09-02 11:22:39 +09:00
zeitwerk_integration_test.rb defines Rails.autoloaders.log! 2019-08-13 18:14:50 +02:00