bartvdbraak/blender
1
0
Fork 4
Code Issues 4 Pull Requests 1 Actions 1 Packages Projects Releases Wiki Activity

Fix T47705: Freestyle line glitch.

Browse Source 
The addressed issue is a regression from Blender 2.75, after the internal
switch from double to single precision floating-point numbers in the
Freestyle code base.  Face normal calculations require the higher
precision during the computations, even though the results can be stored
as single precision numbers.
This commit is contained in:
Tamito Kajiyama 2016-04-05 16:08:45 +09:00
parent 9c952bbe85
commit db28ff54d6
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
source/blender/freestyle/intern/winged_edge/WEdge.cpp
View File

@ -640,18 +640,19 @@ WFace *WShape::MakeFace(vector<WVertex *>& iVertexList, vector<bool>& iFaceEdgeM
vector<WVertex *>::iterator it;
// compute the face normal (v1v2 ^ v1v3)
WVertex *v1, *v2, *v3;
// Double precision numbers are used here to avoid truncation errors [T47705]
Vec3r v1, v2, v3;
it = iVertexList.begin();
v1 = *it;
v1 = (*it)->GetVertex();
it++;
v2 = *it;
v2 = (*it)->GetVertex();
it++;
v3 = *it;
v3 = (*it)->GetVertex();
Vec3f vector1(v2->GetVertex() - v1->GetVertex());
Vec3f vector2(v3->GetVertex() - v1->GetVertex());
Vec3r vector1(v2 - v1);
Vec3r vector2(v3 - v1);
Vec3f normal(vector1 ^ vector2);
Vec3r normal(vector1 ^ vector2);
normal.normalize();
face->setNormal(normal);