Sergey Sharybin
83ce02879f
Cycles: Fix possible race condition when generating Beckmann table
...
Two issues here:
- Checking table size to be non-zero is not a proper way to go here. This is
because we first resize the table and then fill it in. So it was possible that
non-initialized table was used.
Trickery with using temporary memory and then doing table.swap() might work,
but we can not guarantee that table size will be set after the data pointer.
- Mutex guard was useless, because every thread was using own mutex. Need to
make mutex guard static so all threads are using same mutex.
2017-10-06 21:06:15 +05:00
Sergey Sharybin
837383ac78
Cycles: Cleanup, indendation
2017-10-06 19:33:59 +05:00
Sergey Sharybin
a950af8e24
Fix T53012: Shadow catcher creates artifacts on contact area
...
The issue was caused by light sample being evaluated to nan at some point.
This is root of the cause which is to be fixed, but is very hard to trace down
especially via ssh (the issue only happens on AVX2 release build). Will give it
a closer look when back to my AVX2 machine.
For until then this is a good check to have anyway, it corresponds to what's
happening in regular radiance sum.
2017-10-06 17:27:34 +05:00
Sergey Sharybin
0d3c8d0701
Cycles: Cleanup, indentation and wrapping
2017-10-06 16:54:37 +05:00
Campbell Barton
3df139c530
Cleanup: Math lib naming (use v3 suffix)
2017-10-06 21:06:38 +11:00
Sergey Sharybin
70aa33f069
Sequencer: Cleanup, use more BLI utilities where possible
2017-10-06 15:00:22 +05:00
Sergey Sharybin
00eac066f3
Sequencer: Use BLI math functions where possible
2017-10-06 14:36:41 +05:00
Sergey Sharybin
d56f835bff
Sequencer: Avoid re-calculation index offset multiple times
2017-10-06 14:36:41 +05:00
Sergey Sharybin
5bbe818aeb
Sequencer: Use funciton instead of macr oto avoid argument re-evaluation
2017-10-06 14:36:41 +05:00
Sergey Sharybin
c756787694
Fix T52940: VSE Glow Effect Strip on transparent images has no blur
2017-10-06 14:36:41 +05:00
Campbell Barton
55b7adb9e5
Error in falloff_angle range in last commit
2017-10-06 20:20:15 +11:00
Campbell Barton
471be7e7f5
Vertex Paint: move normal falloff into the brush
...
All related settings are already in the brush,
so it's inconvenient to switch panels to change this one option.
2017-10-06 20:15:28 +11:00
Campbell Barton
6c43490616
Vertex Paint: use view normal w/ 2D falloff
...
When projecting to the view, cull faces pointing
away from the view normal.
2017-10-06 19:10:33 +11:00
Campbell Barton
8ef757df3d
Vertex Paint: use brush front-face setting
...
Follow sculpt mode more closely by using the brush front-face option.
2017-10-06 18:57:37 +11:00
Campbell Barton
082987ec74
Sculpt: use tube falloff when calculating normals
...
Also apply 2D clamping for other tools when the option is set.
2017-10-06 18:34:05 +11:00
Campbell Barton
3282218983
Sculpt: clamp normal to plane w/ projected falloff
...
Allows for editing outlines w/o pushing geometry towards/away from
the view.
2017-10-06 17:38:56 +11:00
Campbell Barton
327bb6e543
Fix ruler access from search pop-up
...
D2831 by @1xundoredo
2017-10-06 17:13:44 +11:00
Campbell Barton
c454d816a9
Cleanup: style
2017-10-06 16:56:41 +11:00
c82efd3276
Fix T52514: don't clear filename when dropping directory path in file browser.
2017-10-06 00:18:57 +02:00
64f8cc3e7d
Fix T52998: disabled menu entries responding to key shortcuts.
2017-10-05 19:12:05 +02:00
Bastien Montagne
63482a5f2e
Fix T53002: Batch-Generate Previews generate empty or none image for large objects.
...
Camera clipping was left to default values, which won't work well for
very large (or small) objects. Now recompute valid clipping start/end
based on boundingbox of rendered data, and final location of camera.
2017-10-05 18:13:30 +02:00
4537e85584
Fix T53001: more workarounds for crash in AMD compiler with recent drivers.
2017-10-05 17:57:58 +02:00
fb99ea79f8
Code refactor: split displace/background into separate kernels, remove luma.
2017-10-05 17:57:58 +02:00
Campbell Barton
d8509b349d
Sculpt Mode: 2D falloff option
...
This makes brush influence into a tube instead of a sphere.
It can be used along the outline of a mesh to adjust it's silhouette.
Note that all this takes advantage of changes from vertex paint,
from testing this seems useful so exposing from the brush options.
2017-10-06 01:20:31 +11:00
Campbell Barton
56a07ba706
Vertex Paint: apply when cursor isn't over faces
...
This behavior makes more sense for sculpt, less so for painting.
Restores non PBVH behavior, adding `BKE_pbvh_find_nearest_to_ray` -
similar to ray-cast except it finds the closest point on the surface.
2017-10-05 21:21:01 +11:00
Campbell Barton
0badb6c804
Cleanup: rename dist -> depth
...
Prepare to add code that stores distance to the ray, avoid confusion.
2017-10-05 21:09:12 +11:00
Campbell Barton
21d91de8e7
Cleanup: remove unused struct member
...
Merged with soc-2016-pbvh-painting, no longer needed.
2017-10-05 17:52:05 +11:00
Campbell Barton
82d6a30015
Disable cursor drawing while navigating
...
Was performing ray-casts in sculpt mode on every update.
2017-10-05 17:35:46 +11:00
Campbell Barton
775c773cf4
Fix sculpt secondary color missing some brushes
...
D2841 by @uvwxyz w/ edits
2017-10-05 12:59:22 +11:00
Campbell Barton
3c67efbbc5
Cleanup: use bool for brush checks
2017-10-05 12:59:18 +11:00
Campbell Barton
974053f7e9
Fix brush reset (missing notifier)
...
D2843 by @uvwxyz
2017-10-05 12:32:24 +11:00
Campbell Barton
57a93b4678
CMake: use restrict w/ gcc, not clang
2017-10-05 12:10:34 +11:00
Campbell Barton
96477be3b6
PyAPI: fast keyword parsing for bpy modules
...
No functional changes.
2017-10-05 10:52:18 +11:00
Campbell Barton
7cc952ac5d
CMake: add -Wrestrict for GCC
2017-10-05 10:50:51 +11:00
Campbell Barton
d27ca066e7
Fix passing the same argument twice to BLI_strncpy
2017-10-05 10:50:51 +11:00
Campbell Barton
ffb190244c
Fix setting the operator name in Py operator API
2017-10-05 10:50:51 +11:00
49199963bf
Fix incorrect CUDA remaining time estimate after previous commit.
2017-10-04 23:25:51 +02:00
6da6f8d33f
Cycles: CUDA faster rendering of small tiles, using multiple samples like OpenCL.
...
The work size is still very conservative, and this doesn't help for progressive
refine. For that we will need to render multiple tiles at the same time. But this
should already help for denoising renders that require too much memory with big
tiles, and just generally soften the performance dropoff with small tiles.
Differential Revision: https://developer.blender.org/D2856
2017-10-04 21:58:47 +02:00
77f300e2a9
Fix use of uninitialized memory in Cycles normal baking.
2017-10-04 21:11:14 +02:00
5bb677e592
Code refactor: zero render buffers outside of kernel.
...
This was originally done with the first sample in the kernel for better
performance, but it doesn't work anymore with atomics. Any benefit was
very minor anyway, too small to measure it seems.
2017-10-04 21:11:14 +02:00
12f4538205
Code refactor: use split variance calculation for mega kernels too.
...
There is no significant difference in denoised benchmark scenes and
denoising ctests, so might as well make it all consistent.
2017-10-04 21:11:14 +02:00
e3e16cecc4
Code refactor: remove rng_state buffer and compute hash on the fly.
...
A little faster on some benchmark scenes, a little slower on others, seems
about performance neutral on average and saves a little memory.
2017-10-04 21:11:14 +02:00
5b7d6ea54b
Code refactor: add WorkTile struct for passing work to kernel.
...
This makes sharing some code between mega/split in following commits a bit
easier, and also paves the way for rendering multiple tiles later.
2017-10-04 21:11:14 +02:00
660e8e59e7
Fix T52645, T52645: AMD OpenCL compiler crash with recent drivers.
...
Work around the bug by reshuffling code.
2017-10-04 21:00:46 +02:00
Bastien Montagne
754f5d39c5
installdeps: Fix building numpy with newer py system...
...
Many thanks to Jens Verwiebe for investigating and finding this fix.
2017-10-04 20:16:39 +02:00
Ray Molenkamp
57d7e5b6ee
Fix T42489 and T52936: Loading blend with minimized window results in crash or empty screen on windows.
...
Reviewed By: @brecht , @sergey
Differential Revision: http://developer.blender.org/D2866
2017-10-04 11:44:22 -06:00
Campbell Barton
296757804c
Fix error copying smoke modifier uv layer
2017-10-05 02:44:02 +11:00
Bastien Montagne
9609828000
Tssst, we use USA english, not Oxford one... :P
2017-10-04 12:42:33 +02:00
Bastien Montagne
a22af1a84b
Fix i18n messages extraction script, and a few more UI messages...
2017-10-04 12:39:06 +02:00
Sergey Sharybin
b22b2c783d
Fix T52982: Join operator with context override crashes Blender 2.79
2017-10-04 15:00:05 +05:00
