hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

[java] typeresolution: avoid NPE if no type is known for a method argument

Browse Source
This commit is contained in:
Andreas Dangel
2017-10-06 17:12:04 +02:00
parent 231956c47e
commit 04e65cd20c
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/typeresolution/MethodTypeResolution.java
View File

@ -14,6 +14,8 @@ import java.lang.reflect.TypeVariable;
import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
import java.util.logging.Level;
import java.util.logging.Logger;
import net.sourceforge.pmd.lang.ast.Node;
import net.sourceforge.pmd.lang.java.ast.ASTArgumentList;
@ -32,6 +34,8 @@ import net.sourceforge.pmd.lang.java.typeresolution.typeinference.Variable;
public final class MethodTypeResolution {
private MethodTypeResolution() {}
private static final Logger log = Logger.getLogger(MethodTypeResolution.class.getName());
private static final List<Class<?>> PRIMITIVE_SUBTYPE_ORDER;
private static final List<Class<?>> BOXED_PRIMITIVE_SUBTYPE_ORDER;
@ -573,6 +577,10 @@ public final class MethodTypeResolution {
}
public static boolean isMethodConvertible(JavaTypeDefinition parameter, ASTExpression argument) {
if (argument.getTypeDefinition() == null) {
log.log(Level.FINE, "No type information for node {0}", argument.toString());
return true;
}
return isMethodConvertible(parameter, argument.getTypeDefinition());
}
@ -612,6 +620,10 @@ public final class MethodTypeResolution {
public static boolean isSubtypeable(JavaTypeDefinition parameter, ASTExpression argument) {
if (argument.getTypeDefinition() == null) {
log.log(Level.FINE, "No type information for node {0}", argument.toString());
return true;
}
return isSubtypeable(parameter, argument.getTypeDefinition());
}