hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

[doc] Fix file handle leak in SidebarGenerator

Browse Source
This commit is contained in:
Andreas Dangel
2018-01-17 20:19:33 +01:00
parent 1ef5367498
commit 090975a972
1 changed files with 7 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
pmd-doc/src/main/java/net/sourceforge/pmd/docs/SidebarGenerator.java
View File

@ -5,6 +5,7 @@
package net.sourceforge.pmd.docs;
import java.io.IOException;
import java.io.Reader;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
@ -85,10 +86,12 @@ public class SidebarGenerator {
}
public Map<String, Object> loadSidebar() throws IOException {
Yaml yaml = new Yaml();
@SuppressWarnings("unchecked")
Map<String, Object> sidebar = (Map<String, Object>) yaml.load(Files.newBufferedReader(sidebarPath, StandardCharsets.UTF_8));
return sidebar;
try (Reader reader = Files.newBufferedReader(sidebarPath, StandardCharsets.UTF_8)) {
Yaml yaml = new Yaml();
@SuppressWarnings("unchecked")
Map<String, Object> sidebar = (Map<String, Object>) yaml.load(reader);
return sidebar;
}
}
public void writeSidebar(Map<String, Object> sidebar) throws IOException {