hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Merge pull request #4586 from adangel:ruleset-xml

Browse Source 
Use explicit encoding in ruleset xml files #4586
This commit is contained in:
Andreas Dangel
2023-10-19 09:41:57 +02:00
parent b9bc6ac58b 2450177da6
commit 0c53b69e82
182 changed files with 235 additions and 190 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.ci/files/all-regression-rules.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="All Regression Rules"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
docs/pages/release_notes.md
View File

@ -51,6 +51,7 @@ The remaining section describes the complete release notes for 7.0.0.
* miscellaneous
* [#4699](https://github.com/pmd/pmd/pull/4699): Make PMD buildable with java 21
* [#4586](https://github.com/pmd/pmd/pull/4586): Use explicit encoding in ruleset xml files
* java-codestyle
* [#2847](https://github.com/pmd/pmd/issues/2847): \[java] New Rule: Use Explicit Types
* [#4578](https://github.com/pmd/pmd/issues/4578): \[java] CommentDefaultAccessModifier comment needs to be before annotation if present
@ -396,6 +397,7 @@ See also [Detailed Release Notes for PMD 7]({{ baseurl }}pmd_release_notes_pmd7.
* [#4462](https://github.com/pmd/pmd/issues/4462): Provide Software Bill of Materials (SBOM)
* [#4460](https://github.com/pmd/pmd/pull/4460): Fix assembly-plugin warnings
* [#4582](https://github.com/pmd/pmd/issues/4582): \[dist] Download link broken
* [#4586](https://github.com/pmd/pmd/pull/4586): Use explicit encoding in ruleset xml files
* [#4691](https://github.com/pmd/pmd/issues/4691): \[CVEs] Critical and High CEVs reported on PMD and PMD dependencies
* [#4699](https://github.com/pmd/pmd/pull/4699): Make PMD buildable with java 21
* ant

2
pmd-apex/src/main/resources/category/apex/bestpractices.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Best Practices"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/codestyle.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Code Style"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/design.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Design"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/documentation.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Documentation"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/errorprone.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Error Prone"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/multithreading.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Multithreading"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/performance.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Performance"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-apex/src/main/resources/category/apex/security.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="Security"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

9
pmd-apex/src/test/java/net/sourceforge/pmd/lang/apex/DefaultRulesetTest.java
View File

@ -9,12 +9,14 @@ import static org.junit.jupiter.api.Assertions.assertTrue;
import org.junit.jupiter.api.Test;
import net.sourceforge.pmd.AbstractRuleSetFactoryTest;
import net.sourceforge.pmd.RuleSet;
import net.sourceforge.pmd.RuleSetLoader;
import com.github.stefanbirkner.systemlambda.SystemLambda;
class DefaultRulesetTest {
private static final String QUICKSTART_RULESET = "rulesets/apex/quickstart.xml";
@Test
void loadDefaultRuleset() {
@ -25,12 +27,17 @@ class DefaultRulesetTest {
@Test
void loadQuickstartRuleset() throws Exception {
String log = SystemLambda.tapSystemErr(() -> {
RuleSet ruleset = rulesetLoader().loadFromResource("rulesets/apex/quickstart.xml");
RuleSet ruleset = rulesetLoader().loadFromResource(QUICKSTART_RULESET);
assertNotNull(ruleset);
});
assertTrue(log.isEmpty(), "No Logging expected");
}
@Test
void correctEncoding() throws Exception {
assertTrue(AbstractRuleSetFactoryTest.hasCorrectEncoding(QUICKSTART_RULESET));
}
private RuleSetLoader rulesetLoader() {
return new RuleSetLoader().enableCompatibility(false);
}

2
pmd-core/src/main/resources/rulesets/internal/all-ecmascript.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="All ECMAScript Rules"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/internal/all-java.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="All Java Rules"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/33.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="33"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/34.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="34"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/35.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="35"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/36.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="36"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/37-jsp.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="37"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/37.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="37"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/38.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="38"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/39.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="39"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/40rc1.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="40rc1"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/41.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="41"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/42.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="42"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/50.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="50"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/501.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="501"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/510.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="510"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/512.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="512"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/520.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="520"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

2
pmd-core/src/main/resources/rulesets/releases/540.xml
View File

@ -1,4 +1,4 @@
<?xml version="1.0"?>
<?xml version="1.0" encoding="UTF-8"?>
<ruleset name="540"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"

Some files were not shown because too many files have changed in this diff Show More