hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Small performance improvements for rule FieldDeclarationsShouldBeAtStartOfClass

Browse Source 
It is the slowest rule from #1308 PMD runs endlessly on some generated files
This commit is contained in:
Andreas Dangel
2015-01-24 15:57:04 +01:00
parent 4be14adebb
commit 172c20efa6
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pmd-java/src/main/resources/rulesets/java/design.xml
View File

@ -1805,10 +1805,16 @@ Fields should be declared at the top of the class, before any method declaration
<value>
<![CDATA[
//ClassOrInterfaceBody/ClassOrInterfaceBodyDeclaration/FieldDeclaration
[not(.//ClassOrInterfaceBodyDeclaration) or $ignoreAnonymousClassDeclarations = 'false']
[count(../preceding-sibling::ClassOrInterfaceBodyDeclaration/child::*[1]
[name() != 'FieldDeclaration' and name() != 'Annotation' and
(name() != 'EnumDeclaration' or $ignoreEnumDeclarations = 'false')]) > 0]
[not(.//ClassOrInterfaceBodyDeclaration) or $ignoreAnonymousClassDeclarations = 'false']
[../preceding-sibling::ClassOrInterfaceBodyDeclaration
[
count(child::*)
- count(FieldDeclaration)
- count(Annotation)
- count(EnumDeclaration[$ignoreEnumDeclarations = 'true'])
> 0
]
]
]]>
</value>
</property>