hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Add unit test for boundary checking

Browse Source
This commit is contained in:
Juan Martín Sotuyo Dodero
2018-03-23 01:17:17 -03:00
parent 809310cbd2
commit 257d11e4f1
2 changed files with 84 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

72
pmd-core/src/test/java/net/sourceforge/pmd/lang/ast/AbstractNodeTransversalTest.java Normal file
View File

@ -0,0 +1,72 @@
/**
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.ast;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import java.util.ArrayList;
import java.util.List;
import org.junit.Before;
import org.junit.Test;
/**
* Unit test for {@link AbstractNode} tree transversal methods
*/
public class AbstractNodeTransversalTest {
private int id;
private Node rootNode;
private int nextId() {
return id++;
}
private Node newDummyNode(boolean boundary) {
return new DummyNode(nextId(), boundary);
}
private Node addChild(final Node parent, final Node child) {
parent.jjtAddChild(child, parent.jjtGetNumChildren()); // Append child at the end
child.jjtSetParent(parent);
return parent;
}
@Before
public void setUpSampleNodeTree() {
id = 0;
rootNode = newDummyNode(false);
}
@Test
public void testBoundaryIsHonored() {
addChild(rootNode, addChild(newDummyNode(true), newDummyNode(false)));
List<DummyNode> descendantsOfType = rootNode.findDescendantsOfType(DummyNode.class);
assertEquals(1, descendantsOfType.size());
assertTrue(descendantsOfType.get(0).isFindBoundary());
}
@Test
public void testSearchFromBoundary() {
addChild(rootNode, addChild(newDummyNode(true), newDummyNode(false)));
List<DummyNode> descendantsOfType = rootNode.findDescendantsOfType(DummyNode.class).get(0).findDescendantsOfType(DummyNode.class);
assertEquals(1, descendantsOfType.size());
assertFalse(descendantsOfType.get(0).isFindBoundary());
}
@Test
public void testSearchIgnoringBoundary() {
addChild(rootNode, addChild(newDummyNode(true), newDummyNode(false)));
List<DummyNode> descendantsOfType = new ArrayList<>();
rootNode.findDescendantsOfType(DummyNode.class, descendantsOfType, true);
assertEquals(2, descendantsOfType.size());
assertTrue(descendantsOfType.get(0).isFindBoundary());
assertFalse(descendantsOfType.get(1).isFindBoundary());
}
}

12
pmd-core/src/test/java/net/sourceforge/pmd/lang/ast/DummyNode.java
View File

@ -5,8 +5,15 @@
package net.sourceforge.pmd.lang.ast;
public class DummyNode extends AbstractNode {
private final boolean findBoundary;
public DummyNode(int id) {
this(id, false);
}
public DummyNode(int id, boolean findBoundary) {
super(id);
this.findBoundary = findBoundary;
}
@Override
@ -18,4 +25,9 @@ public class DummyNode extends AbstractNode {
public String getXPathNodeName() {
return "dummyNode";
}
@Override
public boolean isFindBoundary() {
return findBoundary;
}
}