hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Performance improvement by replacing call to findChildNodesWithXPath()

Browse Source 
with findChildrenOfType() and custom match logic.  My test scenario
went from 39s time spent by this Rule to less than 1s.
Minor reformatting too.


git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4964 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Ryan Gustafson
2007-01-21 07:07:45 +00:00
parent dd355e8734
commit 2a62df0b32
1 changed files with 22 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
pmd/src/net/sourceforge/pmd/rules/design/PreserveStackTrace.java
View File

@ -14,13 +14,16 @@ import net.sourceforge.pmd.ast.SimpleNode;
import net.sourceforge.pmd.symboltable.VariableNameDeclaration;
import org.jaxen.JaxenException;
import java.util.ArrayList;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
public class PreserveStackTrace extends AbstractRule {
public Object visit(ASTCatchStatement node, Object data) {
private List nameNodes = new ArrayList();
public Object visit(ASTCatchStatement node, Object data) {
String target = (((SimpleNode) node.jjtGetChild(0).jjtGetChild(1)).getImage());
List lstThrowStatements = node.findChildrenOfType(ASTThrowStatement.class);
for (Iterator iter = lstThrowStatements.iterator(); iter.hasNext();) {
@ -56,7 +59,7 @@ public class PreserveStackTrace extends AbstractRule {
}
}
} else if(child.getClass().equals(ASTClassOrInterfaceType.class)){
addViolation((RuleContext) data, throwStatement);
addViolation((RuleContext) data, throwStatement);
}
}
}
@ -64,17 +67,21 @@ public class PreserveStackTrace extends AbstractRule {
return super.visit(node, data);
}
private void ck(Object data, String target,
ASTThrowStatement throwStatement, ASTArgumentList args) {
try {
List lst = args.findChildNodesWithXPath("//Name[@Image='" + target
+ "']");
if (lst.isEmpty()) {
RuleContext ctx = (RuleContext) data;
addViolation(ctx, throwStatement);
}
} catch (JaxenException e) {
e.printStackTrace();
}
}
private void ck(Object data, String target, ASTThrowStatement throwStatement,
ASTArgumentList args) {
boolean match = false;
nameNodes.clear();
args.findChildrenOfType(ASTName.class, nameNodes);
for (int i = 0; i < nameNodes.size(); i++) {
ASTName nameNode = (ASTName)nameNodes.get(i);
if (target.equals(nameNode.getImage())) {
match = true;
break;
}
}
if (!match) {
RuleContext ctx = (RuleContext) data;
addViolation(ctx, throwStatement);
}
}
}