hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Fixed bug 1570824 - HTML reports generated on Windows no longer contain double backslashes. This caused problems when viewing those reports with Apache.

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4861 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Tom Copeland
2006-12-05 14:38:24 +00:00
parent 5f3dcf3dfc
commit 2b2869b853
5 changed files with 8 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
pmd/etc/changelog.txt
View File

@ -18,6 +18,7 @@ Fixed bug 1581123 - False +: UnnecessaryWrapperObjectCreation.
Fixed bug 1592710 - VariableNamingConventions no longer reports false positives on certain enum declarations.
Fixed bug 1593292 - The CPD GUI now works with the 'by extension' option selected.
Fixed bug 1560944 - CPD now skips symlinks.
Fixed bug 1570824 - HTML reports generated on Windows no longer contain double backslashes. This caused problems when viewing those reports with Apache.
Applied patch 1551189 - SingularField false + for initialization blocks
Applied patch 1573981 - false + in CloneMethodMustImplementCloneable
Applied patch 1574988 - false + in OverrideBothEqualsAndHashcode

20
pmd/regress/test/net/sourceforge/pmd/renderers/AbstractRendererTst.java
View File

@ -20,22 +20,10 @@ public abstract class AbstractRendererTst extends RuleTst {
addViolation(ctx, c);
return ctx;
}
public String getMessage() {
return "msg";
}
public String getName() {
return "Foo";
}
public String getRuleSetName() {
return "RuleSet";
}
public String getDescription() {
return "desc";
}
public String getMessage() { return "msg"; }
public String getName() { return "Foo"; }
public String getRuleSetName() { return "RuleSet"; }
public String getDescription() { return "desc"; }
}
private static class FooRule2 extends FooRule {

1
pmd/regress/test/net/sourceforge/pmd/renderers/HTMLRendererTest.java
View File

@ -1,6 +1,7 @@
package test.net.sourceforge.pmd.renderers;
import net.sourceforge.pmd.PMD;
import net.sourceforge.pmd.Report;
import net.sourceforge.pmd.Report.ProcessingError;
import net.sourceforge.pmd.renderers.AbstractRenderer;
import net.sourceforge.pmd.renderers.HTMLRenderer;

2
pmd/src/net/sourceforge/pmd/renderers/HTMLRenderer.java
View File

@ -143,7 +143,7 @@ public class HTMLRenderer extends AbstractRenderer {
if (linkPrefix == null) {
return filename;
}
String newFileName = filename.substring(0, filename.lastIndexOf('.'));
String newFileName = filename.substring(0, filename.lastIndexOf('.')).replace('\\', '/');
return "<a href=\"" + linkPrefix + newFileName + ".html#" + line + "\">" + newFileName + "</a>";
}
}

2
pmd/xdocs/credits.xml
View File

@ -54,6 +54,7 @@
</subsection>
<subsection name="Contributors">
<ul>
<li>Brent Fisher - Fixed report backslash bug, SummaryHTML report improvements</li>
<li>Thomas Leplus - Rewrote UselessStringValueOf</li>
<li>Larry Brigman - Reported symlink bug in CPD</li>
<li>Harald Rohan - Reported bug in CPD GUI</li>
@ -68,7 +69,6 @@
<li>Peter Van de Voorde - Rewrote the 'create rule XML' functionality in the designer utility</li>
<li>Josh Devins - Reported bug with annotation parsing</li>
<li>Alan Berg - Reported bug in Ant task</li>
<li>Brent Fisher - SummaryHTML report improvements</li>
<li>George Thomas - Wrote AvoidRethrowingException rule</li>
<li>Robert Simmons - Reported bug in optimizations package along with suggestions for fix</li>
<li>Brian Remedios - display cleanup of CPD GUI, code cleanup of StringUtil and various rules, cleanup of rule designer, code cleanup of net.sourceforge.pmd.ant.Formatter.java, code improvements to Eclipse plugin, created AbstractPoorMethodCall and refactored UseIndexOfChar</li>