PMD on PMD: UseCollectionIsEmpty

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4751 51baf565-9d33-0410-a72c-fc3788e3496d

pmd/src/net/sourceforge/pmd/rules/SingularField.java

@@ -52,7 +52,7 @@ public class SingularField extends AbstractRule {
                 }
             }
 
-            if (violation && usages.size() != 0) {
+            if (violation && !usages.isEmpty()) {
                 addViolation(data, node, new Object[] { declaration.getImage() });
             }
         }

pmd/src/net/sourceforge/pmd/rules/design/PreserveStackTrace.java

@@ -69,7 +69,7 @@ public class PreserveStackTrace extends AbstractRule {
 		try {
 			List lst = args.findChildNodesWithXPath("//Name[@Image='" + target
 					+ "']");
-			if (lst.size() == 0) {
+			if (lst.isEmpty()) {
 				RuleContext ctx = (RuleContext) data;
 				addViolation(ctx, throwStatement);
 			}

pmd/src/net/sourceforge/pmd/rules/strings/ConsecutiveLiteralAppends.java

@@ -223,7 +223,7 @@ public class ConsecutiveLiteralAppends extends AbstractRule {
      */
     private boolean isAdditive(SimpleNode n) {
         List lstAdditive = n.findChildrenOfType(ASTAdditiveExpression.class);
-        if (lstAdditive.size() == 0) {
+        if (lstAdditive.isEmpty()) {
             return false;
         }
         // if there are more than 1 set of arguments above us we're not in the

pmd/src/net/sourceforge/pmd/rules/strings/InsufficientStringBufferDeclaration.java

@@ -213,9 +213,9 @@ public class InsufficientStringBufferDeclaration extends AbstractRule {
             }
         }
         literal = (block.findChildrenOfType(ASTLiteral.class));
-        if (literal.size() == 0) {
+        if (literal.isEmpty()) {
             List name = (block.findChildrenOfType(ASTName.class));
-            if (name.size() != 0) {
+            if (!name.isEmpty()) {
                 iConstructorLength = -1;
             }
         } else if (literal.size() == 1) {