Fix tests

pmd-core/src/main/java/net/sourceforge/pmd/lang/rule/internal/LatticeRelation.java

@@ -202,13 +202,6 @@ class LatticeRelation<T, @NonNull U> {
             node.resetFrozenData();
         }
 
-        /*
-            We need to do all this because there may be diamonds
-            in the lattice, in which case some nodes are reachable through
-            several paths and we would risk combining their proper values
-            several times.
-         */
-
         int n = nodes.size();
 
         // topological sort

pmd-core/src/test/resources/net/sourceforge/pmd/TestRuleset1.xml

@@ -42,6 +42,7 @@ Just for test
         <properties>
             <property name="test2" type="String" description="test 2" value="foo"/>
             <property name="test3" type="String" description="test 3" value="bar"/>
+            <property name="xpath" value="//dummyNode" />
         </properties>
         <example>
             <![CDATA[
@@ -52,4 +53,4 @@ Just for test
 
     <rule name="TestRuleRef" ref="net/sourceforge/pmd/TestRuleset2.xml/TestRule"/>
 
-</ruleset>
+</ruleset>

pmd-test/src/main/java/net/sourceforge/pmd/test/lang/DummyLanguageModule.java

@@ -63,7 +63,7 @@ public class DummyLanguageModule extends BaseLanguageModule {
         }
     }
 
-    private static class DummyRootNode extends DummyNode implements RootNode {
+    public static class DummyRootNode extends DummyNode implements RootNode {
 
     }
 

pmd-test/src/test/java/net/sourceforge/pmd/testframework/RuleTstTest.java

@@ -49,7 +49,7 @@ public class RuleTstTest {
         verify(rule).start(any(RuleContext.class));
         verify(rule).end(any(RuleContext.class));
         verify(rule).getLanguage();
-        verify(rule).getTargetingStrategy();
+        verify(rule, times(2)).getTargetingStrategy();
         verify(rule).getMinimumLanguageVersion();
         verify(rule).getMaximumLanguageVersion();
         verify(rule).apply(any(Node.class), any(RuleContext.class));