#1410 DefaultPackage triggers on field annotated with @VisibleForTesting

pmd-java/src/main/resources/rulesets/java/controversial.xml

@@ -287,6 +287,7 @@ Use explicit scoping instead of the default package private level.
 //ClassOrInterfaceDeclaration[@Interface='false']
 /ClassOrInterfaceBody
 /ClassOrInterfaceBodyDeclaration
+[not(Annotation//Name[ends-with(@Image, 'VisibleForTesting')])]
 [
 FieldDeclaration[@PackagePrivate='true']
 or MethodDeclaration[@PackagePrivate='true']

pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/controversial/xml/DefaultPackage.xml

@@ -53,6 +53,16 @@ bad
 public class Foo {
  void bar() {
  }
+}
+        ]]></code>
+    </test-code>
+
+    <test-code>
+        <description>#1410 DefaultPackage triggers on field annotated with @VisibleForTesting</description>
+        <expected-problems>0</expected-problems>
+        <code><![CDATA[
+public class Foo {
+    @VisibleForTesting static final int[] ints = {};
 }
         ]]></code>
     </test-code>

src/site/markdown/overview/changelog.md

@@ -16,6 +16,8 @@
 
 **Bugfixes:**
 
+*   java-controversial/DefaultPackage:
+    [#1410](https://sourceforge.net/p/pmd/bugs/1410/): DefaultPackage triggers on field annotated with @VisibleForTesting
 
 **API Changes:**