hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

PMD dogfooding - avoid unnecessary local before return

Browse Source
This commit is contained in:
Andreas Dangel
2018-04-23 20:29:13 +02:00
parent 59bfc7ab52
commit 391193c044
3 changed files with 5 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
pmd-core/src/main/java/net/sourceforge/pmd/cpd/CPDConfiguration.java
View File

@ -351,7 +351,7 @@ public class CPDConfiguration extends AbstractConfiguration {
}
}
FilenameFilter filter = new FilenameFilter() {
return new FilenameFilter() {
@Override
public boolean accept(File dir, String name) {
File f = new File(dir, name);
@ -362,7 +362,6 @@ public class CPDConfiguration extends AbstractConfiguration {
return languageFilter.accept(dir, name);
}
};
return filter;
}
/**

7
pmd-core/src/main/java/net/sourceforge/pmd/cpd/GUI.java
View File

@ -720,7 +720,7 @@ public class GUI implements CPDListener {
final long start = System.currentTimeMillis();
Timer t = new Timer(1000, new ActionListener() {
return new Timer(1000, new ActionListener() {
@Override
public void actionPerformed(ActionEvent e) {
long now = System.currentTimeMillis();
@ -731,7 +731,6 @@ public class GUI implements CPDListener {
timeField.setText(formatTime(minutes, seconds));
}
});
return t;
}
private static String formatTime(long minutes, long seconds) {
@ -762,7 +761,7 @@ public class GUI implements CPDListener {
private TableModel tableModelFrom(final List<Match> items) {
TableModel model = new SortingTableModel<Match>() {
return new SortingTableModel<Match>() {
private int sortColumn;
private boolean sortDescending;
@ -837,8 +836,6 @@ public class GUI implements CPDListener {
}
}
};
return model;
}
private void sortOnColumn(int columnIndex) {

6
pmd-core/src/main/java/net/sourceforge/pmd/util/designer/Designer.java
View File

@ -312,7 +312,7 @@ public class Designer implements ClipboardOwner {
@Override
public Enumeration<TreeNode> children() {
Enumeration<TreeNode> e = new Enumeration<TreeNode>() {
return new Enumeration<TreeNode>() {
int i = 0;
@Override
@ -325,7 +325,6 @@ public class Designer implements ClipboardOwner {
return kids[i++];
}
};
return e;
}
@Override
@ -395,7 +394,7 @@ public class Designer implements ClipboardOwner {
getChildAt(0); // force it to build kids
}
Enumeration<TreeNode> e = new Enumeration<TreeNode>() {
return new Enumeration<TreeNode>() {
int i = 0;
@Override
@ -408,7 +407,6 @@ public class Designer implements ClipboardOwner {
return kids[i++];
}
};
return e;
}
@Override