hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

updated rule with property descriptors

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4671 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Brian Remedios
2006-10-16 02:11:24 +00:00
parent 55a9139f46
commit 3e8266b96a
1 changed files with 31 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

41
pmd/src/net/sourceforge/pmd/rules/design/NonThreadSafeSingleton.java
View File

@ -3,7 +3,13 @@
*/
package net.sourceforge.pmd.rules.design;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import net.sourceforge.pmd.AbstractRule;
import net.sourceforge.pmd.PropertyDescriptor;
import net.sourceforge.pmd.ast.ASTAssignmentOperator;
import net.sourceforge.pmd.ast.ASTCompilationUnit;
import net.sourceforge.pmd.ast.ASTFieldDeclaration;
@ -16,27 +22,35 @@ import net.sourceforge.pmd.ast.ASTPrimaryPrefix;
import net.sourceforge.pmd.ast.ASTPrimarySuffix;
import net.sourceforge.pmd.ast.ASTStatementExpression;
import net.sourceforge.pmd.ast.ASTSynchronizedStatement;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Map;
import net.sourceforge.pmd.properties.BooleanProperty;
public class NonThreadSafeSingleton extends AbstractRule {
private Map fieldDecls = new HashMap();
private boolean checkNonStaticMethods = true;
private boolean checkNonStaticFields = true;
public NonThreadSafeSingleton() {
checkNonStaticMethods = super.getBooleanProperty("checkNonStaticMethods");
checkNonStaticFields = super.getBooleanProperty("checkNonStaticFields");
}
private static final PropertyDescriptor checkNonStaticMethodsDescriptor = new BooleanProperty(
"checkNonStaticMethods", "Check for non-static methods.", true, 1.0f
);
private static final PropertyDescriptor checkNonStaticFieldsDescriptor = new BooleanProperty(
"checkNonStaticFields", "Check for non-static fields.", true, 2.0f
);
private static final Map propertyDescriptorsByName = asFixedMap(new PropertyDescriptor[] {
checkNonStaticMethodsDescriptor, checkNonStaticFieldsDescriptor
});
// public NonThreadSafeSingleton() {
// checkNonStaticMethods = super.getBooleanProperty("checkNonStaticMethods");
// checkNonStaticFields = super.getBooleanProperty("checkNonStaticFields");
// }
public Object visit(ASTCompilationUnit node, Object data) {
fieldDecls.clear();
checkNonStaticMethods = getBooleanProperty("checkNonStaticMethods");
checkNonStaticFields = getBooleanProperty("checkNonStaticFields");
return super.visit(node, data);
}
@ -96,4 +110,11 @@ public class NonThreadSafeSingleton extends AbstractRule {
}
return super.visit(node, data);
}
/**
* @return Map
*/
protected Map propertiesByName() {
return propertyDescriptorsByName;
}
}