hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

#1831 resolved the issue

Browse Source
This commit is contained in:
Debamoy Datta
2023-10-07 17:11:16 +05:30
parent 2bbb193d4e
commit 4aedeec734
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/errorprone/DetachedTestCaseRule.java
View File

@ -5,6 +5,7 @@
package net.sourceforge.pmd.lang.java.rule.errorprone;
import net.sourceforge.pmd.lang.ast.NodeStream;
import net.sourceforge.pmd.lang.java.ast.ASTClassOrInterfaceDeclaration;
import net.sourceforge.pmd.lang.java.ast.ASTMethodDeclaration;
import net.sourceforge.pmd.lang.java.ast.JModifier;
@ -24,7 +25,7 @@ public class DetachedTestCaseRule extends AbstractJavaRulechainRule {
// looks like a test case
methods.filter(m -> m.getArity() == 0
&& m.isVoid()
&& !m.getModifiers().hasAny(JModifier.STATIC, JModifier.PRIVATE, JModifier.PROTECTED))
&& !m.getModifiers().hasAny(JModifier.STATIC, JModifier.PRIVATE, JModifier.PROTECTED, JModifier.ABSTRACT))
// the method itself has no annotation
.filter(it -> it.getDeclaredAnnotations().isEmpty())
.forEach(m -> addViolation(data, m));