hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Allow byte[] data and byte data[] as no-varargs last argument

Browse Source
This commit is contained in:
alberto
2014-12-12 20:39:46 +01:00
parent aea6c74a8f
commit 50df3e0e11
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pmd-java/src/main/resources/rulesets/java/design.xml
View File

@@ -1771,7 +1771,8 @@ having to deal with the creation of an array.
[position()=last()]
[@Array='true']
[@Varargs='false']
[not (./Type/ReferenceType[@Array='true'][PrimitiveType[@Image='byte']] or ./Type/ReferenceType[@Array='true'][ClassOrInterfaceType[@Image='Byte']])]
[not (./Type/ReferenceType[@Array='true'][PrimitiveType[@Image='byte']] or ./Type/ReferenceType[ClassOrInterfaceType[@Image='Byte']])]
[not (./Type/PrimitiveType[@Image='byte'])]
]]></value>
</property>
</properties>

2
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/UseVarargs.xml
View File

@@ -69,6 +69,7 @@ method, do not varargs, allow byte[] as not varargs
<code><![CDATA[
public class Foo {
public void bar(File file, byte[] data) { }
public void bar2(File file, byte data[]) { }
}
]]></code>
</test-code>
@@ -80,6 +81,7 @@ method, do not varargs, allow Byte[] as not varargs
<code><![CDATA[
public class Foo {
public void bar(File file, Byte[] data) { }
public void bar(File file, Byte data[]) { }
}
]]></code>
</test-code>