hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Merge branch 'master' into 7.0.x

Browse Source
This commit is contained in:
Clément Fournier
2021-02-16 20:08:18 +01:00
parent 11592acfc5 19eea5ae31
commit 5afb4956c3
6 changed files with 116 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/ISSUE_TEMPLATE/rule_violation.md vendored
View File

@ -2,7 +2,7 @@
name: Rule violation
about: Let us know about a false positive/false negative
title: ''
labels: 'a:bug'
labels: 'a:false-positive, a:false-negative'
assignees: ''
---

11
pmd-java/src/test/java/net/sourceforge/pmd/lang/java/types/testdata/DummyCompiledClass.java vendored Normal file
View File

@ -0,0 +1,11 @@
/*
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.java.types.testdata;
public class DummyCompiledClass {
public String toString() {
return getClass().toString();
}
}

36
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/performance/xml/AppendCharacterWithChar.xml
View File

@ -233,4 +233,40 @@ public class Foo {
}
]]></code>
</test-code>
<test-code>
<description>[java] StringBuilder/Buffer false negatives with typeres #2881</description>
<expected-problems>1</expected-problems>
<code><![CDATA[
package net.sourceforge.pmd.lang.java.types.testdata;
public class DummyCompiledClass {
public String toString() {
StringBuilder sb = new StringBuilder();
int start = sb.indexOf(" ");
if (start == -1) {
sb.append("Bar");
sb.append(" "); // warning expected: Avoid appending characters as strings in StringBuffer.append.
}
return sb.toString();
}
}
]]></code>
</test-code>
<test-code>
<description>[java] StringBuilder/Buffer false negatives with typeres #2881 (countertest, no classpath)</description>
<expected-problems>1</expected-problems>
<code><![CDATA[
public class NoCompiledClass {
public String toString() {
StringBuilder sb = new StringBuilder();
int start = sb.indexOf(" ");
if (start == -1) {
sb.append("Bar");
sb.append(" "); // warning expected: Avoid appending characters as strings in StringBuffer.append.
}
return sb.toString();
}
}
]]></code>
</test-code>
</test-data>

30
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/performance/xml/ConsecutiveLiteralAppends.xml
View File

@ -1467,4 +1467,34 @@ public class Foo {
}
]]></code>
</test-code>
<test-code>
<description>[java] StringBuilder/Buffer false negatives with typeres #2881</description>
<expected-problems>1</expected-problems>
<code><![CDATA[
package net.sourceforge.pmd.lang.java.types.testdata;
public class DummyCompiledClass {
public String toString() {
StringBuffer sb = new StringBuffer();
sb.append("test "); // warning expected: StringBuffer (or StringBuilder).append is called 3 consecutive times with literals. Use a single append with a single combined String.
sb.append("test2 ").append("test3 ");
return sb.toString();
}
}
]]></code>
</test-code>
<test-code>
<description>[java] StringBuilder/Buffer false negatives with typeres #2881 (countertest, no classpath)</description>
<expected-problems>1</expected-problems>
<code><![CDATA[
public class NoCompiledClass {
public String toString() {
StringBuffer sb = new StringBuffer();
sb.append("test "); // warning expected: StringBuffer (or StringBuilder).append is called 3 consecutive times with literals. Use a single append with a single combined String.
sb.append("test2 ").append("test3 ");
return sb.toString();
}
}
]]></code>
</test-code>
</test-data>

37
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/performance/xml/InsufficientStringBufferDeclaration.xml
View File

@ -1031,4 +1031,41 @@ public class Test {
}
]]></code>
</test-code>
<test-code>
<description>[java] StringBuilder/Buffer false negatives with typeres #2881</description>
<expected-problems>1</expected-problems>
<expected-messages>
<message>StringBuffer constructor is initialized with size 16, but has at least 17 characters appended.</message>
</expected-messages>
<code><![CDATA[
package net.sourceforge.pmd.lang.java.types.testdata;
public class DummyCompiledClass {
public String toString() {
StringBuffer sb = new StringBuffer();
sb.append("test ");
sb.append("test2 ").append("test3 ");
appendToSpringBuffer(sb, "test4");
}
}
]]></code>
</test-code>
<test-code>
<description>[java] StringBuilder/Buffer false negatives with typeres #2881 (countertest, no classpath)</description>
<expected-problems>1</expected-problems>
<expected-messages>
<message>StringBuffer constructor is initialized with size 16, but has at least 17 characters appended.</message>
</expected-messages>
<code><![CDATA[
public class NoCompiledClass {
public String toString(){
StringBuffer sb = new StringBuffer();
sb.append("test ");
sb.append("test2 ").append("test3 ");
appendToSpringBuffer(sb, "test4");
}
}
]]></code>
</test-code>
</test-data>

2
pom.xml
View File

@ -95,7 +95,7 @@
<checkstyle.version>8.30</checkstyle.version>
<checkstyle.plugin.version>3.1.1</checkstyle.plugin.version>
<pmd.plugin.version>3.14.0</pmd.plugin.version>
<ant.version>1.10.8</ant.version>
<ant.version>1.10.9</ant.version>
<javadoc.plugin.version>3.2.0</javadoc.plugin.version>
<antlr.version>4.7.2</antlr.version>