hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Merge pull request #4371 from oowekyala:diagnostic-ruleset

Browse Source 
[java] Move TypeResTest rule out of security.xml #4371
This commit is contained in:
Andreas Dangel
2023-01-30 12:33:53 +01:00
parent 0547d907b0 f9bd34ac21
commit 643b78757d
4 changed files with 29 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/pages/7_0_0_release_notes.md
View File

@ -258,6 +258,7 @@ The following previously deprecated rules have been finally removed:
* [#2667](https://github.com/pmd/pmd/issues/2667): \[apex] Integrate nawforce/ApexLink to build robust Unused rule
* java
* [#4317](https://github.com/pmd/pmd/issues/4317): \[java] Some AST nodes should not be TypeNodes
* [#4367](https://github.com/pmd/pmd/issues/4367): \[java] Move testrule TypeResTest into internal
* java-bestpractices
* [#342](https://github.com/pmd/pmd/issues/342): \[java] AccessorMethodGeneration: Name clash with another public field not properly handled
* [#755](https://github.com/pmd/pmd/issues/755): \[java] AccessorClassGeneration false positive for private constructors

10
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/security/TypeResTestRule.java → pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/internal/TypeResTestRule.java
View File

@ -1,8 +1,8 @@
/**
/*
* BSD-style license; for more info see http://pmd.sourceforge.net/license.html
*/
package net.sourceforge.pmd.lang.java.rule.security;
package net.sourceforge.pmd.lang.java.rule.internal;
import org.apache.commons.lang3.StringUtils;
import org.checkerframework.checker.nullness.qual.NonNull;
@ -17,11 +17,9 @@ import net.sourceforge.pmd.lang.java.types.TypeSystem;
import net.sourceforge.pmd.util.StringUtil;
/**
* @deprecated This is just a toy rule that counts the proportion of resolved types in a codebase,
* not meant as a real rule
* This is just a toy rule that counts the proportion of resolved types
* in a codebase, not meant as a real rule.
*/
// TODO Move this rule to a (internal) diagnostics category/ruleset
@Deprecated
@SuppressWarnings("PMD")
public class TypeResTestRule extends AbstractJavaRule {

14
pmd-java/src/main/resources/category/java/security.xml
View File

@ -63,18 +63,4 @@ public class Foo {
]]>
</example>
</rule>
<rule name="TypeResTest"
language="java"
since="7.0.0"
message="Type Resolution Test"
class="net.sourceforge.pmd.lang.java.rule.security.TypeResTestRule"
externalInfoUrl="${pmd.website.baseurl}/pmd_rules_java_security.html#typerestest">
<description>
This is just a toy rule that counts the proportion of resolved types in a codebase, not meant as a real rule.
It is used to test the capability of PMD's own type resolution.
</description>
<priority>3</priority>
</rule>
</ruleset>

24
pmd-java/src/main/resources/rulesets/java/internal/diagnostics.xml Normal file
View File

@ -0,0 +1,24 @@
<?xml version="1.0"?>
<ruleset name="Diagnostics"
xmlns="http://pmd.sourceforge.net/ruleset/2.0.0"
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:schemaLocation="http://pmd.sourceforge.net/ruleset/2.0.0 https://pmd.sourceforge.io/ruleset_2_0_0.xsd">
<description>
Contains rules for internal use.
</description>
<rule name="TypeResTest"
language="java"
since="7.0.0"
message="Type Resolution Test"
class="net.sourceforge.pmd.lang.java.rule.internal.TypeResTestRule"
externalInfoUrl="${pmd.website.baseurl}/pmd_rules_java_diagnostics.html#typerestest">
<description>
This is just a toy rule that counts the proportion of resolved types in a codebase, not meant as a real rule.
It is used to test the capability of PMD's own type resolution.
</description>
<priority>3</priority>
</rule>
</ruleset>