hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

[java] LawOfDemeter - remove reversed sorting

Browse Source
This commit is contained in:
Andreas Dangel
2023-05-05 13:32:13 +02:00
parent f4ba5f83f5
commit 76db136f20
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/design/LawOfDemeterRule.java
View File

@ -305,7 +305,7 @@ public class LawOfDemeterRule extends AbstractJavaRule {
return reaching.getReaching().stream()
// sort the assignments to have a deterministic result. We need to call #foreignDegree always
// in the same order, to get the same computed degrees.
.sorted(Comparator.comparing(AssignmentEntry::getLocation, Node.COORDS_COMPARATOR).reversed())
.sorted(Comparator.comparing(AssignmentEntry::getLocation, Node.COORDS_COMPARATOR))
.mapToInt(this::foreignDegree).max().orElse(TRUSTED);
}

4
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/design/xml/LawOfDemeter.xml
View File

@ -1194,8 +1194,8 @@ public final class ControlEvent {
<expected-problems>2</expected-problems>
<expected-linenumbers>15,17</expected-linenumbers>
<expected-messages>
<message>Access to field `left` on foreign value `p` (degree 1)</message>
<message>Access to field `right` on foreign value `p` (degree 2)</message>
<message>Access to field `left` on foreign value `p` (degree 2)</message>
<message>Access to field `right` on foreign value `p` (degree 1)</message>
</expected-messages>
<code><![CDATA[
class LawOfDemeterFields {