hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Logging cleanups

Browse Source
This commit is contained in:
Juan Martín Sotuyo Dodero
2022-08-23 18:58:21 -03:00
parent afde91247f
commit 7824595603
2 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
pmd-cli/src/main/java/net/sourceforge/pmd/cli/commands/internal/CpdCommand.java
View File

@ -14,12 +14,16 @@ import java.util.Iterator;
import java.util.List;
import java.util.stream.Collectors;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
import net.sourceforge.pmd.cli.commands.typesupport.internal.CpdLanguageTypeSupport;
import net.sourceforge.pmd.cli.internal.ExecutionResult;
import net.sourceforge.pmd.cpd.CPD;
import net.sourceforge.pmd.cpd.CPDConfiguration;
import net.sourceforge.pmd.cpd.Language;
import net.sourceforge.pmd.cpd.Tokenizer;
import net.sourceforge.pmd.internal.LogMessages;
import picocli.CommandLine.Command;
import picocli.CommandLine.Option;
@ -115,15 +119,13 @@ public class CpdCommand extends AbstractAnalysisPmdSubcommand {
configuration.setCPDRenderer(CPDConfiguration.getCPDRendererFromString(rendererName, encoding.getEncoding().name()));
// TODO
// Setup CLI message reporter
//configuration.setReporter(new SimpleMessageReporter(LoggerFactory.getLogger(CpdCommand.class)));
return configuration;
}
@Override
protected ExecutionResult execute() {
final Logger logger = LoggerFactory.getLogger(CpdCommand.class);
// TODO : Create a new CpdAnalysis to match PmdAnalysis
final CPDConfiguration configuration = toConfiguration();
final CPD cpd = new CPD(configuration);
@ -137,9 +139,8 @@ public class CpdCommand extends AbstractAnalysisPmdSubcommand {
return ExecutionResult.VIOLATIONS_FOUND;
}
} catch (IOException | RuntimeException e) {
// TODO
//LOG.debug(e.toString(), e);
//LOG.error(CliMessages.errorDetectedMessage(1, CPDCommandLineInterface.PROGRAM_NAME));
logger.debug(e.toString(), e);
logger.error(LogMessages.errorDetectedMessage(1, "cpd"));
return ExecutionResult.ERROR;
}

2
pmd-cli/src/main/java/net/sourceforge/pmd/cli/commands/internal/PmdCommand.java
View File

@ -347,7 +347,7 @@ public class PmdCommand extends AbstractAnalysisPmdSubcommand {
}
private void printErrorDetected(MessageReporter reporter, int errors) {
String msg = LogMessages.errorDetectedMessage(errors, "PMD");
String msg = LogMessages.errorDetectedMessage(errors, "pmd");
// note: using error level here increments the error count of the reporter,
// which we don't want.
reporter.info(StringUtil.quoteMessageFormat(msg));