hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Added NOPMD and comments to indicate why

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4968 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Wouter Zelle
2007-01-22 21:12:21 +00:00
parent 70b048e96e
commit 7d19e1dbd8
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pmd/src/net/sourceforge/pmd/rules/ConstructorCallsOverridableMethod.java
View File

@ -552,17 +552,15 @@ public final class ConstructorCallsOverridableMethod extends AbstractRule {
putEvalPackage(nullEvalPackage);
}
//store any errors caught from other passes.
super.visit((ASTClassOrInterfaceDeclaration) node, data);
super.visit(node, data);
//skip this class if it has no evaluation package
if (!(getCurrentEvalPackage() instanceof NullEvalPackage)) {
//evaluate danger of all methods in class
while (evaluateDangerOfMethods(getCurrentEvalPackage().allMethodsOfClass)) {
}
//evaluate danger of all methods in class, this method will return false when all methods have been evaluated
while (evaluateDangerOfMethods(getCurrentEvalPackage().allMethodsOfClass)) { } //NOPMD
//evaluate danger of constructors
evaluateDangerOfConstructors1(getCurrentEvalPackage().allPrivateConstructorsOfClass, getCurrentEvalPackage().allMethodsOfClass.keySet());
while (evaluateDangerOfConstructors2(getCurrentEvalPackage().allPrivateConstructorsOfClass)) {
}
while (evaluateDangerOfConstructors2(getCurrentEvalPackage().allPrivateConstructorsOfClass)) { } //NOPMD
//get each method called on this object from a non-private constructor, if its dangerous flag it
for (Iterator it = getCurrentEvalPackage().calledMethods.iterator(); it.hasNext();) {