hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

minor refactoring

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6460 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Brian Remedios
2008-09-08 03:29:25 +00:00
parent 5f95b5a799
commit 84ed28daea
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pmd/src/net/sourceforge/pmd/lang/rule/properties/CharacterProperty.java
View File

@ -28,12 +28,17 @@ public class CharacterProperty extends AbstractProperty<Character> {
* @param theDescription String
* @param defaultStr String
* @param theUIOrder float
* @throws IllegalArgumentException
*/
public CharacterProperty(String theName, String theDescription, String defaultStr, float theUIOrder) {
this(theName, theDescription, charFrom(defaultStr), theUIOrder);
}
public static Character charFrom(String charStr) {
if (charStr == null || charStr.length() != 1) {
throw new IllegalArgumentException("missing/invalid character value");
}
return charStr.charAt(0);
}
@ -54,9 +59,6 @@ public class CharacterProperty extends AbstractProperty<Character> {
* @see net.sourceforge.pmd.PropertyDescriptor#valueFrom(String)
*/
public Character valueFrom(String valueString) throws IllegalArgumentException {
if (valueString.length() > 1) {
throw new IllegalArgumentException(valueString);
}
return Character.valueOf(valueString.charAt(0));
return charFrom(valueString);
}
}