Add test cases for #1592

This commit is contained in:
Juan Martín Sotuyo Dodero committed 2024-03-31 02:24:02 -03:00
1 parent a47a30161c
commit 86328b7ad1
4 files changed
+68

No files matched your search

@@ -4,8 +4,22 @@
package net.sourceforge.pmd.lang.java.rule.bestpractices;
import org.junit.After;
import org.junit.Before;
import net.sourceforge.pmd.test.PmdRuleTst;
class JUnit4TestShouldUseAfterAnnotationTest extends PmdRuleTst {
// no additional unit tests
public static class BaseTest {
@Before
public void setUp() {
// A setup code
}
@After
public void tearDown() {
// A tear down code
}
}
}
@@ -4,8 +4,22 @@
package net.sourceforge.pmd.lang.java.rule.bestpractices;
import org.junit.After;
import org.junit.Before;
import net.sourceforge.pmd.test.PmdRuleTst;
class JUnit4TestShouldUseBeforeAnnotationTest extends PmdRuleTst {
// no additional unit tests
public static class BaseTest {
@Before
public void setUp() {
// A setup code
}
@After
public void tearDown() {
// A tear down code
}
}
}
@@ -131,4 +131,24 @@ public class Foo {
}
]]></code>
</test-code>
<test-code>
<description>[java] JUnit4TestShouldUseBeforeAnnotation false positive when overriding setUp #1592</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import net.sourceforge.pmd.lang.java.rule.bestpractices.JUnit4TestShouldUseBeforeAnnotationTest.BaseTest;
public class AReallyCoolFeatureTest extends BaseTest {
@Override
public void setUp() {
super.setUp();
}
@Override
public void tearDown() {
super.tearDown();
}
}
]]></code>
</test-code>
</test-data>
@@ -153,4 +153,24 @@ public class Foo {
}
]]></code>
</test-code>
<test-code>
<description>[java] JUnit4TestShouldUseBeforeAnnotation false positive when overriding setUp #1592</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
import net.sourceforge.pmd.lang.java.rule.bestpractices.JUnit4TestShouldUseBeforeAnnotationTest.BaseTest;
public class AReallyCoolFeatureTest extends BaseTest {
@Override
public void setUp() {
super.setUp();
}
@Override
public void tearDown() {
super.tearDown();
}
}
]]></code>
</test-code>
</test-data>