hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Merge branch 'pr-454'

Browse Source
This commit is contained in:
Andreas Dangel
2017-06-23 14:56:21 +02:00
parent 8f8e7282e8 7ffa76e3e2
commit 92f10342c7
3 changed files with 19 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pmd-java/src/main/resources/rulesets/java/empty.xml
View File

@ -129,7 +129,7 @@ Avoid empty try blocks - what's the point?
<property name="xpath">
<value>
<![CDATA[
//TryStatement/Block[1][count(*) = 0]
//TryStatement[not(ResourceSpecification)]/Block[1][count(*) = 0]
]]>
</value>
</property>

13
pmd-java/src/test/resources/net/sourceforge/pmd/lang/java/rule/empty/xml/EmptyTryBlock.xml
View File

@ -46,6 +46,19 @@ public class EmptyTryBlock3 {
int x = 5;
}
}
}
]]></code>
</test-code>
<test-code>
<description>#432 false positive for empty try-with-resource</description>
<expected-problems>0</expected-problems>
<code><![CDATA[
class X {
void method() {
try (ClientResponse response = execute(() -> target.request(mediaTypes).delete(), DELETE, new ExpectedResponse(status, required))) {
// false positive
}
}
}
]]></code>
</test-code>

6
src/site/markdown/overview/changelog.md
View File

@ -39,6 +39,8 @@ Fields using generics are still Work in Progress, but we expect to fully support
* The ruleset java-junit now properly detects JUnit5, and rules are being adapted to the changes on it's API.
This support is, however, still incomplete. Let us know of any uses we are still missing on the [issue tracker](https://github.com/pmd/pmd/issues)
* The Java rule `EmptyTryBlock` (ruleset java-empty) now allows empty blocks when usin try-with-resources.
### Fixed Issues
* General
@ -57,8 +59,10 @@ Fields using generics are still Work in Progress, but we expect to fully support
* [#397](https://github.com/pmd/pmd/issues/397): \[java] ConstructorCallsOverridableMethodRule: false positive for method called from lambda expression
* [#410](https://github.com/pmd/pmd/issues/410): \[java] ImmutableField: False positive with lombok
* [#422](https://github.com/pmd/pmd/issues/422): \[java] PreserveStackTraceRule: false positive when using builder pattern
* java-empty
* [#432](https://github.com/pmd/pmd/issues/432): \[java] EmptyTryBlock: false positive for empty try-with-resource
* java-imports:
* [#348]((https://github.com/pmd/pmd/issues/348): \[java] imports/UnusedImport rule not considering static inner classes of imports
* [#348](https://github.com/pmd/pmd/issues/348): \[java] imports/UnusedImport rule not considering static inner classes of imports
* java-junit
* [#428](https://github.com/pmd/pmd/issues/428): \[java] PMD requires public modifier on JUnit 5 test
* java-logging: