hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

optimization in preparation for new property mgmt code: retrieving report level just once at startup

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4614 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Brian Remedios
2006-10-10 05:05:00 +00:00
parent 2ed04a9118
commit 95857a8b62
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pmd/src/net/sourceforge/pmd/rules/CyclomaticComplexity.java
View File

@ -32,6 +32,8 @@ import java.util.Stack;
*/
public class CyclomaticComplexity extends AbstractRule {
private int reportLevel = getIntProperty("reportLevel");
private static class Entry {
private SimpleNode node;
private int decisionPoints = 1;
@ -134,7 +136,7 @@ public class CyclomaticComplexity extends AbstractRule {
entryStack.push(new Entry(node));
super.visit(node, data);
Entry classEntry = (Entry) entryStack.pop();
if ((classEntry.getComplexityAverage() >= getIntProperty("reportLevel")) || (classEntry.highestDecisionPoints >= getIntProperty("reportLevel"))) {
if ((classEntry.getComplexityAverage() >= reportLevel) || (classEntry.highestDecisionPoints >= reportLevel)) {
addViolation(data, node, new String[]{"class", node.getImage(), classEntry.getComplexityAverage() + " (Highest = " + classEntry.highestDecisionPoints + ')'});
}
return data;
@ -162,7 +164,7 @@ public class CyclomaticComplexity extends AbstractRule {
}
}
if (methodEntry.decisionPoints >= getIntProperty("reportLevel")) {
if (methodEntry.decisionPoints >= reportLevel) {
addViolation(data, node, new String[]{"method", (methodDeclarator == null) ? "" : methodDeclarator.getImage(), String.valueOf(methodEntry.decisionPoints)});
}
@ -173,7 +175,7 @@ public class CyclomaticComplexity extends AbstractRule {
entryStack.push(new Entry(node));
super.visit(node, data);
Entry classEntry = (Entry) entryStack.pop();
if ((classEntry.getComplexityAverage() >= getIntProperty("reportLevel")) || (classEntry.highestDecisionPoints >= getIntProperty("reportLevel"))) {
if ((classEntry.getComplexityAverage() >= reportLevel) || (classEntry.highestDecisionPoints >= reportLevel)) {
addViolation(data, node, new String[]{"class", node.getImage(), classEntry.getComplexityAverage() + "(Highest = " + classEntry.highestDecisionPoints + ')'});
}
return data;
@ -190,7 +192,7 @@ public class CyclomaticComplexity extends AbstractRule {
if (constructorDecisionPointCount > classEntry.highestDecisionPoints) {
classEntry.highestDecisionPoints = constructorDecisionPointCount;
}
if (constructorEntry.decisionPoints >= getIntProperty("reportLevel")) {
if (constructorEntry.decisionPoints >= reportLevel) {
addViolation(data, node, new String[]{"constructor", classEntry.node.getImage(), String.valueOf(constructorDecisionPointCount)});
}
return data;