hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Use type resolution for AvoidThrowingRawExceptionTypes

Browse Source 
- Fixes the false negatives
 - Is actually 100X faster as we avoid all those `//ImportDeclaration`
This commit is contained in:
Juan Martín Sotuyo Dodero
2018-05-12 01:06:38 -03:00
parent 43839bd772
commit a378299978
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
pmd-java/src/main/resources/category/java/design.xml
View File

@ -266,13 +266,13 @@ Exception, or Error, use a subclassed exception or error instead.
<![CDATA[
//ThrowStatement//AllocationExpression
/ClassOrInterfaceType[
(@Image='Throwable' and count(//ImportDeclaration/Name[ends-with(@Image,'Throwable')]) = 0)
typeof(@Image, 'java.lang.Throwable', 'Throwable')
or
(@Image='Exception' and count(//ImportDeclaration/Name[ends-with(@Image,'Exception')]) = 0)
typeof(@Image, 'java.lang.Exception', 'Exception')
or
(@Image='Error' and count(//ImportDeclaration/Name[ends-with(@Image,'Error')]) = 0)
typeof(@Image, 'java.lang.Error', 'Error')
or
( @Image='RuntimeException' and count(//ImportDeclaration/Name[ends-with(@Image,'RuntimeException')]) = 0)
typeof(@Image, 'java.lang.RuntimeException', 'RuntimeException')
]
]]>
</value>