Moving all the "Empty rules" out of basic.xml into empty.xml

(Added a ref to empty rules in basic.xml, so that the empty rules are still accessible from basic ruleset).

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6239 51baf565-9d33-0410-a72c-fc3788e3496d

pmd/etc/changelog.txt

@@ -287,6 +287,21 @@ The default Java version processed by PMD is now uniformly Java 1.5.
 RuleViolations in Reports now uses List internally, and RuleViolationComparator is no longer broken
 TokenManager errors now include a file name whenever possible for every AST in PMD
 Added file encoding option to CPD GUI, which already existed for the command line and Ant
+Creating an Empty Code Ruleset and moved the following rules from Basic ruleset:
+        * Empty Code Rules
+        * EmptyCatchBlock
+        * EmptyIfStmt
+        * EmptyWhileStmt
+        * EmptyTryBlock
+        * EmptyFinallyBlock
+        * EmptySwitchStatements
+        * EmptySynchronizedBlock
+        * EmptyStatementNotInLoop
+        * EmptyInitializer
+        * EmptyStatementBlock
+        * EmptyStaticInitializer
+	Basic rulesets still includes a reference to those rules.
+
 
 Fixed bug 1932242 - EmptyMethodInAbstractClassShouldBeAbstract false +
 Fixed bug 1928009 - Error using migration ruleset in PMD 4.2

pmd/regress/test/net/sourceforge/pmd/RuleSetTest.java

@@ -339,7 +339,7 @@ public class RuleSetTest extends RuleTst {
 
 	RuleSet ruleSet1 = new RuleSet();
 	ruleSet1.setName("RuleSet1");
-	Rule rule = findRule("basic", "EmptyIfStmt");
+	Rule rule = findRule("empty", "EmptyIfStmt");
 	assertTrue("RuleChain rule", rule.usesRuleChain());
 	ruleSet1.addRule(rule);
 

pmd/regress/test/net/sourceforge/pmd/rules/basic/BasicRulesTest.java

@@ -25,17 +25,6 @@ public class BasicRulesTest extends SimpleAggregatorTst {
         addRule("basic", "ClassCastExceptionWithToArray");
         addRule("basic", "CollapsibleIfStatements");
         addRule("basic", "DoubleCheckedLocking");
-        addRule("basic", "EmptyCatchBlock");
-        addRule("basic", "EmptyFinallyBlock");
-        addRule("basic", "EmptyIfStmt");
-        addRule("basic", "EmptyInitializer");
-        addRule("basic", "EmptyStatementBlock");
-        addRule("basic", "EmptyStatementNotInLoop");
-        addRule("basic", "EmptyStaticInitializer");
-        addRule("basic", "EmptySwitchStatements");
-        addRule("basic", "EmptySynchronizedBlock");
-        addRule("basic", "EmptyTryBlock");
-        addRule("basic", "EmptyWhileStmt");
 	addRule("basic", "ExtendsObject");
         addRule("basic", "ForLoopShouldBeWhileLoop");
         addRule("basic", "JumbledIncrementer");

pmd/src/net/sourceforge/pmd/SimpleRuleSetNameMapper.java

@@ -50,6 +50,7 @@ public class SimpleRuleSetNameMapper {
         nameMap.put("controversial", "rulesets/controversial.xml");
         nameMap.put("coupling", "rulesets/coupling.xml");
         nameMap.put("design", "rulesets/design.xml");
+        nameMap.put("empty", "rulesets/empty.xml");
         nameMap.put("finalizers", "rulesets/finalizers.xml");
         nameMap.put("imports", "rulesets/imports.xml");
         nameMap.put("j2ee", "rulesets/j2ee.xml");