Deprecation tags, for-loop and StringBuffer conversions

git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@6869 51baf565-9d33-0410-a72c-fc3788e3496d

pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/model/FileRecord.java

@@ -314,7 +314,7 @@ public class FileRecord extends AbstractPMDRecord {
      * @return a String which is the Files Content
      */
     protected String resourceToString(IResource resource) {
-        final StringBuffer fileContents = new StringBuffer();
+        final StringBuilder fileContents = new StringBuilder();
         BufferedReader bReader = null;
         try {
             // we create a FileReader

pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/preferences/RuleCellModifier.java

@@ -13,7 +13,7 @@ import org.eclipse.swt.widgets.TableItem;
  * of the PMD Preference page
  * 
  * @author Philippe Herlin
- *
+ * @deprecated
  */
 public class RuleCellModifier implements ICellModifier {
     private TableViewer tableViewer;

pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/preferences/RuleLabelProvider.java

@@ -8,7 +8,7 @@ import net.sourceforge.pmd.eclipse.plugin.PMDPlugin;
  * rule table of the PMD Preference page
  * 
  * @author Philippe Herlin
- *
+ * @deprecated
  */
 public class RuleLabelProvider extends AbstractTableLabelProvider {
     private static final String PRIORITY_ILLEGAL = "* illegal *";

pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/views/CPDViewLabelProvider.java

@@ -101,7 +101,7 @@ public class CPDViewLabelProvider extends LabelProvider implements ITableLabelPr
         case 2:
             if (value instanceof Match) {
                 final Match match = (Match)value;
-                final StringBuffer buffer = new StringBuffer(50);
+                final StringBuilder buffer = new StringBuilder(50);
                 buffer.append("Found suspect cut & paste (");               
                 buffer.append(match.getMarkCount()).append(" matches,");
                 buffer.append(match.getLineCount());
@@ -117,7 +117,7 @@ public class CPDViewLabelProvider extends LabelProvider implements ITableLabelPr
                 final int startLine = entry.getBeginLine();
                 final int endLine = entry.getBeginLine() + match.getLineCount() - 1;
                 final IPath path = Path.fromOSString(entry.getTokenSrcID());
-                final StringBuffer buffer = new StringBuffer(100);
+                final StringBuilder buffer = new StringBuilder(100);
                 if (startLine == endLine) {
                     buffer.append("line ").append(startLine);
                 } else {

pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/views/CPDViewTooltipListener.java

@@ -140,7 +140,7 @@ public class CPDViewTooltipListener implements Listener {
 
     private String createText(Match match) {
         final String text = match.getSourceCodeSlice().replaceAll("\t", "    ");
-        final StringBuffer outputString = new StringBuffer();
+        final StringBuilder outputString = new StringBuilder();
         final StringTokenizer lines = new StringTokenizer(text, "\n");
         for (int i=0; lines.hasMoreTokens(); i++) {
             if (i < 6) {

pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/views/DataflowGraphViewer.java

@@ -160,7 +160,7 @@ public class DataflowGraphViewer extends Composite {
             // reference) in this Line of Code
             List<VariableAccess> access = inode.getVariableAccess();
             if (access != null) {
-                StringBuffer exp = new StringBuffer();
+                StringBuilder exp = new StringBuilder();
                 for (int k = 0; k < access.size(); k++) {
                     if (k > 0)
                         exp.append(", ");

pmd-eclipse-plugin/plugins/net.sourceforge.pmd.eclipse.plugin/src/net/sourceforge/pmd/eclipse/ui/views/PriorityFilter.java

@@ -165,12 +165,11 @@ public class PriorityFilter extends ViewerFilter {
      * @return the List-String
      */
     public String getPriorityFilterListAsString(String splitter) {
-        final StringBuffer listString = new StringBuffer();
-        for (int i = 0; i < priorityList.size(); i++) {
-            if (i > 0) {
-                listString.append(splitter);
-            }
-            listString.append(priorityList.get(i));
+        if (priorityList.isEmpty()) return "";
+        
+        final StringBuilder listString = new StringBuilder(priorityList.get(0));
+        for (int i=1; i<priorityList.size(); i++) {
+            listString.append(splitter).append(priorityList.get(i));
         }
         return listString.toString();
     }