hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Checking in some Java 5 changes

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@5007 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Allan Caplan
2007-01-29 18:09:16 +00:00
parent 7e26a9c1dc
commit bfc8b24bd2
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pmd/src/net/sourceforge/pmd/typeresolution/ClassTypeResolver.java
View File

@ -58,12 +58,11 @@ public class ClassTypeResolver extends JavaParserVisitorAdapter {
* @param node
*/
private void populateImports(ASTCompilationUnit node) {
List theImportDeclarations = node.findChildrenOfType(ASTImportDeclaration.class);
List<ASTImportDeclaration> theImportDeclarations = node.findChildrenOfType(ASTImportDeclaration.class);
importedClasses = new HashMap<String, String>();
// go through the imports
for (Iterator anIterator = theImportDeclarations.iterator(); anIterator.hasNext();) {
ASTImportDeclaration anImportDeclaration = (ASTImportDeclaration) anIterator.next();
for (ASTImportDeclaration anImportDeclaration : theImportDeclarations) {
if (!anImportDeclaration.isImportOnDemand()) {
String strPackage = anImportDeclaration.getPackageName();
String strName = anImportDeclaration.getImportedName();

2
pmd/src/net/sourceforge/pmd/typeresolution/rules/LooseCoupling.java
View File

@ -21,7 +21,7 @@ public class LooseCoupling extends AbstractRule {
}
public Object visit(ASTClassOrInterfaceType node, Object data) {
Node parent = node.jjtGetParent().jjtGetParent().jjtGetParent();
Node parent = node.getNthParent(3);
Class clazzType = node.getType();
boolean isType = CollectionUtil.isCollectionType(clazzType, false);
if (isType

4
pmd/src/net/sourceforge/pmd/typeresolution/visitors/PMDASMVisitor.java
View File

@ -138,8 +138,8 @@ public class PMDASMVisitor implements ClassVisitor {
private void addTypes(String desc) {
Type[] types = Type.getArgumentTypes(desc);
for (int i = 0; i < types.length; i++) {
addType(types[i]);
for (Type type : types) {
addType(type);
}
}