hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

pmd: fix #1054 XML Rules ever report a line -1 and not the line/column where the error occurs

Browse Source
This commit is contained in:
Andreas Dangel
2014-02-08 22:46:55 +01:00
parent 93a46d17e7
commit c011fc6dd1
5 changed files with 699 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pmd/pom.xml
View File

@ -634,7 +634,7 @@
<artifactId>xercesImpl</artifactId>
<version>2.9.1</version>
<type>jar</type>
<scope>runtime</scope>
<scope>compile</scope>
</dependency>
<dependency>
<groupId>net.java.dev.javacc</groupId>

283
pmd/src/main/java/net/sourceforge/pmd/lang/xml/ast/XmlParser.java
View File

File diff suppressed because it is too large Load Diff

6
pmd/src/site/markdown/changelog.md
View File

@ -42,6 +42,8 @@
* Fixed [bug 881]: private final without setter is flagged
* Fixed [bug 1059]: Change rule name "Use Singleton" should be "Use Utility class"
* Fixed [bug 1106]: PMD 5.0.4 fails with NPE on parsing java enum with inner class instance creation
* Fixed [bug 1045]: //NOPMD not working (or not implemented) with ECMAscript
* Fixed [bug 1054]: XML Rules ever report a line -1 and not the line/column where the error occurs
* Fixed [bug 1115]: commentRequiredRule in pmd 5.1 is not working properly
* Fixed [bug 1120]: equalsnull false positive
* Fixed [bug 1121]: NullPointerException when invoking XPathCLI
@ -58,7 +60,6 @@
* Fixed [bug 1141]: ECMAScript: getFinallyBlock() is buggy.
* Fixed [bug 1142]: ECMAScript: getCatchClause() is buggy.
* Fixed [bug 1144]: CPD encoding argument has no effect
* Fixed [bug 1045]: //NOPMD not working (or not implemented) with ECMAscript
* Fixed [bug 1146]: UseArrayListInsteadOfVector false positive when using own Vector class
* Fixed [bug 1147]: EmptyMethodInAbstractClassShouldBeAbstract false positives
* Fixed [bug 1150]: "EmptyExpression" for valid statements!
@ -69,6 +70,8 @@
[bug 881]: https://sourceforge.net/p/pmd/bugs/881
[bug 1059]: https://sourceforge.net/p/pmd/bugs/1059
[bug 1045]: https://sourceforge.net/p/pmd/bugs/1045
[bug 1054]: https://sourceforge.net/p/pmd/bugs/1054
[bug 1106]: https://sourceforge.net/p/pmd/bugs/1106
[bug 1115]: https://sourceforge.net/p/pmd/bugs/1115
[bug 1120]: https://sourceforge.net/p/pmd/bugs/1120
@ -86,7 +89,6 @@
[bug 1141]: https://sourceforge.net/p/pmd/bugs/1141
[bug 1142]: https://sourceforge.net/p/pmd/bugs/1142
[bug 1144]: https://sourceforge.net/p/pmd/bugs/1144
[bug 1045]: https://sourceforge.net/p/pmd/bugs/1045
[bug 1146]: https://sourceforge.net/p/pmd/bugs/1146
[bug 1147]: https://sourceforge.net/p/pmd/bugs/1147
[bug 1150]: https://sourceforge.net/p/pmd/bugs/1150

423
pmd/src/test/java/net/sourceforge/pmd/lang/xml/XmlParserTest.java Normal file
View File

File diff suppressed because it is too large Load Diff

12
pmd/src/test/java/net/sourceforge/pmd/lang/xml/rule/AbstractDomXmlRuleTest.java
View File

@ -76,8 +76,10 @@ public class AbstractDomXmlRuleTest {
// assertEquals(0, visited.size());
visited = rule.visitedNodes.get("EntityReference");
assertEquals(1, visited.size());
assertEquals("entity", ((EntityReference) visited.get(0)).getNodeName());
assertEquals(3, visited.size());
assertEquals("gt", ((EntityReference) visited.get(0)).getNodeName());
assertEquals("entity", ((EntityReference) visited.get(1)).getNodeName());
assertEquals("lt", ((EntityReference) visited.get(2)).getNodeName());
// TODO Figure out how to trigger this.
// visited = rule.visitedNodes.get("Notation");
@ -89,11 +91,9 @@ public class AbstractDomXmlRuleTest {
((ProcessingInstruction) visited.get(0)).getTarget());
visited = rule.visitedNodes.get("Text");
assertEquals(4, visited.size());
assertEquals(2, visited.size());
assertEquals("TEXT", ((Text) visited.get(0)).getData());
assertEquals(">", ((Text) visited.get(1)).getData());
assertEquals("e", ((Text) visited.get(2)).getData());
assertEquals("<", ((Text) visited.get(3)).getData());
assertEquals("e", ((Text) visited.get(1)).getData());
}
@Test