hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

Review changes implemented

Browse Source
This commit is contained in:
Shubham
2019-01-30 18:58:47 +05:30
parent 9532552eaa
commit cb0c70f1ac
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pmd-java/src/main/java/net/sourceforge/pmd/lang/java/rule/errorprone/BeanMembersShouldSerializeRule.java
View File

@ -8,6 +8,7 @@ import static net.sourceforge.pmd.properties.PropertyFactory.stringProperty;
import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.List;
import java.util.Map;
@ -35,11 +36,19 @@ public class BeanMembersShouldSerializeRule extends AbstractLombokAwareRule {
private static final PropertyDescriptor<String> PREFIX_DESCRIPTOR = stringProperty("prefix").desc("A variable prefix to skip, i.e., m_").defaultValue("").build();
public BeanMembersShouldSerializeRule() {
definePropertyDescriptor(PREFIX_DESCRIPTOR);
}
@Override
protected Collection<String> defaultSuppressionAnnotations() {
return Arrays.asList(
"lombok.Data",
"lombok.Getter",
"lombok.Value"
);
}
@Override
public Object visit(ASTCompilationUnit node, Object data) {
prefixProperty = getProperty(PREFIX_DESCRIPTOR);
@ -63,7 +72,9 @@ public class BeanMembersShouldSerializeRule extends AbstractLombokAwareRule {
return data;
}
boolean classHasLombok = hasLombokAnnotation(node);
if (hasLombokAnnotation(node)) {
return super.visit(node, data);
}
Map<MethodNameDeclaration, List<NameOccurrence>> methods = node.getScope().getEnclosingScope(ClassScope.class)
.getMethodDeclarations();
@ -85,7 +96,7 @@ public class BeanMembersShouldSerializeRule extends AbstractLombokAwareRule {
VariableNameDeclaration decl = entry.getKey();
AccessNode accessNodeParent = decl.getAccessNodeParent();
if (entry.getValue().isEmpty() || accessNodeParent.isTransient() || accessNodeParent.isStatic()
|| classHasLombok || hasIgnoredAnnotation((Annotatable) accessNodeParent)) {
|| hasIgnoredAnnotation((Annotatable) accessNodeParent)) {
continue;
}
String varName = StringUtils.capitalize(trimIfPrefix(decl.getImage()));