hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

xpath removed: rule has been rewritten in Java

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4858 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Xavier Le Vourch
2006-12-04 18:15:10 +00:00
parent deb8bb0e6f
commit cc320fdaa3
2 changed files with 8 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
pmd/rulesets/basic.xml
View File

@ -570,23 +570,6 @@ public class MyClass {
<description>
Avoid instantiating Boolean objects; you can reference Boolean.TRUE, Boolean.FALSE, or call Boolean.valueOf() instead.
</description>
<properties>
<property name="xpath">
<value>
<![CDATA[
//PrimaryExpression[
PrimaryPrefix/AllocationExpression[not (ArrayDimsAndInits) and (ClassOrInterfaceType/@Image='Boolean' or ClassOrInterfaceType/@Image='java.lang.Boolean')]
or
(
PrimaryPrefix/Name[@Image='Boolean.valueOf']
and
PrimarySuffix/Arguments//BooleanLiteral
)
]
]]>
</value>
</property>
</properties>
<priority>2</priority>
<example>
<![CDATA[

16
pmd/rulesets/design.xml
View File

@ -434,7 +434,7 @@ public class Foo {
<rule name="OptimizableToArrayCall"
message="This call to Collection.toArray() may be optimizable"
class="net.sourceforge.pmd.rules.XPathRule"
class="net.sourceforge.pmd.rules.xpath.PrimaryExpressionXPathRule"
externalInfoUrl="http://pmd.sourceforge.net/rules/design.html#OptimizableToArrayCall">
<description>
A call to Collection.toArray can use the Collection's size vs an empty Array of the desired type.
@ -443,7 +443,7 @@ A call to Collection.toArray can use the Collection's size vs an empty Array of
<property name="xpath">
<value>
<![CDATA[
//PrimaryExpression
.
[PrimaryPrefix/Name[ends-with(@Image, 'toArray')]]
[
PrimarySuffix/Arguments/ArgumentList/Expression
@ -502,7 +502,7 @@ public class Bar {
<rule name="EqualsNull"
message="Avoid using equals() to compare against null"
class="net.sourceforge.pmd.rules.XPathRule"
class="net.sourceforge.pmd.rules.xpath.PrimaryExpressionXPathRule"
externalInfoUrl="http://pmd.sourceforge.net/rules/design.html#EqualsNull">
<description>
Inexperienced programmers sometimes confuse comparison concepts
@ -512,7 +512,7 @@ and use equals() to compare to null.
<property name="xpath">
<value>
<![CDATA[
//PrimaryExpression
.
[
PrimaryPrefix/Name[ends-with(@Image, 'equals')]
or
@ -679,7 +679,7 @@ public class Foo {
<rule name="UseLocaleWithCaseConversions"
message="When doing a String.toLowerCase()/toUpperCase() call, use a Locale"
class="net.sourceforge.pmd.rules.XPathRule"
class="net.sourceforge.pmd.rules.xpath.PrimaryExpressionXPathRule"
externalInfoUrl="http://pmd.sourceforge.net/rules/design.html#UseLocaleWithCaseConversions">
<description>
When doing a String.toLowerCase()/toUpperCase() call, use a Locale. This avoids
@ -707,7 +707,7 @@ class Foo {
<property name="xpath">
<value>
<![CDATA[
//PrimaryExpression
.
[PrimaryPrefix/Name
[ends-with(@Image, 'toLowerCase') or ends-with(@Image,
'toUpperCase')]
@ -1068,7 +1068,7 @@ class Foo {
<rule name="PositionLiteralsFirstInComparisons"
message="Position literals first in String comparisons"
class="net.sourceforge.pmd.rules.XPathRule"
class="net.sourceforge.pmd.rules.xpath.PrimaryExpressionXPathRule"
externalInfoUrl="http://pmd.sourceforge.net/rules/design.html#PositionLiteralsFirstInComparisons">
<description>
Position literals first in String comparisons - that way if the String is null you won't get a NullPointerException, it'll just return false.
@ -1076,7 +1076,7 @@ class Foo {
<properties>
<property name="xpath">
<value><![CDATA[
//PrimaryExpression[PrimaryPrefix[Name[ends-with(@Image, '.equals')]][..//Literal]]
.[PrimaryPrefix[Name[ends-with(@Image, '.equals')]][..//Literal]]
[not(ancestor::Expression/ConditionalAndExpression//EqualityExpression[@Image='!=']//NullLiteral)]
[not(ancestor::Expression/ConditionalOrExpression//EqualityExpression[@Image='==']//NullLiteral)]
]]></value>