hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

[apex] AvoidNonRestrictiveQueriesRule - reuse SEE_ALL_DATA

Browse Source 
This is already defined in ASTAnnotationParameter
This commit is contained in:
Andreas Dangel 2024-07-12 09:11:22 +02:00
parent 4044abca91
commit ccb0e2e228
No known key found for this signature in database
GPG Key ID: 93450DF2DF9A3FA3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pmd-apex/src/main/java/net/sourceforge/pmd/lang/apex/rule/performance/AvoidNonRestrictiveQueriesRule.java
View File

@ -25,7 +25,6 @@ public class AvoidNonRestrictiveQueriesRule extends AbstractApexRule {
private static final Pattern RESTRICTIVE_PATTERN = Pattern.compile("(where )|(limit )", Pattern.CASE_INSENSITIVE);
private static final Pattern SELECT_PATTERN = Pattern.compile("(select )", Pattern.CASE_INSENSITIVE);
private static final Pattern SUB_QUERY_PATTERN = Pattern.compile("(?i)\\(\\s*select\\s+[^)]+\\)");
private static final String SEE_ALL_DATA_ANNOTATION_PARAMETER = "SeeAllData";
@Override
protected @NonNull RuleTargetSelector buildTargetSelector() {
@ -52,11 +51,11 @@ public class AvoidNonRestrictiveQueriesRule extends AbstractApexRule {
.map(NodeStream::first);
Optional<Boolean> methodSeeAllData = methodAnnotation.flatMap(m -> m.children(ASTAnnotationParameter.class)
.filter(p -> SEE_ALL_DATA_ANNOTATION_PARAMETER.equalsIgnoreCase(p.getName()))
.filter(p -> ASTAnnotationParameter.SEE_ALL_DATA.equalsIgnoreCase(p.getName()))
.firstOpt()
.map(ASTAnnotationParameter::getBooleanValue));
boolean classSeeAllData = classAnnotation.flatMap(m -> m.children(ASTAnnotationParameter.class)
.filter(p -> SEE_ALL_DATA_ANNOTATION_PARAMETER.equalsIgnoreCase(p.getName()))
.filter(p -> ASTAnnotationParameter.SEE_ALL_DATA.equalsIgnoreCase(p.getName()))
.firstOpt()
.map(ASTAnnotationParameter::getBooleanValue))
.orElse(false);