hiifong/pmd
1
0
Fork 0
forked from phoedos/pmd
Code Pull Requests Activity

violation overview was not updated in some cases... fixed

Browse Source 
git-svn-id: https://pmd.svn.sourceforge.net/svnroot/pmd/trunk@4948 51baf565-9d33-0410-a72c-fc3788e3496d
This commit is contained in:
Sven Jacob
2007-01-14 21:03:49 +00:00
parent ad55a35501
commit d35f00bdd5
1 changed files with 9 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
pmd-eclipse-ui/src/net/sourceforge/pmd/ui/views/ViolationOverviewContentProvider.java
View File

@ -72,6 +72,9 @@ import org.eclipse.jface.viewers.Viewer;
* @version $Revision$
*
* $Log$
* Revision 1.7 2007/01/14 21:03:49 holobender
* violation overview was not updated in some cases... fixed
*
* Revision 1.6 2006/11/20 14:55:31 holobender
* fix to minor refresh problems
*
@ -515,12 +518,11 @@ public class ViolationOverviewContentProvider implements ITreeContentProvider, I
* @param changes
*/
protected void updateViewer(List additions, List removals, List changes) {
final List refreshList = new ArrayList();
// perform removals
if (removals.size() > 0) {
this.treeViewer.remove(removals.toArray(new AbstractPMDRecord[removals.size()]));
refreshList.addAll(removals);
this.treeViewer.cancelEditing();
this.treeViewer.remove(removals.toArray());
}
// perform additions
@ -533,34 +535,13 @@ public class ViolationOverviewContentProvider implements ITreeContentProvider, I
this.treeViewer.add(this.root, addedRec);
}
}
refreshList.addAll(additions);
}
// perform changes
if (changes.size() > 0) {
for (int i = 0; i < changes.size(); i++) {
final AbstractPMDRecord changedRec = (AbstractPMDRecord) changes.get(i);
if (changedRec instanceof FileRecord) {
this.treeViewer.update(changedRec, null);
this.treeViewer.update(changedRec.getChildren(), null);
}
}
refreshList.addAll(changes);
this.treeViewer.update(changes.toArray(), null);
}
refreshViewer(refreshList);
}
/**
* Refresh the viewer with the parent elements of each element in the list.
* @param elements list of changes, removals or additions (AbstractPMDRecord)
*/
protected void refreshViewer(List elements) {
final Iterator elementIterator = elements.iterator();
while (elementIterator.hasNext()) {
final AbstractPMDRecord record = (AbstractPMDRecord)elementIterator.next();
this.treeViewer.refresh(record.getParent());
}
this.violationView.refreshMenu();
this.violationView.refresh();
}
}